Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update uvwasi to 0.0.19 #49678

Closed
wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of uvwasi to 0.0.19.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Sep 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface. labels Sep 17, 2023
@@ -318,7 +318,7 @@ dependency lossless data-compression library,
it comes from the Chromium team's zlib fork which incorporated
performance improvements not currently available in standard zlib.

[acorn 8.10.0]: #acorn-8100
[acorn 0.0.19]: #acorn-0019
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to fix the updater - #49682

@mhdawson
Copy link
Member

This is also going to need an update to the https://github.com/nodejs/node/blob/main/deps/uvwasi/uvwasi.gyp as files have been added.

Once my PR to fix the updater lands I'll close this PR and then run the updater again and fix the resulting PR.

@mhdawson
Copy link
Member

Closing this as my PR landed, hopefully the next PR generated will be good.

@mhdawson mhdawson closed this Sep 25, 2023
@mhdawson
Copy link
Member

Kicked off workflow so we should get a new PR

@mhdawson mhdawson deleted the actions/tools-update-uvwasi branch September 27, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants