Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix uvwasi updater #49682

Merged
merged 1 commit into from
Sep 19, 2023
Merged

tools: fix uvwasi updater #49682

merged 1 commit into from
Sep 19, 2023

Conversation

mhdawson
Copy link
Member

  • fix uvwasi updater to update the right dep in the documentation for maintaining dependencies.

@mhdawson
tools: fix uvwasi updater
cb431e8 
- fix uvwasi updater to update the right dep in the
  documentation for maintaining dependencies.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 17, 2023
@mhdawson mhdawson mentioned this pull request Sep 17, 2023
Closed
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2ccfb23 into nodejs:main Sep 19, 2023
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2ccfb23

@richardlau richardlau mentioned this pull request Sep 27, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@mhdawson @ruyadorno
tools: fix uvwasi updater
462228b 
- fix uvwasi updater to update the right dep in the
  documentation for maintaining dependencies.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #49682
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@mhdawson @alexfernandez
tools: fix uvwasi updater
85fe76c 
- fix uvwasi updater to update the right dep in the
  documentation for maintaining dependencies.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#49682
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mhdawson @nodejs-github-bot @lpinca @anonrig @cjihrig @tniessen @richardlau @marco-ippolito @aduh95