Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate message error tests from Python to JS #49721

Merged
merged 1 commit into from
Sep 21, 2023
Merged

test: migrate message error tests from Python to JS #49721

merged 1 commit into from
Sep 21, 2023

Conversation

yiyunlei
Copy link
Contributor

Migrate the remaining error tests in the test/message folder from Python to JS.

Fixes: #47707

Migrated tests:

error/
	core_line_numbers.js
	core_line_numbers.out
	if-error-has-good-stack.js
	if-error-has-good-stack.out
	promise_unhandled_warn_with_error.js
	promise_unhandled_warn_with_error.out
	test-no-extra-info-on-fatal-exception.js
	test-no-extra-info-on-fatal-exception.out
	throw_error_with_getter_throw.js
	throw_error_with_getter_throw.out
	throw_null.js
	throw_null.out
	throw_undefined.js
	throw_undefined.out
	timeout_throw.js
	timeout_throw.out
	undefined_reference_in_new_context.js
	undefined_reference_in_new_context.out
	unhandled_promise_trace_warnings.js
	unhandled_promise_trace_warnings.out
image

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 19, 2023
test: migrate message error tests from Python to JS
986ebbe 
Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: nodejs#47707
@yiyunlei yiyunlei force-pushed the migrate-message-tests-error branch from 53e7c76 to 986ebbe Compare September 19, 2023 16:37
@yiyunlei yiyunlei mentioned this pull request Sep 19, 2023
Open
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023
@MoLow MoLow requested a review from atlowChemi September 20, 2023 20:47
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54094/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54097/

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54101/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54104/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54116/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54133/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 853f572 into nodejs:main Sep 21, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 853f572

This was referenced Sep 22, 2023
Open
Open
Open
@ruyadorno
Copy link
Member

This commit does not land cleanly on v20.x-staging and will need manual backport in case we want it in v20.

@ruyadorno ruyadorno added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Sep 28, 2023
MoLow pushed a commit to MoLow/node that referenced this pull request Sep 28, 2023
@MoLow
test: migrate message error tests from Python to JS
1c78bec 
Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: nodejs#47707
PR-URL: nodejs#49721
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@MoLow MoLow mentioned this pull request Sep 28, 2023
Closed
@MoLow MoLow added backport-open-v20.x Indicate that the PR has an open backport and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Sep 28, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@alexfernandez
test: migrate message error tests from Python to JS
e8acb4f 
Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: nodejs#47707
PR-URL: nodejs#49721
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit that referenced this pull request Nov 11, 2023
@targos
test: migrate message error tests from Python to JS
393fd5b 
Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: #47707
PR-URL: #49721
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@targos targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-open-v20.x Indicate that the PR has an open backport labels Nov 12, 2023
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
backported-to-v20.x PRs backported to the v20.x-staging branch. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

message tests can be migrated from python to JS
6 participants
@yiyunlei @nodejs-github-bot @ruyadorno @MoLow @atlowChemi @targos