Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] snapshot test improvments #49942

Closed
wants to merge 2 commits into from
Closed

[v20.x backport] snapshot test improvments #49942

wants to merge 2 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 28, 2023 •
edited
Loading

Backporting #49659 and #49721

GeoffreyBooth and others added 2 commits September 29, 2023 00:32
@GeoffreyBooth @MoLow
test: fix edge snapshot stack traces
448b9cc 
PR-URL: nodejs#49659
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@MoLow
test: migrate message error tests from Python to JS
1c78bec 
Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: nodejs#47707
PR-URL: nodejs#49721
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Sep 28, 2023
@MoLow
Copy link
Member Author

MoLow commented Nov 8, 2023

@nodejs/releasers can this land?

@RafaelGSS
Copy link
Member

#49941 (comment)

@targos
Copy link
Member

targos commented Nov 11, 2023

Landed in 5dfe423 and 393fd5b

@targos targos closed this Nov 11, 2023
@MoLow MoLow deleted the backport-message-tests branch November 12, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoLow @RafaelGSS @targos @GeoffreyBooth @nodejs-github-bot