Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update skip for moved test-wasm-web-api #49958

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

richardlau
Copy link
Member

test-wasm-web-api was moved from test/parallel to test/es-modules. Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297


Started seeing test-wasm-web-api failing for arm64 debug builds again today.
e.g. https://ci.nodejs.org/job/node-test-commit-arm-debug/nodes=ubuntu2004_debug-arm64/9557/ seems to be the earliest build that it happened in.

According to the reliability repo, we saw this test flaking at the beginning of the year. We started skipping it on arm in #47299. #49869 moved the test from test/parallel to test/es-modules but didn't move the corresponding entry in test/parallel/parallel.status.

cc @nodejs/loaders

`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 29, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2023
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 29, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49958
✔  Done loading data for nodejs/node/pull/49958
----------------------------------- PR info ------------------------------------
Title      test: update skip for moved `test-wasm-web-api` (#49958)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     richardlau:fixskip -> nodejs:main
Labels     test, esm, fast-track, author ready, needs-ci
Commits    1
 - test: update skip for moved `test-wasm-web-api`
Committers 1
 - Richard Lau 
PR-URL: https://github.com/nodejs/node/pull/49958
Refs: https://github.com/nodejs/node/pull/49869
Refs: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/issues/47297
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Geoffrey Booth 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49958
Refs: https://github.com/nodejs/node/pull/49869
Refs: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/issues/47297
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Geoffrey Booth 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 29 Sep 2023 15:56:37 GMT
   ✔  Approvals: 3
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651113176
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651340315
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651415560
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 43 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-29T17:32:55Z: https://ci.nodejs.org/job/node-test-pull-request/54383/
- Querying data for job/node-test-pull-request/54383/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6356595801

@richardlau richardlau removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 29, 2023
@richardlau richardlau added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 30, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6c9625d into nodejs:main Sep 30, 2023
52 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6c9625d

@richardlau richardlau deleted the fixskip branch September 30, 2023 23:30
GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request Oct 1, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
PR-URL: nodejs#49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
PR-URL: nodejs#49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Nov 11, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297
PR-URL: #49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
PR-URL: nodejs#49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants