src: fix compatility with upcoming V8 12.1 APIs #50709

zcbenz · 2023-11-13T13:19:58Z

In the upcoming V8 11.10 there are a few API changes will break building of Node, this PR makes the code compatible with both old and new APIs.

This PR is needed because V8's node-ci repo tests latest Node with latest V8, and without this change V8 has to patch Node in their own fork.

nodejs-github-bot · 2023-11-13T13:20:03Z

Review requested:

@nodejs/node-api
@nodejs/startup

targos · 2023-11-13T13:27:18Z

V8 11.10 doesn't exist. The Error API changes are in V8 12.0 and the other changes will be in V8 12.1 (I think).

zcbenz · 2023-11-13T13:34:54Z

Thanks for the info! I have changed the title.

nodejs-github-bot · 2023-11-14T03:27:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55629/

nodejs-github-bot · 2023-11-15T13:28:15Z

Commit Queue failed

- Loading data for nodejs/node/pull/50709
✔  Done loading data for nodejs/node/pull/50709
----------------------------------- PR info ------------------------------------
Title      src: fix compatility with upcoming V8 12.1 APIs (#50709)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     zcbenz:fix-v8-119-api -> nodejs:main
Labels     c++, lib / src, needs-ci
Commits    1
 - src: fix compatility with upcoming V8 12.1 APIs
Committers 1
 - Cheng Zhao 
PR-URL: https://github.com/nodejs/node/pull/50709
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50709
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 13 Nov 2023 13:19:58 GMT
   ✔  Approvals: 3
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/50709#pullrequestreview-1727352282
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50709#pullrequestreview-1727436502
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/50709#pullrequestreview-1728714263
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-11-14T03:27:39Z: https://ci.nodejs.org/job/node-test-pull-request/55629/
- Querying data for job/node-test-pull-request/55629/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6877934814

Refs: #50709

nodejs-github-bot · 2023-11-16T06:59:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55675/

Refs: nodejs/node#50709

nodejs-github-bot · 2023-11-18T19:15:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55748/

Refs: nodejs/node#50709

nodejs/node#50709

PR-URL: #50709 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs/node#50709

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closes nodejs/node#49327 * test: deflake test-tls-socket-close nodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixes nodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

PR-URL: #50709 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closes nodejs/node#49327 * test: deflake test-tls-socket-close nodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixes nodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

PR-URL: #50709 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs/node#50709

* chore: bump node in DEPS to v20.11.0 * module: bootstrap module loaders in shadow realm nodejs/node#48655 * src: add commit hash shorthand in zlib version nodejs/node#50158 * v8,tools: expose necessary V8 defines nodejs/node#50820 * esm: do not call getSource when format is commonjs nodejs/node#50465 * esm: fallback to readFileSync when source is nullish nodejs/node#50825 * vm: allow dynamic import with a referrer realm nodejs/node#50360 * test: skip test-diagnostics-channel-memory-leak.js nodejs/node#50327 * esm: do not call getSource when format is commonjs nodejs/node#50465 * lib: fix assert throwing different error messages in ESM and CJS nodejs/node#50634 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * deps: update base64 to 0.5.1 nodejs/node#50629 * src: avoid silent coercion to signed/unsigned int nodejs/node#50663 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * chore: fix patch indices * chore: update patches * test: disable TLS cipher test This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186 * fix: check for Buffer and global definition in shadow realm nodejs/node#51239 * test: disable parallel/test-shadow-realm-custom-loader Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle * chore: remove deleted parallel/test-crypto-modp1-error test * test: make test-node-output-v8-warning generic nodejs/node#50421 * chore: fixup ModuleWrap patch * test: match wpt/streams/transferable/transform-stream-members.any.js to upstream * fix: sandbox is not enabled on arm * chore: disable v8 sandbox on ia32/arm --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 13, 2023

src: fix compatility with upcoming V8 12.1 APIs

465092a

zcbenz force-pushed the fix-v8-119-api branch from 0b1876a to 465092a Compare November 13, 2023 13:33

zcbenz changed the title ~~src: fix compatility with V8 11.10 APIs~~ src: fix compatility with upcoming V8 12.1 APIs Nov 13, 2023

targos approved these changes Nov 13, 2023

View reviewed changes

joyeecheung approved these changes Nov 13, 2023

View reviewed changes

zcbenz mentioned this pull request Nov 14, 2023

Things blocking a full-featured GN build of upstream Node.js photoionization/node_with_gn#1

Closed

27 tasks

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023

gengjiawen approved these changes Nov 14, 2023

View reviewed changes

github-actions bot mentioned this pull request Nov 15, 2023

CI Reliability 2023-11-15 nodejs/reliability#718

Open

26 tasks

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 15, 2023

targos added a commit that referenced this pull request Nov 15, 2023

src: port V8 12.1 compat patch

fd10792

Refs: #50709

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 16, 2023

src: port V8 12.1 compat patch

85fa2c4

Refs: nodejs/node#50709

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 17, 2023

src: port V8 12.1 compat patch

0186de2

Refs: nodejs/node#50709

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 18, 2023

src: port V8 12.1 compat patch

a58f528

Refs: nodejs/node#50709

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 19, 2023

src: port V8 12.1 compat patch

d58a372

Refs: nodejs/node#50709

jasnell approved these changes Nov 19, 2023

View reviewed changes

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 20, 2023

src: port V8 12.1 compat patch

ab7387e

Refs: nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Nov 28, 2023

src: fix compatility with upcoming V8 12.1 APIs

5a98bea

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Nov 29, 2023

src: fix compatility with upcoming V8 12.1 APIs

5247cf9

nodejs/node#50709

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

codebytere added a commit to electron/electron that referenced this pull request Jan 10, 2024

src: fix compatility with upcoming V8 12.1 APIs

12b263f

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 10, 2024

src: fix compatility with upcoming V8 12.1 APIs

05e0997

nodejs/node#50709

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024

src: fix compatility with upcoming V8 12.1 APIs

b96e26c

nodejs/node#50709

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024

src: fix compatility with upcoming V8 12.1 APIs

6ffd3b0

nodejs/node#50709

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024

src: fix compatility with upcoming V8 12.1 APIs

c77798a

nodejs/node#50709

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024

src: fix compatility with upcoming V8 12.1 APIs

fd7ef2c

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024

src: fix compatility with upcoming V8 12.1 APIs

428724e

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024

src: fix compatility with upcoming V8 12.1 APIs

8870f0d

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024

src: fix compatility with upcoming V8 12.1 APIs

df29731

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024

src: fix compatility with upcoming V8 12.1 APIs

d780411

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 16, 2024

src: fix compatility with upcoming V8 12.1 APIs

bff0e62

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 16, 2024

src: fix compatility with upcoming V8 12.1 APIs

98a60b9

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024

src: fix compatility with upcoming V8 12.1 APIs

5261924

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024

src: fix compatility with upcoming V8 12.1 APIs

e7a5236

nodejs/node#50709

jkleinsc pushed a commit to electron/electron that referenced this pull request Jan 18, 2024

src: fix compatility with upcoming V8 12.1 APIs

6105649

nodejs/node#50709

jkleinsc pushed a commit to electron/electron that referenced this pull request Jan 18, 2024

src: fix compatility with upcoming V8 12.1 APIs

81b573e

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024

src: fix compatility with upcoming V8 12.1 APIs

ccb0131

nodejs/node#50709

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024

src: fix compatility with upcoming V8 12.1 APIs

dc8f710

nodejs/node#50709

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: fix compatility with upcoming V8 12.1 APIs #50709

src: fix compatility with upcoming V8 12.1 APIs #50709

zcbenz commented Nov 13, 2023

nodejs-github-bot commented Nov 13, 2023

targos commented Nov 13, 2023

zcbenz commented Nov 13, 2023

nodejs-github-bot commented Nov 14, 2023

nodejs-github-bot commented Nov 15, 2023

nodejs-github-bot commented Nov 16, 2023

nodejs-github-bot commented Nov 18, 2023

src: fix compatility with upcoming V8 12.1 APIs #50709

src: fix compatility with upcoming V8 12.1 APIs #50709

Conversation

zcbenz commented Nov 13, 2023

nodejs-github-bot commented Nov 13, 2023

targos commented Nov 13, 2023

zcbenz commented Nov 13, 2023

nodejs-github-bot commented Nov 14, 2023

nodejs-github-bot commented Nov 15, 2023

nodejs-github-bot commented Nov 16, 2023

nodejs-github-bot commented Nov 18, 2023