Skip to content

src: disable abort exceptions for module loading #50987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2023
Merged

src: disable abort exceptions for module loading #50987

merged 1 commit into from
Dec 3, 2023

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Dec 1, 2023

Fixes #50878.

Thanks @joyeecheung for the tip on temporarily disable abort_on_uncaught_exception while checking for modules.

cc @nodejs/loaders @nodejs/cpp-reviewers

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Dec 1, 2023
@anonrig anonrig force-pushed the fix-contains-module-syntax branch 4 times, most recently from 7e81ca2 to 080b5c9 Compare December 1, 2023 01:25
GeoffreyBooth
GeoffreyBooth approved these changes Dec 1, 2023
View reviewed changes
@anonrig anonrig force-pushed the fix-contains-module-syntax branch from 080b5c9 to 43020e5 Compare December 1, 2023 01:28
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56025/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56027/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56028/

joyeecheung
joyeecheung reviewed Dec 1, 2023
View reviewed changes
@joyeecheung
Copy link
Member

joyeecheung commented Dec 1, 2023

The commit message is not quite accurate, it should be something like "disable uncaught exception abortion for ESM syntax detection"

aduh95
aduh95 reviewed Dec 1, 2023
View reviewed changes
@anonrig anonrig force-pushed the fix-contains-module-syntax branch from 43020e5 to ae34969 Compare December 2, 2023 22:49
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 2, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56048/

targos
targos requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want at least an answer on #50987 (comment)

@anonrig anonrig force-pushed the fix-contains-module-syntax branch from ae34969 to 86d275a Compare December 3, 2023 15:04
@anonrig
Copy link
Member Author

anonrig commented Dec 3, 2023

I want at least an answer on #50987 (comment)

Sorry @targos. I missed your comment! It seems your suggestion is better. I applied the proposed changes.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56051/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56058/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit 951d00d into nodejs:main Dec 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

Landed in 951d00d

targos pushed a commit that referenced this pull request Dec 4, 2023
@anonrig @targos
src: disable uncaught exception abortion for ESM syntax detection
709ac47 
PR-URL: #50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targos targos mentioned this pull request Dec 4, 2023
Merged
Mateusz-Kopec pushed a commit to Mateusz-Kopec/node that referenced this pull request Mar 6, 2024
@anonrig @Mateusz-Kopec
src: disable uncaught exception abortion for ESM syntax detection
7955fb6 
PR-URL: nodejs#50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@Mateusz-Kopec Mateusz-Kopec mentioned this pull request Mar 6, 2024
Closed
Mateusz-Kopec pushed a commit to Mateusz-Kopec/node that referenced this pull request Mar 6, 2024
@anonrig @Mateusz-Kopec
src: disable uncaught exception abortion for ESM syntax detection
96f067c 
PR-URL: nodejs#50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

Backport-PR-URL: nodejs#51989
@anonrig anonrig added lts-watch-v18.x lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 6, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@anonrig @richardlau
src: disable uncaught exception abortion for ESM syntax detection
362135a 
PR-URL: #50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
@targos targos removed the lts-watch-v20.x PRs that may need to be released in v20.x label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@targos targos targos approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] --abort-on-uncaught-exception causes containsModuleSyntax to improperly throw Uncaught SyntaxError: Cannot use import statement outside a module

7 participants

@anonrig @nodejs-github-bot @joyeecheung @GeoffreyBooth @targos @JakobJingleheimer @aduh95