[v20.x backport] src: disable uncaught exception abortion for ESM syntax detection #51989
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
PR-URL: nodejs#50987 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Backport-PR-URL: nodejs#51989
Mateusz-Kopec
force-pushed
the
backport-50987-to-v20.x
branch
from
7955fb6 to
96f067c
Compare
Member
|
cc @nodejs/releasers |
Member
|
Is it a clean cherry-pick? If that's the case, a backport PR shouldn't be necessary. We use |
Author
It is clean cherry-pick, is there a way for me to add label? I assume there's some permission that prevents label spam from people that are not maintainers. |
Member
|
I've added the labels. |
Author
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #50987
Fixes: #50878
I confirmed that Wrapping a
requireof an ES module while using--abort-on-uncaught-exceptionfails without the fixPS. I read through Backporting release lines and Contributing and I'm still not sure what should I do to get the fix backported.
a) Is it still "baking", is the process automated so should I just wait a bit more?
b) Should I just add some label
backport-requested-vN.xand because there are no conflicts it will be automatically backported? I guess it's not possible.c) Was it decided that fix shouldn't land in LTS?
Please let me know if I should close this PR and request it some other way. :)