Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code of conduct to clarify reporting and moderation #5107

Closed
wants to merge 1 commit into from
Closed

Update code of conduct to clarify reporting and moderation #5107

wants to merge 1 commit into from

Conversation

juliepagano
Copy link
Contributor

This PR:

  • Adds section headings to make it easier to quickly parse.
  • Adds easy to find contact information for people who need to report an issue.
  • Adds link to TSC moderation policies, which are relevant to the code of conduct.
  • Moves attribution to the bottom of the page (it's important, but probably not the first thing someone's looking for when they come to the page).

This PR was prompted by the inclusivity WG being notified that someone was having trouble figuring out who to report an incident to. Hopefully this will make that information easier to find.

juliepagano
juliepagano reviewed Feb 5, 2016
View reviewed changes
CODE_OF_CONDUCT.md
reported by:

* Emailing [report@nodejs.org](mailto:report@nodejs.org) (this will email all TSC members)
* Contacting [individual TSC members](https://nodejs.org/en/foundation/tsc/#current-members-of-the-technical-steering-committee).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better place I can link people for contact info for the TSC or is the right thing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, looks like that's on me, not yet, but: nodejs/TSC#1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it alone for now. We can change it when that lands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't an email to report@nodejs.org the way to go? Individual TSC members may have different ideas on how to deal with an issue so contacting one individually may lead to a certain level of arbitrariness.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just explicitly repeating the contact guidelines in the moderation policy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, filed an issue for that: nodejs/TSC#45

@Fishrock123 Fishrock123 added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Feb 5, 2016
@Fishrock123
Copy link
Contributor

Heya, could you make sure the commit messages are max 50 chars and the descriptions are max 72?

Also I think the latter 3 commits could probably be squashed into one.

Seems fine to me otherwise. The contact details definitely need to be easily accessible.

@MylesBorins
Copy link
Contributor

LGTM (if suggested fixes are included)

@juliepagano
Copy link
Contributor Author

@Fishrock123 Sorry bout that. Was doing this quickly in the github UI and the commits were a little more quick and dirty than they should be. Will pull it down, clean things up a bit, and update shortly.

@juliepagano
doc: clarify code of conduct reporting
0f4ae13 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.
@juliepagano
Copy link
Contributor Author

I squashed it all into one commit since it's a pretty small change and modified the commit message to match the contribution guidelines.

Is "doc" the right subsystem to list in the first line or should it be something else? Happy to change it something else if there's a specific thing I should use for policy documentation like this.

@Fishrock123
Copy link
Contributor

@juliepagano Nah, we usually just use doc: for all of that.

@mscdex mscdex removed the meta Issues and PRs related to the general management of the project. label Feb 5, 2016
@jasnell
Copy link
Member

jasnell commented Feb 7, 2016

LGTM

bnoordhuis
bnoordhuis reviewed Feb 7, 2016
View reviewed changes
CODE_OF_CONDUCT.md
@@ -1,8 +1,6 @@
## Code of Conduct

This Code of Conduct is adapted from [Rust's wonderful
CoC](http://www.rust-lang.org/conduct.html) as well as the
[Contributor Covenant v1.3.0](http://contributor-covenant.org/version/1/3/0/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this section removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to the bottom

@zkat
Copy link
Contributor

zkat commented Feb 7, 2016

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

Thanks, landed in 1e146e7

@Fishrock123 Fishrock123 closed this Feb 8, 2016
Fishrock123 pushed a commit that referenced this pull request Feb 8, 2016
@juliepagano @Fishrock123
doc: clarify code of conduct reporting
1e146e7 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Feb 9, 2016
@juliepagano @rvagg
doc: clarify code of conduct reporting
d975098 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Feb 9, 2016
@juliepagano @rvagg
doc: clarify code of conduct reporting
027cd27 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Mar 10, 2016
@juliepagano
doc: clarify code of conduct reporting
cfaee62 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@juliepagano
doc: clarify code of conduct reporting
3e14933 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@juliepagano
doc: clarify code of conduct reporting
67245fa 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: #5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@juliepagano
doc: clarify code of conduct reporting
0b59340 
Clarifies the code of conduct by making the following changes:

- Adds section headings to make it easier to quickly parse.
- Adds easy to find contact information.
- Adds link to TSC moderation policies.
- Moves attribution to the bottom of the page.

PR-URL: nodejs#5107
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kat Marchán <kzm@sykosomatic.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@juliepagano @Fishrock123 @MylesBorins @jasnell @zkat @evanlucas @bnoordhuis @mscdex