Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: deprecate hmac public constructor #51881

Merged

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Feb 26, 2024

Needs to be rebased after: #51879

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Feb 26, 2024
@marco-ippolito marco-ippolito added crypto Issues and PRs related to the crypto subsystem. blocked PRs that are blocked by other issues or PRs. labels Feb 26, 2024
@marco-ippolito marco-ippolito changed the title doc: doc-deprecate hmac public constructor doc: deprecate hmac public constructor Mar 5, 2024
@marco-ippolito marco-ippolito removed the blocked PRs that are blocked by other issues or PRs. label Mar 5, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit edd6190 into nodejs:main Mar 6, 2024
15 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in edd6190

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
PR-URL: nodejs#51881
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito added a commit that referenced this pull request May 2, 2024
PR-URL: #51881
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
PR-URL: nodejs#51881
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants