Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.13.0 proposal #52793

Merged
merged 250 commits into from
May 7, 2024
Merged

v20.13.0 proposal #52793

merged 250 commits into from
May 7, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented May 2, 2024

2024-05-07, Version 20.13.0 'Iron' (LTS), @marco-ippolito

buffer: improve base64 and base64url performance

The performance of the base64 and base64url encoding and decoding functions has been improved significantly.

Contributed by Yagiz Nizipli in #52428

crypto: deprecate implicitly shortened GCM tags

This release, introduces a doc-only deprecation of using GCM authentication tags that are shorter than the cipher's block size, unless the user specified the authTagLength option.

Contributed by Tobias Nießen in #52345

events,doc: mark CustomEvent as stable

From this release CustomEvent has been marked stable.

Contributed by Daeyeon Jeong in #52618

fs: add stacktrace to fs/promises

Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error.

Contributed by 翠 / green in #49849

report: add --report-exclude-network option

New option --report-exclude-network, also available as report.excludeNetwork, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that.

Contributed by Ethan Arrowood in #51645

src: add uv_get_available_memory to report and process

From this release it is possible to get the available memory in the system by calling process.getAvailableMemory().

Contributed by theanarkh #52023

stream: support typed arrays

This commit adds support for typed arrays in streams.

Contributed by IlyasShabi #51866

util: support array of formats in util.styleText

It is now possible to pass an array of format strings to util.styleText to apply multiple formats to the same text.

console.log(util.styleText(['underline', 'italic'], 'My italic underlined message'));

Contributed by Marco Ippolito in #52040

v8: implement v8.queryObjects() for memory leak regression testing

This is similar to the queryObjects() console API provided by the Chromium DevTools console. It can be used to search for objects that have the matching constructor on its prototype chain in the heap after a full garbage collection, which can be useful for memory leak regression tests.
To avoid surprising results, users should avoid using this API on constructors whose implementation they don't control, or on constructors that can be invoked by other parties in the application.

To avoid accidental leaks, this API does not return raw references to the objects found. By default, it returns the count of the objects found. If options.format is 'summary', it returns an array containing brief string representations for each object. The visibility provided in this API is similar to what the heap snapshot provides, while users can save the cost of serialization and parsing and directly filer the target objects during the search.

We have been using this API internally for the test suite, which has been more stable than any other leak regression testing strategies in the CI. With a public implementation we can now use the public API instead.

const { queryObjects } = require('node:v8');
class A { foo = 'bar'; }
console.log(queryObjects(A)); // 0
let a = new A();
console.log(queryObjects(A)); // 1
// [ "A { foo: 'bar' }" ]
console.log(queryObjects(A, { format: 'summary' }));

// Release the object.
a = null;
// Search again. queryObjects() includes a full garbage collection
// so a should disappear.
console.log(queryObjects(A)); // 0

class B extends A { bar = 'qux'; }
// The child class B's prototype has A's prototype on its prototype chain
// so the prototype object shows up too.
console.log(queryObjects(A, { format: 'summary' })); // [ A {}' ]

Contributed by Joyee Cheung in #51927

watch: mark as stable

From this release Watch Mode is considered stable.
When in watch mode, changes in the watched files cause the Node.js process to restart.

Contributed by Moshe Atlow in #52074

Other Notable Changes

  • [f8ad30048d] - benchmark: add AbortSignal.abort benchmarks (Raz Luvaton) #52408
  • [3b41da9a56] - (SEMVER-MINOR) deps: update simdutf to 5.0.0 (Daniel Lemire) #52138
  • [0a08c4a7b3] - (SEMVER-MINOR) deps: update undici to 6.3.0 (Node.js GitHub Bot) #51462
  • [f1b7bda4f5] - (SEMVER-MINOR) deps: update undici to 6.2.1 (Node.js GitHub Bot) #51278
  • [4acca8ed84] - (SEMVER-MINOR) dns: add order option and support ipv6first (Paolo Insogna) #52492
  • [cc67720ff9] - doc: update release gpg keyserver (marco-ippolito) #52257
  • [c2def7df96] - doc: add release key for marco-ippolito (marco-ippolito) #52257
  • [807c89cb26] - doc: add UlisesGascon as a collaborator (Ulises Gascón) #51991
  • [5e78a20ef9] - (SEMVER-MINOR) doc: deprecate fs.Stats public constructor (Marco Ippolito) #51879
  • [722fe64ff7] - (SEMVER-MINOR) lib, url: add a windows option to path parsing (Aviv Keller) #52509
  • [d116fa1568] - (SEMVER-MINOR) net: add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
  • [6af7b78b0d] - (SEMVER-MINOR) src: add string_view overload to snapshot FromBlob (Anna Henningsen) #52595
  • [b3a11b574b] - (SEMVER-MINOR) src: preload function for Environment (Cheng Zhao) #51539
  • [41646d9c9e] - (SEMVER-MINOR) test_runner: add suite() (Colin Ihrig) #52127
  • [fc9ba17f6c] - (SEMVER-MINOR) test_runner: add test:complete event to reflect execution order (Moshe Atlow) #51909

Commits

  • [6fdd748b21] - benchmark: reduce the buffer size for blob (Debadree Chatterjee) #52548
  • [2274d0c868] - benchmark: inherit stdio/stderr instead of pipe (Ali Hassan) #52456
  • [0300598315] - benchmark: add ipc support to spawn stdio config (Ali Hassan) #52456
  • [f8ad30048d] - benchmark: add AbortSignal.abort benchmarks (Raz Luvaton) #52408
  • [7508d48736] - benchmark: conditionally use spawn with taskset for cpu pinning (Ali Hassan) #52253
  • [ea8e72e185] - benchmark: add toNamespacedPath bench (Rafael Gonzaga) #52236
  • [c00715cc1e] - benchmark: add style-text benchmark (Rafael Gonzaga) #52004
  • [1c1a6935ee] - buffer: add missing ARG_TYPE(ArrayBuffer) for isUtf8 (Jungku Lee) #52477
  • [1b2aff7dce] - buffer: improve base64 and base64url performance (Yagiz Nizipli) #52428
  • [328bded5ab] - buffer: improve btoa performance (Yagiz Nizipli) #52427
  • [e67bc34326] - buffer: use simdutf for atob implementation (Yagiz Nizipli) #52381
  • [5abddb45d8] - build: fix typo in node.gyp (Michaël Zasso) #52719
  • [7d1f304f5e] - build: fix headers install for shared mode on Win (Segev Finer) #52442
  • [6826bbf267] - build: fix arm64 cross-compilation bug on non-arm machines (Mahdi Sharifi) #52559
  • [6e85bc431a] - build: temporary disable ubsan (Rafael Gonzaga) #52560
  • [297368a1ed] - build: fix arm64 cross-compilation (Michaël Zasso) #51256
  • [93bddb598f] - build,tools: add test-ubsan ci (Rafael Gonzaga) #46297
  • [20bb16582f] - build,tools,node-api: fix building node-api tests for Windows Debug (Vladimir Morozov) #52632
  • [9af15cfff1] - child_process: use internal addAbortListener (Chemi Atlow) #52081
  • [a4847c4619] - crypto: simplify assertions in Safe*Print (David Benjamin) #49709
  • [0ec4d9d734] - crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL (Shelley Vohr) #52217
  • [03e05b092c] - crypto: deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
  • [0f784c96ba] - crypto: make timingSafeEqual faster for Uint8Array (Tobias Nießen) #52341
  • [739958e472] - crypto: reject Ed25519/Ed448 in Sign/Verify prototypes (Filip Skokan) #52340
  • [197b61f210] - crypto: validate RSA-PSS saltLength in subtle.sign and subtle.verify (Filip Skokan) #52262
  • [a6eede33f3] - crypto: fix input validation in crypto.hash (Antoine du Hamel) #52070
  • [bfa4986e5d] - deps: update corepack to 0.28.0 (Node.js GitHub Bot) #52616
  • [70546698d7] - deps: update ada to 2.7.8 (Node.js GitHub Bot) #52517
  • [a135027f84] - deps: update icu to 75.1 (Node.js GitHub Bot) #52573
  • [c96f1043d4] - deps: update undici to 6.13.0 (Node.js GitHub Bot) #52493
  • [9c330b610b] - deps: update zlib to 1.3.0.1-motley-7d77fb7 (Node.js GitHub Bot) #52516
  • [7e5bbeebab] - deps: update nghttp2 to 1.61.0 (Node.js GitHub Bot) #52395
  • [b42a4735d9] - deps: update minimatch to 9.0.4 (Node.js GitHub Bot) #52524
  • [d34fd21bc2] - deps: update simdutf to 5.2.4 (Node.js GitHub Bot) #52473
  • [ecc180f830] - deps: upgrade npm to 10.5.2 (npm team) #52458
  • [606c183344] - deps: update simdutf to 5.2.3 (Yagiz Nizipli) #52381
  • [0a103e99fe] - deps: upgrade npm to 10.5.1 (npm team) #52351
  • [cce861e670] - deps: update c-ares to 1.28.1 (Node.js GitHub Bot) #52285
  • [5258b547ea] - deps: update undici to 6.11.1 (Node.js GitHub Bot) #52328
  • [923a77c80a] - deps: update undici to 6.10.2 (Node.js GitHub Bot) #52227
  • [bd3c6a231c] - deps: update zlib to 1.3.0.1-motley-24c07df (Node.js GitHub Bot) #52199
  • [3b41da9a56] - (SEMVER-MINOR) deps: update simdutf to 5.0.0 (Daniel Lemire) #52138
  • [d6f9ca385c] - deps: update zlib to 1.3.0.1-motley-24342f6 (Node.js GitHub Bot) #52123
  • [f5512897b0] - deps: update corepack to 0.26.0 (Node.js GitHub Bot) #52027
  • [d891275178] - deps: update ada to 2.7.7 (Node.js GitHub Bot) #52028
  • [18838f2db3] - deps: update simdutf to 4.0.9 (Node.js GitHub Bot) #51655
  • [503c034abc] - deps: update undici to 6.6.2 (Node.js GitHub Bot) #51667
  • [256bcba52e] - deps: update undici to 6.6.0 (Node.js GitHub Bot) #51630
  • [7a1e321d95] - deps: update undici to 6.4.0 (Node.js GitHub Bot) #51527
  • [dde9e08224] - deps: update ngtcp2 to 1.1.0 (Node.js GitHub Bot) #51319
  • [0a08c4a7b3] - (SEMVER-MINOR) deps: update undici to 6.3.0 (Node.js GitHub Bot) #51462
  • [f1b7bda4f5] - (SEMVER-MINOR) deps: update undici to 6.2.1 (Node.js GitHub Bot) #51278
  • [ecadd638cd] - deps: V8: remove references to non-existent flags (Richard Lau) #52256
  • [27d364491f] - dgram: use internal addAbortListener (Chemi Atlow) #52081
  • [b94d11935a] - diagnostics_channel: early-exit tracing channel trace methods (Stephen Belanger) #51915
  • [4acca8ed84] - (SEMVER-MINOR) dns: add order option and support ipv6first (Paolo Insogna) #52492
  • [bcc06ac5a9] - doc: remove relative limitation to pm (Rafael Gonzaga) #52648
  • [4d5ef4f7af] - doc: fix info string causing duplicated code blocks (Mathieu Leenhardt) #52660
  • [d5a316f5ea] - doc: run license-builder (github-actions[bot]) #52631
  • [d7434fe411] - doc: deprecate --experimental-policy (RafaelGSS) #52602
  • [02a83d89f7] - doc: add info on contributor spotlight program (Michael Dawson) #52598
  • [a905eaace1] - doc: correct unsafe URL example in http docs (Malte Legenhausen) #52555
  • [69c21a6522] - doc: replace U+00A0 with U+0020 (Luigi Pinca) #52590
  • [5df34c7d0a] - doc: sort options alphabetically (Luigi Pinca) #52589
  • [b49464bc9d] - doc: correct stream.finished changes (KaKa) #52551
  • [4d051ba89b] - doc: add RedYetiDev to triage team (Aviv Keller) #52556
  • [4ed55bf16c] - doc: fix issue detected in markdown lint update (Rich Trott) #52566
  • [a8bc40fd07] - doc: update test runner coverage limitations (Moshe Atlow) #52515
  • [17d5ba9fed] - doc: add lint-js-fix into BUILDING.md (jakecastelli) #52290
  • [88adbd0991] - doc: remove Internet Explorer mention in BUILDING.md (Rich Trott) #52455
  • [e8cb29d66d] - doc: accommodate upcoming stricter .md linting (Rich Trott) #52454
  • [e2ea984c7b] - doc: add Rafael to steward list (Rafael Gonzaga) #52452
  • [93d684097a] - doc: correct naming convention in C++ style guide (Mohammed Keyvanzadeh) #52424
  • [b9bdb947ac] - doc: update process.execArg example to be more useful (Jacob Smith) #52412
  • [f3f67ff84a] - doc: call out http(s).globalAgent default (mathis-west-1) #52392
  • [392a0d310e] - doc: update the location of build_with_cmake (Emmanuel Ferdman) #52356
  • [3ad62f1cc7] - doc: reserve 125 for Electron 31 (Shelley Vohr) #52379
  • [bfd4c7844b] - doc: use consistent plural form of "index" (Rich Trott) #52373
  • [6f31cc8361] - doc: add Rafael to sec release stewards (Rafael Gonzaga) #52354
  • [c55a3be789] - doc: document missing options of events.on (Chemi Atlow) #52080
  • [1a843f7c6d] - doc: add missing space (Augustin Mauroy) #52360
  • [8ee20d8693] - doc: add tips about vcpkg cause build faild on windows (Cong Zhang) #52181
  • [a86705c113] - doc: replace "below" with "following" (Rich Trott) #52315
  • [f3e8d1159a] - doc: fix email pattern to be wrapped with << instead of single < (Raz Luvaton) #52284
  • [cc67720ff9] - doc: update release gpg keyserver (marco-ippolito) #52257
  • [c2def7df96] - doc: add release key for marco-ippolito (marco-ippolito) #52257
  • [2509f3be18] - doc: fix arrow vertical alignment in HTML version (Akash Yeole) #52193
  • [2abaea3cdc] - doc: move TSC members from regular to emeritus (Michael Dawson) #52209
  • [65618a3d7b] - doc: add section explaining todo tests (Colin Ihrig) #52204
  • [bf0ed95b04] - doc: edit ChildProcess 'message' event docs (theanarkh) #52154
  • [3d67b6b5e8] - doc: add mold to speeding up section (Cong Zhang) #52179
  • [8ba308a838] - doc: http event order correction (wh0) #51464
  • [9771f41069] - doc: move gabrielschulhof to TSC emeritus (Gabriel Schulhof) #52192
  • [72bd2b0d62] - doc: fix --env-file docs for valid quotes for defining values (Gabriel Bota) #52157
  • [4f19203dfb] - doc: clarify what is supported in NODE_OPTIONS (Michael Dawson) #52076
  • [5bce596838] - doc: fix typos in maintaining-dependencies.md (RoboSchmied) #52160
  • [f5241e20cc] - doc: add spec for contains module syntax (Geoffrey Booth) #52059
  • [bda3cdea86] - doc: optimize the doc about Unix abstract socket (theanarkh) #52043
  • [8d7d6eff81] - doc: update pnpm link (Superchupu) #52113
  • [af7c55f62d] - doc: remove ableist language from crypto (Jamie King) #52063
  • [f8362b0a5a] - doc: update collaborator email (Ruy Adorno) #52088
  • [48cbd5f71e] - doc: state that removing npm is a non-goal (Geoffrey Booth) #51951
  • [0ef2708131] - doc: mention NodeSource in RafaelGSS steward list (Rafael Gonzaga) #52057
  • [a6473a89be] - doc: remove ArrayBuffer from crypto.hash() data parameter type (fengmk2) #52069
  • [ae7a11c787] - doc: add some commonly used lables up gront (Michael Dawson) #52006
  • [01aaddde3c] - doc: document that const c2 = vm.createContext(c1); c1 === c2 is true (Daniel Kaplan) #51960
  • [912145fac4] - doc: clarify what moderation issues are for (Antoine du Hamel) #51990
  • [807c89cb26] - doc: add UlisesGascon as a collaborator (Ulises Gascón) #51991
  • [53ff3e5682] - doc: deprecate hmac public constructor (Marco Ippolito) #51881
  • [5e78a20ef9] - (SEMVER-MINOR) doc: deprecate fs.Stats public constructor (Marco Ippolito) #51879
  • [7bfb0b43e6] - events: rename high & low watermark for consistency (Chemi Atlow) #52080
  • [5e6967359b] - events: extract addAbortListener for safe internal use (Chemi Atlow) #52081
  • [6930205272] - events: remove abort listener from signal in on (Neal Beeken) #51091
  • [235ab4f99f] - events,doc: mark CustomEvent as stable (Daeyeon Jeong) #52618
  • [ca5b827148] - fs: fix read / readSync positional offset types (Ruy Adorno) #52603
  • [e7d0d804b2] - fs: fixes recursive fs.watch crash on Linux when deleting files (Matteo Collina) #52349
  • [c5fd193d6b] - fs: refactor maybeCallback function (Yagiz Nizipli) #52129
  • [0a9910c2c1] - fs: fix edge case in readFileSync utf8 fast path (Richard Lau) #52101
  • [51d7cd5de8] - fs: validate fd from cpp on fchown (Yagiz Nizipli) #52051
  • [33ad86c2be] - fs: validate fd from cpp on close (Yagiz Nizipli) #52051
  • [34667c0a7e] - fs: validate file mode from cpp (Yagiz Nizipli) #52050
  • [c530520be3] - fs: add stacktrace to fs/promises (翠 / green) #49849
  • [edecd464b9] - fs,permission: make handling of buffers consistent (Tobias Nießen) #52348
  • [3bcd68337e] - http2: fix excessive CPU usage when using allowHTTP1=true (Eugene) #52713
  • [e01015996a] - http2: fix h2-over-h2 connection proxying (Tim Perry) #52368
  • [9f88736860] - http2: use internal addAbortListener (Chemi Atlow) #52081
  • [acd7758959] - lib: use predefined variable instead of bit operation (Deokjin Kim) #52580
  • [18ae7a46f6] - lib: refactor lazy loading of undici for fetch method (Victor Chen) #52275
  • [64c2c2a7ac] - lib: replace string prototype usage with alternatives (Aviv Keller) #52440
  • [ee11b5315c] - lib: .load .save add proper error message when no file passed (Thomas Mauran) #52225
  • [e5521b537f] - lib: fix type error for _refreshLine (Jackson Tian) #52133
  • [d5d6e041c8] - lib: emit listening event once when call listen twice (theanarkh) #52119
  • [d33fc36784] - lib: make sure clear the old timer in http server (theanarkh) #52118
  • [ea4905c0f5] - lib: fix listen with handle in cluster worker (theanarkh) #52056
  • [8fd8130507] - lib, doc: rename readme.md to README.md (Aviv Keller) #52471
  • [722fe64ff7] - (SEMVER-MINOR) lib, url: add a windows option to path parsing (Aviv Keller) #52509
  • [26691e6032] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #52633
  • [befb90dc83] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #52457
  • [22b7167e72] - meta: bump actions/download-artifact from 4.1.3 to 4.1.4 (dependabot[bot]) #52314
  • [4dafd3ede2] - meta: bump rtCamp/action-slack-notify from 2.2.1 to 2.3.0 (dependabot[bot]) #52313
  • [2760db7640] - meta: bump github/codeql-action from 3.24.6 to 3.24.9 (dependabot[bot]) #52312
  • [542aaf9ca9] - meta: bump actions/cache from 4.0.1 to 4.0.2 (dependabot[bot]) #52311
  • [df330998d9] - meta: bump actions/setup-python from 5.0.0 to 5.1.0 (dependabot[bot]) #52310
  • [5f40fe0cc2] - meta: bump codecov/codecov-action from 4.1.0 to 4.1.1 (dependabot[bot]) #52308
  • [481420f25c] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #52300
  • [3121949f85] - meta: pass Codecov upload token to codecov action (Michaël Zasso) #51982
  • [882a64e639] - module: fix detect-module not retrying as esm for cjs-only errors (Geoffrey Booth) #52024
  • [5fcc1d32a8] - module: refactor ESM loader initialization and entry point handling (Joyee Cheung) #51999
  • [d116fa1568] - (SEMVER-MINOR) net: add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
  • [37abad86ae] - net: use internal addAbortListener (Chemi Atlow) #52081
  • [a920489a1f] - node-api: address coverity report (Michael Dawson) #52584
  • [0a225a4b40] - node-api: copy external type tags when they are set (Niels Martignène) #52426
  • [f9d95674be] - node-api: make tsfn accept napi_finalize once more (Gabriel Schulhof) #51801
  • [72aabe1139] - perf_hooks: reduce overhead of createHistogram (Vinícius Lourenço) #50074
  • [fb601c3a94] - readline: use internal addAbortListener (Chemi Atlow) #52081
  • [29f09f05f7] - (SEMVER-MINOR) report: add --report-exclude-network option (Ethan Arrowood) #51645
  • [7e6d923f5b] - src: cast to v8::Value before using v8::EmbedderGraph::V8Node (Joyee Cheung) #52638
  • [6af7b78b0d] - (SEMVER-MINOR) src: add string_view overload to snapshot FromBlob (Anna Henningsen) #52595
  • [27491e55c1] - src: remove regex usage for env file parsing (IlyasShabi) #52406
  • [b05e639e27] - src: fix loadEnvFile ENOENT error (mathis-west-1) #52438
  • [1b4d2814d1] - src: update branch name in node_revert.h (Tobias Nießen) #52390
  • [7e35a169ea] - src: stop using v8::BackingStore::Reallocate (Michaël Zasso) #52292
  • [2449d2606a] - src: fix move after use reported by coverity (Michael Dawson) #52141
  • [b33eff887d] - (SEMVER-MINOR) src: add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
  • [f2c7408927] - src: return a number from process.constrainedMemory() constantly (Chengzhong Wu) #52039
  • [7f575c886b] - (SEMVER-MINOR) src: add uv_get_available_memory to report and process (theanarkh) #52023
  • [e161e62313] - src: use dedicated routine to compile function for builtin CJS loader (Joyee Cheung) #52016
  • [07322b490f] - src: fix reading empty string views in Blob[De]serializer (Joyee Cheung) #52000
  • [e216192390] - src: refactor out FormatErrorMessage for error formatting (Joyee Cheung) #51999
  • [b3a11b574b] - (SEMVER-MINOR) src: preload function for Environment (Cheng Zhao) #51539
  • [09bd367ef6] - stream: make Duplex inherit destroy from Writable (Luigi Pinca) #52318
  • [0b853a7576] - (SEMVER-MINOR) stream: support typed arrays (IlyasShabi) #51866
  • [f8209ffe45] - stream: add new when constructing ERR_MULTIPLE_CALLBACK (haze) #52110
  • [8442457117] - stream: use internal addAbortListener (Chemi Atlow) #52081
  • [8d20b641a2] - Revert "stream: fix cloned webstreams not being unref'd" (Matteo Collina) #51491
  • [a923adffab] - test: mark test-error-serdes as flaky (Antoine du Hamel) #52739
  • [d4f1803f0b] - test: mark test as flaky (Michael Dawson) #52671
  • [1e88e042c2] - test: skip test-fs-watch-recursive-delete.js on IBM i (Abdirahim Musse) #52645
  • [6da558af8b] - test: ensure that all worker servers are ready (Luigi Pinca) #52563
  • [c871fadb85] - test: fix test-tls-ticket-cluster.js (Hüseyin Açacak) #52431
  • [b6cb74d775] - test: split wasi poll test for windows (Hüseyin Açacak) #52538
  • [4ad159bb75] - test: write tests for assertIsArray http2 util (Sinan Sonmez (Chaush)) #52511
  • [1f7a28cbe7] - test: fix watch test with require not testing pid (Raz Luvaton) #52353
  • [5b758b93d5] - test: simplify ASan build checks (Michaël Zasso) #52430
  • [375c3db5ea] - test: fix Windows compiler warnings in overlapped-checker (Michaël Zasso) #52405
  • [a1dd92cdee] - test: add test for skip+todo combinations (Colin Ihrig) #52204
  • [8a0b721930] - test: fix incorrect test fixture (Colin Ihrig) #52185
  • [dd1f761f3b] - test: add missing cctest/test_path.cc (Yagiz Nizipli) #52148
  • [6da446d9e1] - test: add spawnSyncAndAssert util (Antoine du Hamel) #52132
  • [d7bfb4e8d8] - test: reduce flakiness of test-runner-output.mjs (Colin Ihrig) #52146
  • [e4981b3d75] - test: add test for using --print with promises (Antoine du Hamel) #52137
  • [5cc540078e] - test: un-set test-emit-after-on-destroyed as flaky (Abdirahim Musse) #51995
  • [b9eb0035dd] - test: skip test for dynamically linked OpenSSL (Richard Lau) #52542
  • [32014f5601] - test: avoid v8 deadcode on performance function (Vinícius Lourenço) #50074
  • [29d2011f51] - test_runner: better error handing for test hook (Alex Yang) #52401
  • [9497097fb3] - test_runner: fix clearing final timeout in own callback (Ben Richeson) #52332
  • [0f690f0b9e] - test_runner: fix recursive run (Moshe Atlow) #52322
  • [34ab1a36ee] - test_runner: hide new line when no error in spec reporter (Moshe Atlow) #52297
  • [379535abe3] - test_runner: disable highWatermark on TestsStream (Colin Ihrig) #52287
  • [35588cff39] - test_runner: run afterEach hooks in correct order (Colin Ihrig) #52239
  • [5cd3df8fe1] - test_runner: simplify test end time tracking (Colin Ihrig) #52182
  • [07e4a42e4b] - test_runner: simplify test start time tracking (Colin Ihrig) #52182
  • [caec996831] - test_runner: emit diagnostics when watch mode drains (Moshe Atlow) #52130
  • [41646d9c9e] - (SEMVER-MINOR) test_runner: add suite() (Colin Ihrig) #52127
  • [fd1489a623] - test_runner: skip each hooks for skipped tests (Colin Ihrig) #52115
  • [73b38bfa9e] - test_runner: remove redundant report call (Colin Ihrig) #52089
  • [68187c4d9e] - test_runner: use internal addAbortListener (Chemi Atlow) #52081
  • [61e7ae05ef] - test_runner: use source maps when reporting coverage (Moshe Atlow) #52060
  • [e64a25af61] - test_runner: handle undefined test locations (Colin Ihrig) #52036
  • [590decf202] - test_runner: avoid overwriting root start time (Colin Ihrig) #52020
  • [a4cbb61c65] - test_runner: abort unfinished tests on async error (Colin Ihrig) #51996
  • [a223ca4868] - test_runner: run before hook immediately if test started (Moshe Atlow) #52003
  • [956ee74c7e] - test_runner: add support for null and date value output (Malthe Borch) #51920
  • [fc9ba17f6c] - (SEMVER-MINOR) test_runner: add test:complete event to reflect execution order (Moshe Atlow) #51909
  • [d5ac979aeb] - test_runner: format coverage report for tap reporter (Pulkit Gupta) #51119
  • [c925bc18dc] - tools: take co-authors into account in find-inactive-collaborators (Antoine du Hamel) #52669
  • [1d37e772ec] - tools: fix invalid escape sequence in mkssldef (Michaël Zasso) #52624
  • [5b22fc3a81] - tools: update lint-md-dependencies to rollup@4.15.0 (Node.js GitHub Bot) #52617
  • [9cf47bb2f1] - tools: update lint-md-dependencies (Rich Trott) #52581
  • [c0c60d13c0] - tools: fix heading spaces for osx-entitlements.plist (Jackson Tian) #52561
  • [7c349d7819] - tools: update lint-md-dependencies to rollup@4.14.2 vfile-reporter@8.1.1 (Node.js GitHub Bot) #52518
  • [b4d703297b] - tools: use stylistic ESLint plugin for formatting (Michaël Zasso) #50714
  • [c6813360c2] - tools: update minimatch index path (Marco Ippolito) #52523
  • [8464c0253c] - tools: add a linter for README lists (Antoine du Hamel) #52476
  • [55a3fbc842] - tools: change inactive limit to 12 months (Yagiz Nizipli) #52425
  • [74a171f130] - tools: update stale bot messaging (Wes Todd) #52423
  • [b2a3dcec2a] - tools: update lint-md-dependencies to rollup@4.14.0 (Node.js GitHub Bot) #52398
  • [f71a777e6e] - tools: update Ruff to v0.3.4 (Michaël Zasso) #52302
  • [e3e0c68f8f] - tools: run test-ubsan on ubuntu-latest (Michaël Zasso) #52375
  • [893b5aac31] - tools: update lint-md-dependencies to rollup@4.13.2 (Node.js GitHub Bot) #52286
  • [049cca419e] - Revert "tools: run build-windows workflow only on source changes" (Michaël Zasso) #52320
  • [b3dfc62cee] - tools: use Python 3.12 in GitHub Actions workflows (Michaël Zasso) #52301
  • [c7238d0c04] - tools: allow local updates for llhttp (Paolo Insogna) #52085
  • [c39f15cafd] - tools: install npm PowerShell scripts on Windows (Luke Karrys) #52009
  • [b36fea064a] - tools: update lint-md-dependencies to rollup@4.13.0 (Node.js GitHub Bot) #52122
  • [a5204eb915] - tools: fix error reported by coverity in js2c.cc (Michael Dawson) #52142
  • [cef4b7ef3d] - tools: sync ubsan workflow with asan (Michaël Zasso) #52152
  • [d406976bbe] - tools: update github_reporter to 1.7.0 (Node.js GitHub Bot) #52121
  • [fb100a2ac8] - tools: remove gyp-next .github folder (Marco Ippolito) #52064
  • [5f1e7a0de2] - tools: update gyp-next to 0.16.2 (Node.js GitHub Bot) #52062
  • [1f1253446b] - tools: install manpage to share/man for FreeBSD (Po-Chuan Hsieh) #51791
  • [4b8b92fccc] - tools: automate gyp-next update (Marco Ippolito) #52014
  • [1ec9e58692] - typings: fix invalid JSDoc declarations (Yagiz Nizipli) #52659
  • [2d6b19970b] - (SEMVER-MINOR) util: support array of formats in util.styleText (Marco Ippolito) #52040
  • [d30cccdf8c] - (SEMVER-MINOR) v8: implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
  • [7f3b7fdeff] - watch: fix some node argument not passed to watched process (Raz Luvaton) #52358
  • [8ba6f9bc9a] - watch: use internal addAbortListener (Chemi Atlow) #52081
  • [5a922232da] - watch: mark as stable (Moshe Atlow) #52074
  • [508e968a5f] - watch: batch file restarts (Moshe Atlow) #51992

H4ad and others added 30 commits April 10, 2024 13:17
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
As a temporary measure to unblock the CI, skip the RSA implicit
rejection test when Node.js is built against a dynamically linked
OpenSSL.

PR-URL: #52542
Refs: #52537
Refs: nodejs-private/node-private#525
Refs: https://hackerone.com/reports/2269177
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
#49703 cherry-picked a commit from
upstream V8 which references some maglev-related flags that are not
present in the version of V8 in Node.js 20.

PR-URL: #52256
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sync functions in fs throwed an error with a stacktrace which is helpful
for debugging. But functions in fs/promises throwed an error without
a stacktrace. This commit adds stacktraces by calling
Error.captureStacktrace and re-throwing the error.

Refs: #34817
PR-URL: #49849
Backport-PR-URL: #51127
Fixes: #50160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Commit 938212f added -msign-return-address=all to _all_ cflags but that
is wrong when cross-compiling, it should only be added to the target's
cflags.

The flag being deprecated, it is also changed to
`-mbranch-protection=standard`.

Fixes: #42888
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #51256
Fixes: nodejs/build#3319
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51278
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This reverts commit 4d3923a.

PR-URL: #51491
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #51462
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #51319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #51527
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #51630
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #51667
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #51909
Fixes: #51907
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
New option `--report-exclude-network`, also available as
`report.excludeNetwork`, enables the user to exclude
networking interfaces in their diagnostic report.
On some systems, this can cause the report to take minutes
to generate so this option can be used to optimize that.

Fixes: #46060

PR-URL: #51645

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #51920
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This is similar to the `queryObjects()` console API provided by the
Chromium DevTools console. It can be used to search for objects that
have the matching constructor on its prototype chain in the entire
heap, which can be useful for memory leak regression tests. To avoid
surprising results, users should avoid using this API on constructors
whose implementation they don't control, or on constructors that can
be invoked by other parties in the application.

To avoid accidental leaks, this API does not return raw references to
the objects found. By default, it returns the count of the objects
found. If `options.format` is `'summary'`, it returns an array
containing brief string representations for each object. The visibility
provided in this API is similar to what the heap snapshot provides,
while users can save the cost of serialization and parsing and directly
filer the target objects during the search.

We have been using this API internally for the test suite, which
has been more stable than any other leak regression testing
strategies in the CI. With a public implementation we can now
use the public API instead.

PR-URL: #51927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This PR adds a |preload| arg to the node::LoadEnvironment to allow
embedders to set a preload function for the environment, which will run
after the environment is loaded and before the main script runs.

This is similiar to the --require CLI option, but runs a C++ function,
and can only be set by embedders.

The preload function can be used by embedders to inject scripts before
running the main script, for example:
1. In Electron it is used to initialize the ASAR virtual filesystem,
   inject custom process properties, etc.
2. In VS Code it can be used to reset the module search paths for
   extensions.

PR-URL: #51539
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51879
Refs: #51681
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #51881
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #51915
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #51991
Fixes: #51885
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #51990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This is required since version 4 of the action (except for pull
 requests opened from forks).

Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release
PR-URL: #51982
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
I tested running the test case 100k times on the AIX ci machine
and was unable to re-produce the error. Also it has not showed up
recently as flaky on the ci. I suggest we mark this
as un-flaky.

ref: #50245 (comment)
PR-URL: #51995
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The thread-safe function's finalizer is not called in conjunction with
the garbage collection of a JS value. In fact, it keeps a strong
reference to the JS function it is expected to call. Thus, it is safe
to make calls that affect GC state from its body.

PR-URL: #51801
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #52003
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #52004
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
- As far as I can tell, the documentation didn't say this, so I was left
  wondering if there is a difference between `c1` and `c2` in `const c2
= vm.createContext(c1);` According to my own tests, they are equivalent.
I thought it was worth documenting as it would've saved me a bit of time
if this information were written down.

PR-URL: #51960
Refs: #51946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 4, 2024

CITGM looks good I'm marking it as green, V8-ci is not needed since in this release we are not patching or updating v8

@richardlau
Copy link
Member

since in this release we are not patching or updating v8

  • [ecadd638cd] - deps: V8: remove references to non-existent flags (Richard Lau) #52256

🙂

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito
Copy link
Member Author

V8 CI looks good apart from the fail I've seen in previous releases

20:57:44         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf.js:108:8)
20:57:44         at Module._compile (node:internal/modules/cjs/loader:1358:14)
20:57:44         at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
20:57:44         at Module.load (node:internal/modules/cjs/loader:1208:32)
20:57:44         at Module._load (node:internal/modules/cjs/loader:1024:12)
20:57:44         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
20:57:44         at node:internal/main/run_main_module:28:49 {
20:57:44       generatedMessage: false,
20:57:44       code: 'ERR_ASSERTION',
20:57:44       actual: null,
20:57:44       expected: true,
20:57:44       operator: '=='

@panva
Copy link
Member

panva commented May 6, 2024

crypto: deprecate implicitly shortened GCM tags

This release, introduces a doc-only deprecation of using GCM authentication tags that are shorter than the cipher's block size, unless the user specified the authTagLength option.

Contribute by Tobias Nießen in #52345

Typo in Contribute by Tobias Nießen -> Contributed by Tobias Nießen

@marco-ippolito

This comment was marked as outdated.

@targos
Copy link
Member

targos commented May 7, 2024

@marco-ippolito The typo noted by @panva hasn't been fixed.

@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 7, 2024

@marco-ippolito The typo noted by @panva hasn't been fixed.

Is it ok to amend it now without re running the whole CI?

Notable changes:

benchmark:
  * add AbortSignal.abort benchmarks (Raz Luvaton) #52408
buffer:
  * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428
crypto:
  * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
deps:
  * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138
  * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462
  * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278
dns:
  * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492
doc:
  * update release gpg keyserver (marco-ippolito) #52257
  * add release key for marco-ippolito (marco-ippolito) #52257
  * add UlisesGascon as a collaborator (Ulises Gascón) #51991
  * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879
events,doc:
  * mark CustomEvent as stable (Daeyeon Jeong) #52618
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib, url:
  * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509
net:
  * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
report:
  * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645
src:
  * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595
  * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
  * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023
  * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539
stream:
  * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866
test_runner:
  * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127
  * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909
util:
  * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040
v8:
  * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
watch:
  * mark as stable (Moshe Atlow) #52074

PR-URL: #52793
@targos
Copy link
Member

targos commented May 7, 2024

It's ok but you still have to cancel and start a new release CI with the new commit sha

@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 7, 2024

It's ok but you still have to cancel and start a new release CI with the new commit sha

I've started a new release with the updated commit sha https://ci-release.nodejs.org/job/iojs+release/10186/ 🟩

@marco-ippolito marco-ippolito merged commit 0d0efa4 into v20.x May 7, 2024
23 checks passed
@marco-ippolito marco-ippolito deleted the v20.13.0-proposal branch May 7, 2024 15:10
marco-ippolito added a commit that referenced this pull request May 7, 2024
marco-ippolito added a commit that referenced this pull request May 7, 2024
Notable changes:

benchmark:
  * add AbortSignal.abort benchmarks (Raz Luvaton) #52408
buffer:
  * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428
crypto:
  * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
deps:
  * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138
  * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462
  * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278
dns:
  * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492
doc:
  * update release gpg keyserver (marco-ippolito) #52257
  * add release key for marco-ippolito (marco-ippolito) #52257
  * add UlisesGascon as a collaborator (Ulises Gascón) #51991
  * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879
events,doc:
  * mark CustomEvent as stable (Daeyeon Jeong) #52618
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib, url:
  * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509
net:
  * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
report:
  * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645
src:
  * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595
  * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
  * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023
  * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539
stream:
  * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866
test_runner:
  * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127
  * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909
util:
  * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040
v8:
  * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
watch:
  * mark as stable (Moshe Atlow) #52074

PR-URL: #52793
marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request May 7, 2024
marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request May 7, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 7, 2024
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
Notable changes:

benchmark:
  * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408
buffer:
  * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428
crypto:
  * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345
deps:
  * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138
  * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462
  * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278
dns:
  * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492
doc:
  * update release gpg keyserver (marco-ippolito) nodejs#52257
  * add release key for marco-ippolito (marco-ippolito) nodejs#52257
  * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991
  * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879
events,doc:
  * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618
fs:
  * add stacktrace to fs/promises (翠 / green) nodejs#49849
lib, url:
  * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509
net:
  * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474
report:
  * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645
src:
  * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595
  * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977
  * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023
  * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539
stream:
  * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866
test_runner:
  * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127
  * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909
util:
  * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040
v8:
  * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927
watch:
  * mark as stable (Moshe Atlow) nodejs#52074

PR-URL: nodejs#52793
@otaviomacedo
Copy link

otaviomacedo commented May 8, 2024

@marco-ippolito when I install version 20.13.0 on Windows, I get the error:

Error: Cannot find module 'C:\<Path>\npm\node_modules\npm\bin\npm-cli.js'

@marco-ippolito
Copy link
Member Author

@marco-ippolito when I install version 20.13.0 on Windows, I get the error:

Error: Cannot find module 'C:\<Path>\npm\node_modules\npm\bin\npm-cli.js'

There is already an issue open
#52884

sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
Notable changes:

benchmark:
  * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408
buffer:
  * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428
crypto:
  * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345
deps:
  * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138
  * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462
  * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278
dns:
  * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492
doc:
  * update release gpg keyserver (marco-ippolito) nodejs#52257
  * add release key for marco-ippolito (marco-ippolito) nodejs#52257
  * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991
  * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879
events,doc:
  * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618
fs:
  * add stacktrace to fs/promises (翠 / green) nodejs#49849
lib, url:
  * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509
net:
  * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474
report:
  * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645
src:
  * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595
  * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977
  * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023
  * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539
stream:
  * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866
test_runner:
  * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127
  * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909
util:
  * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040
v8:
  * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927
watch:
  * mark as stable (Moshe Atlow) nodejs#52074

PR-URL: nodejs#52793
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Notable changes:

benchmark:
  * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408
buffer:
  * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428
crypto:
  * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345
deps:
  * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138
  * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462
  * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278
dns:
  * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492
doc:
  * update release gpg keyserver (marco-ippolito) nodejs#52257
  * add release key for marco-ippolito (marco-ippolito) nodejs#52257
  * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991
  * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879
events,doc:
  * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618
fs:
  * add stacktrace to fs/promises (翠 / green) nodejs#49849
lib, url:
  * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509
net:
  * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474
report:
  * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645
src:
  * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595
  * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977
  * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023
  * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539
stream:
  * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866
test_runner:
  * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127
  * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909
util:
  * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040
v8:
  * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927
watch:
  * mark as stable (Moshe Atlow) nodejs#52074

PR-URL: nodejs#52793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.