-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: optimize child process doc #52154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand the "optimize" part of the commit message. In what sense does this change optimize the docs?
I'm trying to improve the documentation and point out that we can't send IPC handles on win32 platform 😄. |
5c40dd6
to
8f3b8a4
Compare
Then maybe |
8f3b8a4
to
3f9b2e5
Compare
1. Clarify that which types of objects can be sent through process.send 2. Clarify that IPC handle are not supported on win32 platform
3f9b2e5
to
0bb700e
Compare
Landed in 312ebd9 |
- Clarify which types of objects can be sent through `process.send`. - Clarify that IPC handles are not supported on win32 platform. PR-URL: nodejs#52154 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
- Clarify which types of objects can be sent through `process.send`. - Clarify that IPC handles are not supported on win32 platform. PR-URL: #52154 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
- Clarify which types of objects can be sent through `process.send`. - Clarify that IPC handles are not supported on win32 platform. PR-URL: #52154 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
cc @bnoordhuis
make -j4 test
(UNIX), orvcbuild test
(Windows) passes