test: fix watch test with require not testing pid #52353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
MoLow
approved these changes
Apr 3, 2024
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Apr 4, 2024
aduh95
reviewed
Apr 4, 2024
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Apr 7, 2024
MoLow
added
the
author ready
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52353 ✔ Done loading data for nodejs/node/pull/52353 ----------------------------------- PR info ------------------------------------ Title test: fix watch test with require not testing pid (#52353) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:fix-watch-test -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: fix watch test with require not testing pid - watch: code review changes Committers 1 - Raz Luvaton <16746759+rluvaton@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52353 Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52353 Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 03 Apr 2024 16:25:35 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52353#pullrequestreview-1977470529 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/52353#pullrequestreview-1984873056 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-11T09:19:17Z: https://ci.nodejs.org/job/node-test-pull-request/58266/ - Querying data for job/node-test-pull-request/58266/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52353 From https://github.com/nodejs/node * branch refs/pull/52353/merge -> FETCH_HEAD ✔ Fetched commits as 3f8cc88009ef..87074ea57c32 -------------------------------------------------------------------------------- Auto-merging test/sequential/test-watch-mode.mjs [main 3cf6e9c119] test: fix watch test with require not testing pid Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed Apr 3 17:23:55 2024 +0100 1 file changed, 7 insertions(+), 4 deletions(-) Auto-merging test/sequential/test-watch-mode.mjs [main 66d6cd1175] watch: code review changes Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sat Apr 6 21:54:56 2024 +0300 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/8645152431 |
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ee4fa77 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52353 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52353 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process._rawDebugoutput to stderr and not stdout