Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-error-serdes as flaky #52739

Merged
merged 1 commit into from
Apr 28, 2024
Merged

test: make test-error-serdes as flaky #52739

merged 1 commit into from
Apr 28, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 28, 2024

IIUC #52674 is not yet ready to land, so let's mark the test as flaky in the mean time.

Refs: #52630

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58785/

@aduh95 aduh95 changed the title testL make test-error-serdes as flaky test: make test-error-serdes as flaky Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58786/

@aduh95 aduh95 merged commit 7c3dce0 into nodejs:main Apr 28, 2024
48 of 51 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 28, 2024

Landed in 7c3dce0

@aduh95 aduh95 deleted the test-error-serdes-flaky branch April 28, 2024 23:10
aduh95 added a commit that referenced this pull request Apr 29, 2024
@aduh95
test: mark test-error-serdes as flaky
d568a9a 
PR-URL: #52739
Refs: #52630
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@aduh95 @marco-ippolito
test: mark test-error-serdes as flaky
da290a5 
PR-URL: #52739
Refs: #52630
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@aduh95 @marco-ippolito
test: mark test-error-serdes as flaky
a923adf 
PR-URL: #52739
Refs: #52630
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@aduh95 @eliphazbouye
test: mark test-error-serdes as flaky
227f0f6 
PR-URL: nodejs#52739
Refs: nodejs#52630
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@aduh95 @bmeck
test: mark test-error-serdes as flaky
5f4711f 
PR-URL: nodejs#52739
Refs: nodejs#52630
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @targos @richardlau