Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: pass Codecov upload token to codecov action #51982

Merged
merged 1 commit into from
Mar 8, 2024
Merged

meta: pass Codecov upload token to codecov action #51982

merged 1 commit into from
Mar 8, 2024

Conversation

targos
Copy link
Member

@targos targos commented Mar 6, 2024

This is required since version 4 of the action (except for pull requests opened from forks).

Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 6, 2024
@targos
Copy link
Member Author

targos commented Mar 6, 2024 •
edited
Loading

I pushed the branch to the upstream to verify it works.

Here are examples of previous upload failures:

@targos
Copy link
Member Author

targos commented Mar 6, 2024

FYI @nodejs/tsc: I created a global upload token for the nodejs org on https://app.codecov.io/account/gh/nodejs/org-upload-token and set it as an org secret on https://github.com/organizations/nodejs/settings/secrets/actions. You can allow other repositories to access the secret by editing it.

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2024
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 60dcfad into main Mar 8, 2024
20 checks passed
@nodejs-github-bot nodejs-github-bot deleted the codecov-token branch March 8, 2024 20:21
@nodejs-github-bot
Copy link
Collaborator

Landed in 60dcfad

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@targos @rdw-msft
meta: pass Codecov upload token to codecov action
59b578d 
This is required since version 4 of the action (except for pull
 requests opened from forks).

Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release
PR-URL: nodejs#51982
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@targos @marco-ippolito
meta: pass Codecov upload token to codecov action
3121949 
This is required since version 4 of the action (except for pull
 requests opened from forks).

Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release
PR-URL: #51982
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
@targos @jcbhmr
meta: pass Codecov upload token to codecov action
0649829 
This is required since version 4 of the action (except for pull
 requests opened from forks).

Refs: https://github.com/codecov/codecov-action/blob/e7748388508dfb57a188b1593a92c9ca8d865365/README.md#v4-release
PR-URL: nodejs#51982
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.