Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update test runner coverage limitations #52515

Merged

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Apr 13, 2024

@MoLow MoLow requested a review from cjihrig April 13, 2024 21:29
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Apr 13, 2024
@MoLow MoLow force-pushed the test-runner-update-coverage-limitations branch from 6d0bf7b to f73e249 Compare April 13, 2024 21:30
doc/api/test.md Show resolved Hide resolved
doc/api/test.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I kind of agree with @atlowChemi. Either way works for me though.

@MoLow MoLow force-pushed the test-runner-update-coverage-limitations branch from f73e249 to 7b0a45d Compare April 15, 2024 05:29
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7453480 into nodejs:main Apr 15, 2024
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7453480

aduh95 pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #52515
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52515
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52515
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MoLow MoLow deleted the test-runner-update-coverage-limitations branch May 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants