-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: allow local updates for llhttp #52085
tools: allow local updates for llhttp #52085
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit Queue failed- Loading data for nodejs/node/pull/52085 ✔ Done loading data for nodejs/node/pull/52085 ----------------------------------- PR info ------------------------------------ Title tools: allow local updates for llhttp (#52085) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:local-llhttp-update -> nodejs:main Labels tools Commits 2 - tools: allow local updates for llhttp - tools: linted code Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/52085 Reviewed-By: Michael Dawson Reviewed-By: Rafael Gonzaga Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52085 Reviewed-By: Michael Dawson Reviewed-By: Rafael Gonzaga Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 14 Mar 2024 15:50:21 GMT ✔ Approvals: 3 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/52085#pullrequestreview-1943813612 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/52085#pullrequestreview-1945936095 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52085#pullrequestreview-1969860145 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52085 From https://github.com/nodejs/node * branch refs/pull/52085/merge -> FETCH_HEAD ✔ Fetched commits as 7c02486f1f91..c08c98b4692d -------------------------------------------------------------------------------- [main 6dcecc3b9a] tools: allow local updates for llhttp Author: Paolo Insogna Date: Thu Mar 14 16:48:20 2024 +0100 1 file changed, 29 insertions(+), 12 deletions(-) [main a4cc53b0e6] tools: linted code Author: Paolo Insogna Date: Fri Mar 15 08:18:57 2024 +0100 2 files changed, 6 insertions(+), 5 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/8489560058 |
Landed in 021cf91 |
PR-URL: #52085 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #52085 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This PR allows to specify a local folder to update llhttp.
This is especially beneficial in security releases.