Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing space #52360

Merged
merged 1 commit into from
Apr 4, 2024
Merged

doc: add missing space #52360

merged 1 commit into from
Apr 4, 2024

Conversation

AugustinMauroy
Copy link
Member

Fixing small typo.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2024
@UlisesGascon
Copy link
Member

@AugustinMauroy can you update the commit message?

Error: not ok 6 title-format: First word after subsystem(s) in title should be lowercase. (doc: Update api-documentation.md). ref

@AugustinMauroy
Copy link
Member Author

@AugustinMauroy can you update the commit message?

I'm sorry, I had read this file but I didn't understand what should I put in this case.

@tniessen
Copy link
Member

tniessen commented Apr 4, 2024

I'd suggest changing the commit message (and PR title) to doc: add missing space or so. You'll need to force-push to rewrite the commit message.

@AugustinMauroy AugustinMauroy changed the title doc: typo add missing space doc/contributing/api-documentation.md doc: add missing space Apr 4, 2024
@AugustinMauroy
Copy link
Member Author

thanks @tniessen

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit a63261c into nodejs:main Apr 4, 2024
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a63261c

@AugustinMauroy AugustinMauroy deleted the fix-typo branch April 5, 2024 06:52
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@AugustinMauroy @marco-ippolito
doc: add missing space
0ed7f6c 
PR-URL: #52360
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@AugustinMauroy @marco-ippolito
doc: add missing space
1a843f7 
PR-URL: #52360
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AugustinMauroy @nodejs-github-bot @UlisesGascon @tniessen @aduh95