-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: optimize the doc about Unix abstract socket #52043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
net
Issues and PRs related to the net subsystem.
labels
Mar 11, 2024
4 tasks
ShogunPanda
reviewed
Mar 11, 2024
ShogunPanda
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little nit but rest LGTM.
theanarkh
force-pushed
the
optimize_net_doc
branch
from
March 11, 2024 13:57
182badb
to
3093ef8
Compare
lpinca
approved these changes
Mar 11, 2024
theanarkh
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Mar 12, 2024
Fast-track has been requested by @theanarkh. Please 👍 to approve. |
legendecas
requested changes
Mar 13, 2024
theanarkh
removed
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Mar 13, 2024
theanarkh
force-pushed
the
optimize_net_doc
branch
from
March 18, 2024 16:41
3093ef8
to
8e8bbe4
Compare
legendecas
approved these changes
Mar 18, 2024
theanarkh
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 19, 2024
mcollina
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mcollina
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 19, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 19, 2024
Landed in 7071554 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52043 Refs: nodejs#50904 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
net
Issues and PRs related to the net subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize the doc about Unix abstract socket
Refs: #50904
make -j4 test
(UNIX), orvcbuild test
(Windows) passes