test_runner: support source mapped test locations #52010

cjihrig · 2024-03-08T03:13:05Z

test_runner: support source mapped test locations

This commit adds support for source mapping test locations
when the --enable-source-maps flag is present.

test_runner: use paths for test locations

This commit transforms test locations to paths when V8 provides
file URLs (which seems to be for ESM files).

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: nodejs#51392

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: nodejs#51610

nodejs-github-bot · 2024-03-08T03:13:10Z

Review requested:

@nodejs/test_runner

benjamingr

welcome back!

rluvaton · 2024-03-08T14:11:14Z

Can you add a test for inline source map as well?

legendecas · 2024-03-08T14:35:08Z

Can you add a test for inline source map as well?

I think the existing source map implementation and tests could cover this sufficiently.

theoludwig

Thanks, that will be useful, for TypeScript users, that build their files to JavaScript to then execute the Node.js built-in test runner.

Does this support the --experimental-test-coverage? So that the reported uncovered lines, are the ones from the source TypeScript file?

theoludwig · 2024-03-09T14:11:01Z

lib/internal/test_runner/test.js

@@ -359,6 +370,21 @@ class Test extends AsyncResource {
        column: loc[1],
        file: loc[2],
      };
+
+      if (sourceMaps === true) {


Why checking === true and not using directly sourceMaps?

if (sourceMaps) {

nodejs-github-bot · 2024-03-09T18:15:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57641/

nodejs-github-bot · 2024-03-09T21:37:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57646/

nodejs-github-bot · 2024-03-09T22:24:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57648/

cjihrig · 2024-03-09T23:35:19Z

Does this support the --experimental-test-coverage?

@theoludwig no, not yet. That is a separate change.

nodejs-github-bot · 2024-03-10T10:54:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57655/

nodejs-github-bot · 2024-03-10T15:12:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57660/

nodejs-github-bot · 2024-03-10T18:07:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57662/

nodejs-github-bot · 2024-03-11T08:35:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57673/

nodejs-github-bot · 2024-03-11T08:56:18Z

Landed in 592c690...328642b

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: #51392 PR-URL: #52010 Fixes: #51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: #51610 PR-URL: #52010 Fixes: #51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: nodejs#51392 PR-URL: nodejs#52010 Fixes: nodejs#51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: nodejs#51610 PR-URL: nodejs#52010 Fixes: nodejs#51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: #51392 PR-URL: #52010 Fixes: #51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

marco-ippolito · 2024-05-03T06:52:53Z

Can you create a backport for v20, its not landing clean

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: nodejs#51392 PR-URL: nodejs#52010 Fixes: nodejs#51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: nodejs#51610 PR-URL: nodejs#52010 Fixes: nodejs#51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: nodejs#51392 PR-URL: nodejs#52010 Fixes: nodejs#51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: nodejs#51610 PR-URL: nodejs#52010 Fixes: nodejs#51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: #51392 PR-URL: #52010 Backport-PR-URL: #52872 Fixes: #51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: #51610 PR-URL: #52010 Backport-PR-URL: #52872 Fixes: #51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

cjihrig added 2 commits March 7, 2024 21:19

test_runner: support source mapped test locations

3e39c37

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: nodejs#51392

test_runner: use paths for test locations

0f4d2e0

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: nodejs#51610

cjihrig requested review from MoLow and atlowChemi March 8, 2024 03:13

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 8, 2024

benjamingr approved these changes Mar 8, 2024

View reviewed changes

marco-ippolito approved these changes Mar 8, 2024

View reviewed changes

legendecas approved these changes Mar 8, 2024

View reviewed changes

theoludwig reviewed Mar 9, 2024

View reviewed changes

atlowChemi approved these changes Mar 9, 2024

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2024

MoLow approved these changes Mar 9, 2024

View reviewed changes

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Mar 11, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 11, 2024

nodejs-github-bot closed this Mar 11, 2024

cjihrig deleted the test-location branch March 11, 2024 13:21

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

gjuchault mentioned this pull request Apr 24, 2024

Can't use with --experimental-test-coverage --test privatenumber/tsx#437

Closed

6 tasks

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label May 3, 2024

MoLow mentioned this pull request May 7, 2024

[v20.x backport] test_runner: support source mapped test locations #52872

Closed

marco-ippolito added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels May 17, 2024

marco-ippolito mentioned this pull request May 23, 2024

v20.14.0 proposal #53120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_runner: support source mapped test locations #52010

test_runner: support source mapped test locations #52010

cjihrig commented Mar 8, 2024

nodejs-github-bot commented Mar 8, 2024

benjamingr left a comment

rluvaton commented Mar 8, 2024

legendecas commented Mar 8, 2024

theoludwig left a comment •

edited

Loading

theoludwig Mar 9, 2024

nodejs-github-bot commented Mar 9, 2024

nodejs-github-bot commented Mar 9, 2024

nodejs-github-bot commented Mar 9, 2024

cjihrig commented Mar 9, 2024

nodejs-github-bot commented Mar 10, 2024

nodejs-github-bot commented Mar 10, 2024

nodejs-github-bot commented Mar 10, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

marco-ippolito commented May 3, 2024

test_runner: support source mapped test locations #52010

test_runner: support source mapped test locations #52010

Conversation

cjihrig commented Mar 8, 2024

test_runner: support source mapped test locations

test_runner: use paths for test locations

nodejs-github-bot commented Mar 8, 2024

benjamingr left a comment

Choose a reason for hiding this comment

rluvaton commented Mar 8, 2024

legendecas commented Mar 8, 2024

theoludwig left a comment • edited Loading

Choose a reason for hiding this comment

theoludwig Mar 9, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 9, 2024

nodejs-github-bot commented Mar 9, 2024

nodejs-github-bot commented Mar 9, 2024

cjihrig commented Mar 9, 2024

nodejs-github-bot commented Mar 10, 2024

nodejs-github-bot commented Mar 10, 2024

nodejs-github-bot commented Mar 10, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

marco-ippolito commented May 3, 2024

theoludwig left a comment •

edited

Loading