util: improve isInsideNodeModules #52147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Mar 18, 2024
anonrig
reviewed
Mar 19, 2024
Uzlopak
force-pushed
the
util-isInsideNodeModules
branch
2 times, most recently
from
d08b72a
to
0778337
Compare
Just curious, did you do that for performance reasons, or is that a neutral change to make the regex more intention-revealing? |
aduh95
approved these changes
Mar 20, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
|
I just saw that the capturing group is not used and the captured string can be very long. So i had performance in mind, but i didnt wanted to claim a (significant?) performance gain, which i probably cant prove. |
|
Looks like this a breaking the following tests:
|
|
I will have a look at it in few hours ;) |
Uzlopak
force-pushed
the
util-isInsideNodeModules
branch
from
0778337
to
c714cda
Compare
|
Should be fixed now. |
BridgeAR
approved these changes
Mar 21, 2024
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 21, 2024
|
@nodejs/node-core-utils can this be merged? |
anonrig
reviewed
Apr 15, 2024
| if (RegExpPrototypeExec(/^\/|\\/, filename) === null) | ||
| if ( | ||
| filename[0] !== '/' && | ||
| StringPrototypeIncludes(filename, '\\') === false |
There was a problem hiding this comment.
This only applies to Windows right?
There was a problem hiding this comment.
this PR is already old but afaik it was effecting linux too
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52147 ✔ Done loading data for nodejs/node/pull/52147 ----------------------------------- PR info ------------------------------------ Title util: improve isInsideNodeModules (#52147) Author Aras Abbasi (@Uzlopak) Branch Uzlopak:util-isInsideNodeModules -> nodejs:main Labels util, author ready, needs-ci Commits 1 - util: improve isInsideNodeModules Committers 1 - uzlopak PR-URL: https://github.com/nodejs/node/pull/52147 Reviewed-By: Antoine du Hamel Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52147 Reviewed-By: Antoine du Hamel Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 18 Mar 2024 20:58:36 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/52147#pullrequestreview-1950310069 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/52147#pullrequestreview-1951180547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52147#pullrequestreview-1953430893 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-05-05T08:45:43Z: https://ci.nodejs.org/job/node-test-pull-request/58945/ - Querying data for job/node-test-pull-request/58945/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8957320660 |
PR-URL: nodejs#52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
force-pushed
the
util-isInsideNodeModules
branch
from
f02a1ba
to
b77f32b
Compare
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
PR-URL: nodejs#52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 8, 2024
PR-URL: #52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
added
the
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve isInsideNodeModules by avoiding a Regex
kNodeModulesRE is using a non-capturing group