v20.15.0 proposal #53486

marco-ippolito · 2024-06-17T12:20:21Z

2024-06-20, Version 20.15.0 'Iron' (LTS), @marco-ippolito

test_runner: support test plans

It is now possible to count the number of assertions and subtests that are expected to run within a test. If the number of assertions and subtests that run does not match the expected count, the test will fail.

test('top level test', (t) => {
  t.plan(2);
  t.assert.ok('some relevant assertion here');
  t.subtest('subtest', () => {});
});

Contributed by Colin Ihrig in #52860

inspector: introduce the `--inspect-wait` flag

This release introduces the --inspect-wait flag, which allows debugger to wait for attachement. This flag is useful when you want to debug the code from the beginning. Unlike --inspect-brk, which breaks on the first line, this flag waits for debugger to be connected and then runs the code as soon as a session is established.

Contributed by Kohei Ueno in #52734

zlib: expose zlib.crc32()

This release exposes the crc32() function from zlib to user-land.

It computes a 32-bit Cyclic Redundancy Check checksum of data. If
value is specified, it is used as the starting value of the checksum,
otherwise, 0 is used as the starting value.

The CRC algorithm is designed to compute checksums and to detect error
in data transmission. It's not suitable for cryptographic authentication.

const zlib = require('node:zlib');
const { Buffer } = require('node:buffer');

let crc = zlib.crc32('hello');  // 907060870
crc = zlib.crc32('world', crc);  // 4192936109

crc = zlib.crc32(Buffer.from('hello', 'utf16le'));  // 1427272415
crc = zlib.crc32(Buffer.from('world', 'utf16le'), crc);  // 4150509955

Contributed by Joyee Cheung in #52692

cli: allow running wasm in limited vmem with --disable-wasm-trap-handler

By default, Node.js enables trap-handler-based WebAssembly bound
checks. As a result, V8 does not need to insert inline bound checks
int the code compiled from WebAssembly which may speedup WebAssembly
execution significantly, but this optimization requires allocating
a big virtual memory cage (currently 10GB). If the Node.js process
does not have access to a large enough virtual memory address space
due to system configurations or hardware limitations, users won't
be able to run any WebAssembly that involves allocation in this
virtual memory cage and will see an out-of-memory error.

$ ulimit -v 5000000
$ node -p "new WebAssembly.Memory({ initial: 10, maximum: 100 });"
[eval]:1
new WebAssembly.Memory({ initial: 10, maximum: 100 });
^

RangeError: WebAssembly.Memory(): could not allocate memory
    at [eval]:1:1
    at runScriptInThisContext (node:internal/vm:209:10)
    at node:internal/process/execution:118:14
    at [eval]-wrapper:6:24
    at runScript (node:internal/process/execution:101:62)
    at evalScript (node:internal/process/execution:136:3)
    at node:internal/main/eval_string:49:3

--disable-wasm-trap-handler disables this optimization so that
users can at least run WebAssembly (with a less optimial performance)
when the virtual memory address space available to their Node.js
process is lower than what the V8 WebAssembly memory cage needs.

Contributed by Joyee Cheung in #52766

Other Notable Changes

[12512c3d0e] - doc: add pimterry to collaborators (Tim Perry) #52874
[9d485b40bb] - (SEMVER-MINOR) tools: fix get_asan_state() in tools/test.py (Joyee Cheung) #52766
[e98c305f52] - (SEMVER-MINOR) tools: support max_virtual_memory test configuration (Joyee Cheung) #52766
[dce0300896] - (SEMVER-MINOR) tools: support != in test status files (Joyee Cheung) #52766

Commits

[227093bfec] - assert: add deep equal check for more Error type (Zhenwei Jin) #51805
[184cfe5a71] - benchmark: filter non-present deps from start-cli-version (Adam Majer) #51746
[8b3e83bb53] - buffer: even faster atob (Daniel Lemire) #52443
[8d628c3255] - buffer: use size_t instead of uint32_t to avoid segmentation fault (Xavier Stouder) #48033
[16ae2b2933] - buffer: remove lines setting indexes to integer value (Zhenwei Jin) #52588
[48c15d0dcd] - build: remove deprecated calls for argument groups (Mohammed Keyvanzadeh) #52913
[1be8232d17] - build: drop base64 dep in GN build (Cheng) #52856
[918962d6e7] - build: make simdjson a public dep in GN build (Cheng) #52755
[5215b6fd8e] - build, tools: copy release assets to staging R2 bucket once built (flakey5) #51394
[473fa73857] - (SEMVER-MINOR) cli: allow running wasm in limited vmem with --disable-wasm-trap-handler (Joyee Cheung) #52766
[954d2aded4] - cluster: replace forEach with for-of loop (Jérôme Benoit) #50317
[794e450ea7] - console: colorize console error and warn (Jithil P Ponnan) #51629
[0fb7c18f10] - crypto: fix duplicated switch-case return values (Mustafa Ateş UZUN) #49030
[cd1415c8b2] - Revert "crypto: make timingSafeEqual faster for Uint8Array" (Tobias Nießen) #53390
[b774544bb1] - deps: enable unbundling of simdjson, simdutf, ada (Daniel Lemire) #52924
[da4dbfc5fd] - doc: remove reference to AUTHORS file (Marco Ippolito) #52960
[2f3f2ff8af] - doc: update hljs with the latest styles (Aviv Keller) #52911
[3a1d17a9b1] - doc: mention quicker way to build docs (Alex Crawford) #52937
[be309bd19d] - doc: mention push.followTags config (Rafael Gonzaga) #52906
[e62c6e2684] - doc: document pipeline with end option (Alois Klink) #48970
[af27225cf6] - doc: add example for execFileSync method and ref to stdio (Evan Shortiss) #39412
[086626f9b1] - doc: add examples and notes to http server.close et al (mary marchini) #49091
[3aa3337a00] - doc: fix dns.lookup family 0 and all descriptions (Adam Jones) #51653
[585f2a2e7f] - doc: update fs.realpath documentation (sinkhaha) #48170
[4bf3d44e1d] - doc: update fs read documentation for clarity (Mert Can Altin) #52453
[ae5d47dde3] - doc: watermark string behavior (Benjamin Gruenbaum) #52842
[1e429d10d3] - doc: exclude commits with baking-for-lts (Marco Ippolito) #52896
[3df3e37cdb] - doc: add names next to release key bash commands (Aviv Keller) #52878
[12512c3d0e] - doc: add pimterry to collaborators (Tim Perry) #52874
[97e0fef019] - doc: add more definitions to GLOSSARY.md (Aviv Keller) #52798
[91fadac162] - doc: make docs more welcoming and descriptive for newcomers (Serkan Özel) #38056
[a3b20126fd] - doc: add OpenSSL errors to API docs (John Lamp) #34213
[9587ae9b5b] - doc: simplify copy-pasting of branch-diff commands (Antoine du Hamel) #52757
[6ea72a53c3] - doc: add test_runner to subsystem (Raz Luvaton) #52774
[972eafd983] - events: update MaxListenersExceededWarning message log (sinkhaha) #51921
[74753ed1fe] - events: add stop propagation flag to Event.stopImmediatePropagation (Mickael Meausoone) #39463
[75dd009649] - events: replace NodeCustomEvent with CustomEvent (Feng Yu) #43876
[7d38c2e012] - fs: keep fs.promises.readFile read until EOF is reached (Zhenwei Jin) #52178
[8cb13120d3] - (SEMVER-MINOR) inspector: introduce the --inspect-wait flag (Kohei Ueno) #52734
[d5ab1de1fd] - meta: move @anonrig to TSC regular member (Yagiz Nizipli) #52932
[f82d086e90] - path: fix toNamespacedPath on Windows (Hüseyin Açacak) #52915
[121ea13b50] - process: improve event-loop (Aras Abbasi) #52108
[eceac784aa] - repl: fix disruptive autocomplete without inspector (Nitzan Uziely) #40661
[89a910be82] - src: fix Worker termination in inspector.waitForDebugger (Daeyeon Jeong) #52527
[033f985e8a] - src: use S_ISDIR to check if the file is a directory (theanarkh) #52164
[95128399f8] - src: allow preventing debug signal handler start (Shelley Vohr) #46681
[b162aeae9e] - src: fix typo Unabled -> Unable (Simon Siefke) #52820
[2dcbf1894a] - src: avoid unused variable 'error' warning (Michaël Zasso) #52886
[978ee0a635] - src: only apply fix in main thread (Paolo Insogna) #52702
[8fc52b38c6] - src: fix test local edge case (Paolo Insogna) #52702
[d02907ecc4] - src: remove misplaced windows code under posix guard in node.cc (Ali Hassan) #52545
[af29120fa7] - stream: use ByteLengthQueuingStrategy when not in objectMode (Jason) #48847
[a5f3dd137c] - string_decoder: throw an error when writing a too long buffer (zhenweijin) #52215
[65fa95d57d] - test: add Debugger.setInstrumentationBreakpoint known issue (Konstantin Ulitin) #31137
[0513e07805] - test: use for-of instead of forEach (Gibby Free) #49790
[1d01325928] - test: verify request payload is uploaded consistently (Austin Wright) #34066
[7dda156872] - test: add fuzzer for native/js string conversion (Adam Korczynski) #51120
[5fb829b340] - test: add fuzzer for ClientHelloParser (AdamKorcz) #51088
[cc74bf789f] - test: fix broken env fuzzer by initializing process (AdamKorcz) #51080
[800b6f65cf] - test: replace forEach() in test-stream-pipe-unpipe-stream (Dario) #50786
[d08c9a6a31] - test: test pipeline end on transform streams (Alois Klink) #48970
[0be8123ede] - test: improve coverage of lib/readline.js (Rongjian Zhang) #38646
[410224415c] - test: updated for each to for of in test file (lyannel) #50308
[556e9a2127] - test: move test-http-server-request-timeouts-mixed to sequential (Madhuri) #45722
[0638274c07] - test: fix DNS cancel tests (Szymon Marczak) #44432
[311bdc62bd] - test: add http agent to executionAsyncResource (psj-tar-gz) #34966
[6001b164ab] - test: reduce memory usage of test-worker-stdio (Adam Majer) #37769
[986bfa26e9] - test: add common.expectRequiredModule() (Joyee Cheung) #52868
[2246d4fd1e] - test: crypto-rsa-dsa testing for dynamic openssl (Michael Dawson) #52781
[1dce5dea0b] - test: skip some console tests on dumb terminal (Adam Majer) #37770
[0addeb240c] - test: skip v8-updates/test-linux-perf-logger (Michaël Zasso) #52821
[56e19e38f3] - test: drop test-crypto-timing-safe-equal-benchmarks (Rafael Gonzaga) #52751
[0c5e58958c] - test, crypto: use correct object on assert (响马) #51820
[d54aa47ec1] - (SEMVER-MINOR) test_runner: support test plans (Colin Ihrig) #52860
[0289a023a5] - test_runner: fix watch mode race condition (Moshe Atlow) #52954
[cf817e192e] - test_runner: preserve hook promise when executed twice (Moshe Atlow) #52791
[de541235fe] - tools: fix v8-update workflow (Michaël Zasso) #52957
[f6290bc327] - tools: add --certify-safe to nci-ci (Matteo Collina) #52940
[0830b3115d] - tools: fix doc update action (Marco Ippolito) #52890
[9d485b40bb] - (SEMVER-MINOR) tools: fix get_asan_state() in tools/test.py (Joyee Cheung) #52766
[e98c305f52] - (SEMVER-MINOR) tools: support max_virtual_memory test configuration (Joyee Cheung) #52766
[dce0300896] - (SEMVER-MINOR) tools: support != in test status files (Joyee Cheung) #52766
[57006001ec] - tools: prepare custom rules for ESLint v9 (Michaël Zasso) #52889
[403a4a7557] - tools: update lint-md-dependencies to rollup@4.17.2 (Node.js GitHub Bot) #52836
[01eff5860e] - tools: update gr2m/create-or-update-pull-request-action (Antoine du Hamel) #52843
[514f01ed59] - tools: use sccache GitHub action (Michaël Zasso) #52839
[8f8fb91927] - tools: specify a commit-message for V8 update workflow (Antoine du Hamel) #52844
[b83fbf8709] - tools: fix V8 update workflow (Antoine du Hamel) #52822
[be9d6f2176] - url,tools,benchmark: replace deprecated substr() (Jungku Lee) #51546
[7603a51d45] - util: fix %s format behavior with Symbol.toPrimitive (Chenyu Yang) #50992
[d7eba50cf3] - util: improve isInsideNodeModules (uzlopak) #52147
[4ae4f7e517] - watch: allow listening for grouped changes (Matthieu Sieben) #52722
[1ff8f318c0] - watch: enable passthrough ipc in watch mode (Zack) #50890
[739adf90b1] - watch: fix arguments parsing (Moshe Atlow) #52760
[5161d95c30] - (SEMVER-MINOR) zlib: expose zlib.crc32() (Joyee Cheung) #52692

This reverts commit 0f784c9 because it triggers a bug in the V8 version that Node.js 20.x uses. PR-URL: #53390 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operational on Windows. The changes involve removing the Windows-specific code from the POSIX section and correctly placing it under the WIN32 check. This fix will ensure that the intended exception handling is active on Windows builds. Fixes: #52404 Refs: #35033 PR-URL: #52545 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #52751 Refs: #38226 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #52757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This patch exposes the crc32() function from zlib to user-land. It computes a 32-bit Cyclic Redundancy Check checksum of `data`. If `value` is specified, it is used as the starting value of the checksum, otherwise, 0 is used as the starting value. ```js const zlib = require('node:zlib'); const { Buffer } = require('node:buffer'); let crc = zlib.crc32('hello'); // 907060870 crc = zlib.crc32('world', crc); // 4192936109 crc = zlib.crc32(Buffer.from('hello')); // 907060870 crc = zlib.crc32(Buffer.from('world'), crc); // 4192936109 ``` PR-URL: #52692 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #52760 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

PR-URL: #52215 Fixes: #52214 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #52791 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52702 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Fixes: #33705 PR-URL: #34213 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Refs: #51308 PR-URL: #52821 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52822 Fixes: #50497 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52844 Fixes: #50497 Refs: gr2m/create-or-update-pull-request-action#280 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Fixes: #26287 PR-URL: #38056 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: #52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: #52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This adds two more tests to be skipped on systems with only a dumb terminal. See #33165 for details. PR-URL: #37770 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: #52588 Refs: #52585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #52537 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52781 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #52108 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Fixes: #52665 PR-URL: #52874 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #52843 Refs: https://github.com/gr2m/create-or-update-pull-request-action/releases/tag/v1.9.4 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

PR-URL: #52856 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

nodejs-github-bot · 2024-06-17T12:20:27Z

mcollina · 2024-06-19T09:05:52Z

@marco-ippolito please remove all undici updates.

Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #52860 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

By default, Node.js enables trap-handler-based WebAssembly bound checks. As a result, V8 does not need to insert inline bound checks int the code compiled from WebAssembly which may speedup WebAssembly execution significantly, but this optimization requires allocating a big virtual memory cage (currently 10GB). If the Node.js process does not have access to a large enough virtual memory address space due to system configurations or hardware limitations, users won't be able to run any WebAssembly that involves allocation in this virtual memory cage and will see an out-of-memory error. ```console $ ulimit -v 5000000 $ node -p "new WebAssembly.Memory({ initial: 10, maximum: 100 });" [eval]:1 new WebAssembly.Memory({ initial: 10, maximum: 100 }); ^ RangeError: WebAssembly.Memory(): could not allocate memory at [eval]:1:1 at runScriptInThisContext (node:internal/vm:209:10) at node:internal/process/execution:118:14 at [eval]-wrapper:6:24 at runScript (node:internal/process/execution:101:62) at evalScript (node:internal/process/execution:136:3) at node:internal/main/eval_string:49:3 ``` `--disable-wasm-trap-handler` disables this optimization so that users can at least run WebAssembly (with a less optimial performance) when the virtual memory address space available to their Node.js process is lower than what the V8 WebAssembly memory cage needs. PR-URL: #52766 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Notable changes: doc: * add pimterry to collaborators (Tim Perry) #52874 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) #52734 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) #52860 tools: * (SEMVER-MINOR) fix get_asan_state() in tools/test.py (Joyee Cheung) #52766 * (SEMVER-MINOR) support max_virtual_memory test configuration (Joyee Cheung) #52766 * (SEMVER-MINOR) support != in test status files (Joyee Cheung) #52766 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692 PR-URL: #53486

marco-ippolito · 2024-06-19T09:16:53Z

@marco-ippolito please remove all undici updates.

done

nodejs-github-bot · 2024-06-19T11:35:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59883/ 🟢
CITGM: https://ci.nodejs.org/job/citgm-smoker/3448/ 🟢
CITGM (v20.14.0): https://ci.nodejs.org/job/citgm-smoker/3442/
RELEASE-CI: https://ci-release.nodejs.org/job/iojs+release/10285/

marco-ippolito · 2024-06-19T17:57:23Z

@mcollina when the patch for undici will be ready? Tomorrow is the planned release date, if we postpone, we have to postpone to next week (since it would be on a friday)

MoLow · 2024-06-19T18:05:06Z

@marco-ippolito @nodejs/releasers can 67c19c2 be added to the release? It seems important to me

marco-ippolito · 2024-06-19T18:11:04Z

@marco-ippolito @nodejs/releasers can 67c19c2 be added to the release? It seems important to me

I dont have the background on the urgency of this change, if we have to patch undici I have no problem adding it to the release, but technically this change has not been released yet so it should stay on Current before adding it to LTS (I guess it applies to these kind of changes too?)

marco-ippolito · 2024-06-20T09:48:31Z

@nodejs/undici I think its better to wait for a proper patch landing on v22 and add it to v20 (as per guidelines), if no objection I'll go ahead and release v20.15.0 without the fix for lambda.

Notable changes: doc: * add pimterry to collaborators (Tim Perry) #52874 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) #52734 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) #52860 tools: * (SEMVER-MINOR) fix get_asan_state() in tools/test.py (Joyee Cheung) #52766 * (SEMVER-MINOR) support max_virtual_memory test configuration (Joyee Cheung) #52766 * (SEMVER-MINOR) support != in test status files (Joyee Cheung) #52766 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692 PR-URL: #53486

mcollina · 2024-06-20T11:12:08Z

Well, lambda and Next.js are currently broken on a certain usecase. I hoped we could land the proper fixes via the releases but we had another unrelated regression that is better not to backport v6.17.0.

I can try to work on it later today/tomorrow (I had been traveling this week and will be traveling next week).

This is the PR that needs a backport https://github.com/nodejs/undici/pull/3269/files in case somebody else beat me to it.

Personally I think it's better to land the backport now or next week rather than waiting 3-4 weeks that the normal undici release get through a v22 release + 2 weeks.

This is high severity AWS Lambda/Vercel/Next.js fix as the only "fix" for some users is to switch back to node-fetch.

richardlau · 2024-06-20T12:16:34Z

Is reverting the undici updates on v20.x back to (but not including) undici 6.6.2 an option?

mcollina · 2024-06-20T13:04:44Z

@richardlau if you want a revert, I think the only real option is to go down to v5.28.3, as v6.6.2 was never released on v20. Node.js v18 is at v5.28.3. We should likely have done that immediately.

I tried to do a backport of the fix and it didn't apply cleanly. I think rolling down to v5.28.3 is likely the safest move if you don't want to jump to v6.19.2.

marco-ippolito · 2024-06-20T13:13:22Z

@richardlau if you want a revert, I think the only real option is to go down to v5.28.3, as v6.6.2 was never released on v20. Node.js v18 is at v5.28.3. We should likely have done that immediately.

I tried to do a backport of the fix and it didn't apply cleanly. I think rolling down to v5.28.3 is likely the safest move if you don't want to jump to v6.19.2.

v6.6.2 was released on v20.13.0 so I guess it is possible, to revert everything after that

marco-ippolito · 2024-06-20T13:28:42Z

Due to the current circumstances I'll go ahead and release v20.15.0, I'll be available to release earlier the next v20.x version after the fix lands on v22

PR-URL: #53486

Notable changes: doc: * add pimterry to collaborators (Tim Perry) #52874 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) #52734 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) #52860 tools: * (SEMVER-MINOR) fix get_asan_state() in tools/test.py (Joyee Cheung) #52766 * (SEMVER-MINOR) support max_virtual_memory test configuration (Joyee Cheung) #52766 * (SEMVER-MINOR) support != in test status files (Joyee Cheung) #52766 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692 PR-URL: #53486

Refs: nodejs/node#53486

Notable changes: doc: * add pimterry to collaborators (Tim Perry) nodejs#52874 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) nodejs#52734 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) nodejs#52860 tools: * (SEMVER-MINOR) fix get_asan_state() in tools/test.py (Joyee Cheung) nodejs#52766 * (SEMVER-MINOR) support max_virtual_memory test configuration (Joyee Cheung) nodejs#52766 * (SEMVER-MINOR) support != in test status files (Joyee Cheung) nodejs#52766 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) nodejs#52692 PR-URL: nodejs#53486

tniessen and others added 28 commits June 12, 2024 09:35

doc: add test_runner to subsystem

6ea72a5

PR-URL: #52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

doc: simplify copy-pasting of branch-diff commands

9587ae9

PR-URL: #52757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

watch: fix arguments parsing

739adf9

PR-URL: #52760 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

string_decoder: throw an error when writing a too long buffer

a5f3dd1

PR-URL: #52215 Fixes: #52214 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

test_runner: preserve hook promise when executed twice

cf817e1

PR-URL: #52791 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

build: make simdjson a public dep in GN build

918962d

PR-URL: #52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

util: improve isInsideNodeModules

d7eba50

PR-URL: #52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

doc: add OpenSSL errors to API docs

a3b2012

Fixes: #33705 PR-URL: #34213 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

test: skip v8-updates/test-linux-perf-logger

0addeb2

Refs: #51308 PR-URL: #52821 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

tools: specify a commit-message for V8 update workflow

8f8fb91

PR-URL: #52844 Fixes: #50497 Refs: gr2m/create-or-update-pull-request-action#280 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

doc: make docs more welcoming and descriptive for newcomers

91fadac

Fixes: #26287 PR-URL: #38056 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc: add more definitions to GLOSSARY.md

97e0fef

Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: #52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

buffer: remove lines setting indexes to integer value

16ae2b2

PR-URL: #52588 Refs: #52585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

test: crypto-rsa-dsa testing for dynamic openssl

2246d4f

Fixes: #52537 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52781 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

process: improve event-loop

121ea13

PR-URL: #52108 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

doc: add pimterry to collaborators

12512c3

Fixes: #52665 PR-URL: #52874 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

build: drop base64 dep in GN build

1be8232

PR-URL: #52856 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 17, 2024

cjihrig and others added 2 commits June 19, 2024 11:12

test_runner: support test plans

d54aa47

Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #52860 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

marco-ippolito force-pushed the v20.15.0-proposal branch from 7d9ad19 to e09cd5e Compare June 19, 2024 09:16

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2024

marco-ippolito force-pushed the v20.15.0-proposal branch from e09cd5e to 0bf200b Compare June 20, 2024 10:08

marco-ippolito mentioned this pull request Jun 20, 2024

[v20.x] Revert "deps: update undici to 6.13.0" #53520

Closed

richardlau approved these changes Jun 20, 2024

View reviewed changes

marco-ippolito merged commit 0bf200b into v20.x Jun 20, 2024
20 checks passed

marco-ippolito deleted the v20.15.0-proposal branch June 20, 2024 15:49

marco-ippolito added a commit that referenced this pull request Jun 20, 2024

Working on v20.15.1

d162dca

PR-URL: #53486

marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request Jun 20, 2024

Blog: v20.15.0 release post

7dc99d1

Refs: nodejs/node#53486

marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request Jun 20, 2024

Blog: v20.15.0 release post (#6852)

98c06c1

Refs: nodejs/node#53486

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v20.15.0 proposal #53486

v20.15.0 proposal #53486

marco-ippolito commented Jun 17, 2024 •

edited

Loading

nodejs-github-bot commented Jun 17, 2024

mcollina commented Jun 19, 2024

marco-ippolito commented Jun 19, 2024

nodejs-github-bot commented Jun 19, 2024 •

edited by marco-ippolito

Loading

marco-ippolito commented Jun 19, 2024 •

edited

Loading

MoLow commented Jun 19, 2024 •

edited by marco-ippolito

Loading

marco-ippolito commented Jun 19, 2024 •

edited

Loading

marco-ippolito commented Jun 20, 2024

mcollina commented Jun 20, 2024

richardlau commented Jun 20, 2024

mcollina commented Jun 20, 2024 •

edited

Loading

marco-ippolito commented Jun 20, 2024 •

edited

Loading

marco-ippolito commented Jun 20, 2024

v20.15.0 proposal #53486

v20.15.0 proposal #53486

Conversation

marco-ippolito commented Jun 17, 2024 • edited Loading

2024-06-20, Version 20.15.0 'Iron' (LTS), @marco-ippolito

test_runner: support test plans

inspector: introduce the --inspect-wait flag

zlib: expose zlib.crc32()

cli: allow running wasm in limited vmem with --disable-wasm-trap-handler

Other Notable Changes

Commits

nodejs-github-bot commented Jun 17, 2024

mcollina commented Jun 19, 2024

marco-ippolito commented Jun 19, 2024

nodejs-github-bot commented Jun 19, 2024 • edited by marco-ippolito Loading

marco-ippolito commented Jun 19, 2024 • edited Loading

MoLow commented Jun 19, 2024 • edited by marco-ippolito Loading

marco-ippolito commented Jun 19, 2024 • edited Loading

marco-ippolito commented Jun 20, 2024

mcollina commented Jun 20, 2024

richardlau commented Jun 20, 2024

mcollina commented Jun 20, 2024 • edited Loading

marco-ippolito commented Jun 20, 2024 • edited Loading

marco-ippolito commented Jun 20, 2024

marco-ippolito commented Jun 17, 2024 •

edited

Loading

inspector: introduce the `--inspect-wait` flag

nodejs-github-bot commented Jun 19, 2024 •

edited by marco-ippolito

Loading

marco-ippolito commented Jun 19, 2024 •

edited

Loading

MoLow commented Jun 19, 2024 •

edited by marco-ippolito

Loading

marco-ippolito commented Jun 19, 2024 •

edited

Loading

mcollina commented Jun 20, 2024 •

edited

Loading

marco-ippolito commented Jun 20, 2024 •

edited

Loading