Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: enable unbundling of simdjson, simdutf, ada #52924

Merged
merged 4 commits into from
May 11, 2024
Merged

deps: enable unbundling of simdjson, simdutf, ada #52924

merged 4 commits into from
May 11, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented May 9, 2024

When building Node.js, it is possible to replace most dependencies by locally provided ones. However, it does not apply for at least three dependencies: simdjson, simdutf, ada. This PR seeks to enable this possibility.

Fixes #52914

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 9, 2024
@lemire lemire requested review from jasnell and anonrig May 9, 2024 19:08
@lemire
Copy link
Member Author

lemire commented May 9, 2024

cc @williamh

@lemire lemire requested review from benjamingr and kvakil May 9, 2024 19:09
@anonrig
Copy link
Member

anonrig commented May 9, 2024

cc @nodejs/build @richardlau

richardlau
richardlau reviewed May 9, 2024
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the default libnames are the same as the * part of the --shared-*-libname pattern. Please amend accordingly if not. They're almost certainly not likely to be z 🙂.

configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
@williamh
Copy link

williamh commented May 9, 2024

Is it possible to add ngtcp2 to this pr, or should that be done in another pr?
Thanks much

lemire and others added 3 commits May 9, 2024 16:21
@lemire @richardlau
Update configure.py
53ca846 
Co-authored-by: Richard Lau <rlau@redhat.com>
@lemire @richardlau
Update configure.py
fbc612d 
Co-authored-by: Richard Lau <rlau@redhat.com>
@lemire @richardlau
Update configure.py
2356b7d 
Co-authored-by: Richard Lau <rlau@redhat.com>
@lemire
Copy link
Member Author

lemire commented May 9, 2024 •
edited
Loading

@williamh My reading of the code is that ngtcp2 can be made unbundled right now. But gentoo does not choose to do so. I think @jasnell did add this feature already.

@williamh
Copy link

williamh commented May 9, 2024

Ok, thanks for this info, I'll take a look at my side again.

@richardlau richardlau added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels May 9, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59068/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit d78537b into nodejs:main May 11, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d78537b

targos pushed a commit that referenced this pull request May 12, 2024
@lemire @targos
deps: enable unbundling of simdjson, simdutf, ada
232831f 
PR-URL: #52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@lemire @marco-ippolito
deps: enable unbundling of simdjson, simdutf, ada
afc63d8 
PR-URL: #52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@lemire @marco-ippolito
deps: enable unbundling of simdjson, simdutf, ada
cce2dc2 
PR-URL: #52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@lemire @marco-ippolito
deps: enable unbundling of simdjson, simdutf, ada
b774544 
PR-URL: #52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sophonieb pushed a commit to sophonieb/node that referenced this pull request Jun 20, 2024
@lemire @sophonieb
deps: enable unbundling of simdjson, simdutf, ada
12ed8ee 
PR-URL: nodejs#52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@lemire @bmeck
deps: enable unbundling of simdjson, simdutf, ada
23a8422 
PR-URL: nodejs#52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: conditionally compile bundled ada
2db11e8 
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: conditionally compile bundled simdjson
9d518ed 
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: conditionally compile bundled simdutf
e12c6ef 
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914
@jirutka jirutka mentioned this pull request Nov 16, 2024
Closed
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: compile bundled ada conditionally
78bd0ab 
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: compile bundled simdjson conditionally
077b553 
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: compile bundled simdutf conditionally
4a035b3 
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka @nodejs-github-bot
build: compile bundled ada conditionally
88719f6 
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka @nodejs-github-bot
build: compile bundled simdjson conditionally
dd15563 
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka @nodejs-github-bot
build: compile bundled simdutf conditionally
64c647e 
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@jirutka @tpoisseau
build: compile bundled ada conditionally
466519b 
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@jirutka @tpoisseau
build: compile bundled simdjson conditionally
ecf9759 
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@jirutka @tpoisseau
build: compile bundled simdutf conditionally
387d260 
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@kvakil kvakil Awaiting requested review from kvakil

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please allow the use of the simdjson library provided by the distribution
7 participants
@lemire @anonrig @williamh @nodejs-github-bot @benjamingr @lpinca @richardlau