Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention quicker way to build docs #52937

Merged
merged 1 commit into from
May 12, 2024
Merged

doc: mention quicker way to build docs #52937

merged 1 commit into from
May 12, 2024

Conversation

crawford
Copy link
Contributor

make doc-only skips the process of building Node, which speeds things up considerably for new contributors.

(This was split out from #52883)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 10, 2024
@crawford crawford mentioned this pull request May 10, 2024
Closed
aduh95
aduh95 approved these changes May 10, 2024
View reviewed changes
doc/contributing/api-documentation.md Outdated Show resolved Hide resolved
doc/contributing/api-documentation.md Outdated Show resolved Hide resolved
@crawford
doc: mention quicker way to build docs
43546cf 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.
avivkeller
avivkeller approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@avivkeller avivkeller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tip

I'm not a CODEOWNER, but a member of the issue-triage team. My review is not approving nor blocking.

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 10, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit d272625 into nodejs:main May 12, 2024
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d272625

targos pushed a commit that referenced this pull request May 12, 2024
@crawford @targos
doc: mention quicker way to build docs
9102255 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.

PR-URL: #52937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@crawford crawford deleted the make-doc-only branch May 13, 2024 16:38
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@crawford @marco-ippolito
doc: mention quicker way to build docs
446282a 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.

PR-URL: #52937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@crawford @marco-ippolito
doc: mention quicker way to build docs
4bf836d 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.

PR-URL: #52937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@crawford @marco-ippolito
doc: mention quicker way to build docs
3a1d17a 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.

PR-URL: #52937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@crawford @sophoniie
doc: mention quicker way to build docs
3737db5 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.

PR-URL: nodejs#52937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@crawford @bmeck
doc: mention quicker way to build docs
4a298bf 
`make doc-only` skips the process of building Node, which speeds
things up considerably for new contributors.

PR-URL: nodejs#52937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@avivkeller avivkeller avivkeller approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@crawford @nodejs-github-bot @jasnell @lpinca @UlisesGascon @richardlau @aduh95 @RafaelGSS @marco-ippolito @avivkeller