src: use __FUNCSIG__ on Windows in backtrace #53135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To show function signature if possible.
nodejs-github-bot
added
c++
lpinca
approved these changes
May 24, 2024
anonrig
approved these changes
May 24, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
May 24, 2024
StefanStojanovic
approved these changes
May 27, 2024
github-actions
bot
removed
the
request-ci
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0a3f930 |
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
To show function signature if possible. PR-URL: #53135 Refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
To show function signature if possible. PR-URL: nodejs#53135 Refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
To show function signature if possible. PR-URL: nodejs#53135 Refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
To show function signature if possible. PR-URL: #53135 Refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
To show function signature if possible. PR-URL: #53135 Refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show function signature if possible.
Refs: #50242 (comment)
Refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
I am not sure if this actually works since I don't have a Windows device right now. TBD how to test this in the CI...