Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: fix TypedArray to a global type #54063

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

1ilsang
Copy link
Contributor

@1ilsang 1ilsang commented Jul 27, 2024

AS-IS

image

TO-BE

image
  • Fix TypedArray to a global type

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 94419bf into nodejs:main Sep 6, 2024
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 94419bf

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
PR-URL: #54063
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants