cli: remove deprecated v8 flags #54761

omerktz · 2024-09-04T12:25:33Z

Node is currently exposing the --huge-max-old-generation-size V8 flag. That flag was recently deprecated (it currently remains as nop, see crrev.com/c/5831467) and will soon be completely removed.
This PR removes the flag from Node as well (cli, documentation and tests).

RedYetiDev · 2024-09-04T13:13:11Z

Node.js's V8 version hasn't deprecated the flag yet, the commit was just added today (https://chromium.googlesource.com/v8/v8/+/fb3c72c1fc9a36e833d01509e8c9d674a17cf097)

Should the tests be updated, or should they wait until the internal V8 version is?

targos · 2024-09-04T13:21:30Z

This flag is also referenced in doc/api/cli.md and src/node_options.cc: https://github.com/search?q=repo%3Anodejs%2Fnode%20huge-max-old-generation-size&type=code

omerktz · 2024-09-04T13:29:54Z

Node.js's V8 version hasn't deprecated the flag yet, the commit was just added today (https://chromium.googlesource.com/v8/v8/+/fb3c72c1fc9a36e833d01509e8c9d674a17cf097)

Should the tests be updated, or should they wait until the internal V8 version is?

Node is not yet using the latest V8 version, but it eventually will. On the V8 side we have a node bot that complains if we try to remove the flag right now. We could disable the test on our end or have this PR as a floating patch there, but I think it makes more sense to already fix Node.
The flag was anyway enabled by default, so even if any Node users were using it wouldn't have made any difference.

This flag is also referenced in doc/api/cli.md and src/node_options.cc: https://github.com/search?q=repo%3Anodejs%2Fnode%20huge-max-old-generation-size&type=code

Thanks. I missed these. Does Node have a deprecation process to remove flags that it exposed through src/node_options.cc?

targos · 2024-09-04T13:32:38Z

There are no stability guarantees on the V8 flags that we expose for convenience (so we don't need a deprecation cycle).

omerktz · 2024-09-04T13:43:26Z

Thanks.
I updated the PR to remove --huge-max-old-generation-size from doc/api/cli.md and src/node_options.cc as well.

omerktz · 2024-09-04T13:44:27Z

Can someone run the checks on behalf? It says it's waiting for approval from a maintainer but I unfortunately am not one. Thanks.

nodejs-github-bot · 2024-09-04T13:55:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61924/

nodejs-github-bot · 2024-09-04T13:55:23Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6173/

nodejs-github-bot · 2024-09-04T13:58:09Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6173/

nodejs-github-bot · 2024-09-04T14:40:50Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6173/

codecov · 2024-09-04T15:08:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (70de19e) to head (b2abfc4).
Report is 218 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54761      +/-   ##
==========================================
+ Coverage   87.61%   88.03%   +0.42%     
==========================================
  Files         650      652       +2     
  Lines      182829   183758     +929     
  Branches    35376    35856     +480     
==========================================
+ Hits       160186   161774    +1588     
+ Misses      15917    15230     -687     
- Partials     6726     6754      +28

Files with missing lines	Coverage Δ
src/node_options.cc	`88.04% <ø> (+0.16%)`	⬆️

... and 150 files with indirect coverage changes

RedYetiDev · 2024-09-04T16:48:11Z

Seeing as this does more than originally intended, WDYT about updating the commit message to:
cli: remove deprecated v8 flags (or similar)?

omerktz · 2024-09-04T18:54:36Z

Seeing as this does more than originally intended, WDYT about updating the commit message to: cli: remove deprecated v8 flags (or similar)?

Done

omerktz · 2024-09-04T18:57:53Z

Is it normal for the checks to take this long?
There are also a couple of failed tests, but I can't see how these failures (based on their outputs) can result from this PR. Are the tests just flaky?
Asking since I'm not yet familiar with Node's tests and testing infrastructure.

RedYetiDev · 2024-09-05T00:24:02Z

Is it normal for the checks to take this long?

Yea, tests can take a while. (For example, there's been some backlog on the MacOS runners leaving those tests taking >8hrs!)

There are also a couple of failed tests, but I can't see how these failures (based on their outputs) can result from this PR. Are the tests just flaky?

Sometimes. When a maintainers sees that, they may choose to restart the CI run for that machine.

Thanks for updating the PR title! Could you apply the same change to the commit message?

omerktz · 2024-09-05T05:25:57Z

Thanks for updating the PR title! Could you apply the same change to the commit message?

Done. Thanks for pointing out.

omerktz · 2024-09-06T07:58:39Z

Hi folks.
Jenkins reports 5 failed tests. I believe these are unrelated to the actual PR, but afaict I don't have permissions to restart the tests.
Can we merge this PR despite the failures? I'm also not authorized to merge.
Can someone either restart the tests or merge the PR on my behalf?
Thanks!

nodejs-github-bot · 2024-09-19T09:02:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62557/

nodejs-github-bot · 2024-09-19T09:02:54Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6201/

nodejs-github-bot · 2024-09-19T09:05:50Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6201/

nodejs-github-bot · 2024-09-19T09:13:25Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6201/

omerktz · 2024-09-20T19:46:53Z

There are 11 workflows awaiting approval. Can someone approve them? Thanks.

RedYetiDev · 2024-09-20T20:15:29Z

@nodejs/tsc per nodejs/Release#1034

nodejs-github-bot · 2024-09-21T05:00:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62615/

nodejs-github-bot · 2024-09-21T08:46:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/54761
✔  Done loading data for nodejs/node/pull/54761
----------------------------------- PR info ------------------------------------
Title      cli: remove deprecated v8 flags (#54761)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     omerktz:fix_test -> nodejs:main
Labels     semver-major, v8 engine, test, needs-ci
Commits    1
 - test: remove deprecated v8 flag from nodejs test
Committers 1
 - Omer Katz <omerkatz@chromium.org>
PR-URL: https://github.com/nodejs/node/pull/54761
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54761
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: remove deprecated v8 flag from nodejs test
   ℹ  This PR was created on Wed, 04 Sep 2024 12:25:33 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54761#pullrequestreview-2280305867
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54761#pullrequestreview-2280382374
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54761#pullrequestreview-2280395309
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54761#pullrequestreview-2280638857
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-21T05:00:30Z: https://ci.nodejs.org/job/node-test-pull-request/62615/
- Querying data for job/node-test-pull-request/62615/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10971218305

targos · 2024-09-21T08:47:44Z

Going to land manually as I just realized the commit message isn't right.

Remove the `--huge-max-old-generation-size` V8 flag from the `NODE_OPTIONS` allowlist. That flag was recently deprecated (it currently remains as nop, see crrev.com/c/5831467) and will soon be completely removed. PR-URL: #54761 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos · 2024-09-21T08:53:40Z

Landed in 4f1fe8a

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

Remove the `--huge-max-old-generation-size` V8 flag from the `NODE_OPTIONS` allowlist. That flag was recently deprecated (it currently remains as nop, see crrev.com/c/5831467) and will soon be completely removed. PR-URL: nodejs#54761 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) nodejs#53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) nodejs#54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) nodejs#47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) nodejs#54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) nodejs#54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) nodejs#54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) nodejs#53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) nodejs#45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) nodejs#53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) nodejs#54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) nodejs#52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) nodejs#52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) nodejs#52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) nodejs#52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) nodejs#55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) nodejs#53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) nodejs#52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) nodejs#54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) nodejs#54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) nodejs#54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) nodejs#53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) nodejs#54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) nodejs#49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) nodejs#51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) nodejs#53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) nodejs#54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) nodejs#54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) nodejs#55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) nodejs#54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) nodejs#54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) nodejs#53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) nodejs#52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) nodejs#53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) nodejs#54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) nodejs#54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) nodejs#54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) nodejs#54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) nodejs#52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) nodejs#46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) nodejs#52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) nodejs#54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) nodejs#54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) nodejs#52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) nodejs#55020 PR-URL: nodejs#55338

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 4, 2024

RedYetiDev added the v8 engine Issues and PRs related to the V8 dependency. label Sep 4, 2024

RedYetiDev added the deprecations Issues and PRs related to deprecations. label Sep 4, 2024

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 4, 2024

richardlau removed the deprecations Issues and PRs related to deprecations. label Sep 4, 2024

richardlau approved these changes Sep 4, 2024

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

lpinca approved these changes Sep 4, 2024

View reviewed changes

targos approved these changes Sep 4, 2024

View reviewed changes

anonrig approved these changes Sep 4, 2024

View reviewed changes

omerktz changed the title ~~test: remove deprecated v8 flag from nodejs test~~ cli: remove deprecated v8 flags Sep 4, 2024

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 21, 2024

targos self-assigned this Sep 21, 2024

targos approved these changes Sep 21, 2024

View reviewed changes

targos closed this Sep 21, 2024

targos removed their assignment Sep 21, 2024

omerktz deleted the fix_test branch September 21, 2024 19:42

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli: remove deprecated v8 flags #54761

cli: remove deprecated v8 flags #54761

omerktz commented Sep 4, 2024 •

edited

Loading

RedYetiDev commented Sep 4, 2024 •

edited

Loading

targos commented Sep 4, 2024

omerktz commented Sep 4, 2024

targos commented Sep 4, 2024

omerktz commented Sep 4, 2024

omerktz commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

codecov bot commented Sep 4, 2024 •

edited

Loading

RedYetiDev commented Sep 4, 2024 •

edited

Loading

omerktz commented Sep 4, 2024

omerktz commented Sep 4, 2024

RedYetiDev commented Sep 5, 2024

omerktz commented Sep 5, 2024 •

edited

Loading

omerktz commented Sep 6, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

omerktz commented Sep 20, 2024

RedYetiDev commented Sep 20, 2024

nodejs-github-bot commented Sep 21, 2024

nodejs-github-bot commented Sep 21, 2024

targos commented Sep 21, 2024

targos commented Sep 21, 2024

cli: remove deprecated v8 flags #54761

cli: remove deprecated v8 flags #54761

Conversation

omerktz commented Sep 4, 2024 • edited Loading

RedYetiDev commented Sep 4, 2024 • edited Loading

targos commented Sep 4, 2024

omerktz commented Sep 4, 2024

targos commented Sep 4, 2024

omerktz commented Sep 4, 2024

omerktz commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 4, 2024

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

RedYetiDev commented Sep 4, 2024 • edited Loading

omerktz commented Sep 4, 2024

omerktz commented Sep 4, 2024

RedYetiDev commented Sep 5, 2024

omerktz commented Sep 5, 2024 • edited Loading

omerktz commented Sep 6, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

omerktz commented Sep 20, 2024

RedYetiDev commented Sep 20, 2024

nodejs-github-bot commented Sep 21, 2024

nodejs-github-bot commented Sep 21, 2024

targos commented Sep 21, 2024

targos commented Sep 21, 2024

omerktz commented Sep 4, 2024 •

edited

Loading

RedYetiDev commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

RedYetiDev commented Sep 4, 2024 •

edited

Loading

omerktz commented Sep 5, 2024 •

edited

Loading