Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: fix assert in context._external accessor #5521

Merged
merged 1 commit into from
Mar 2, 2016
Merged

tls: fix assert in context._external accessor #5521

merged 1 commit into from
Mar 2, 2016

Conversation

bnoordhuis
Copy link
Member

  • Restrict the receiver to instances of the FunctionTemplate.
  • Use args.This() instead of args.Holder().

Fixes: #3682

R=@indutny

@bnoordhuis bnoordhuis added tls Issues and PRs related to the tls subsystem. crypto Issues and PRs related to the crypto subsystem. labels Mar 2, 2016
@bnoordhuis
Copy link
Member Author

Tests pass locally. CI is timing out and I have to step out for a bit, will revisit when I get back.

@indutny
Copy link
Member

indutny commented Mar 2, 2016

LGTM

@bnoordhuis
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1805/

@bnoordhuis
tls: fix assert in context._external accessor
0bea786 
* Restrict the receiver to instances of the FunctionTemplate.
* Use `args.This()` instead of `args.Holder()`.

Fixes: nodejs#3682
PR-URL: nodejs#5521
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@bnoordhuis bnoordhuis closed this Mar 2, 2016
@bnoordhuis bnoordhuis deleted the fix3682 branch March 2, 2016 16:16
@bnoordhuis bnoordhuis merged commit 0bea786 into nodejs:master Mar 2, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
@bnoordhuis @Fishrock123
tls: fix assert in context._external accessor
25c01cd 
* Restrict the receiver to instances of the FunctionTemplate.
* Use `args.This()` instead of `args.Holder()`.

Fixes: #3682
PR-URL: #5521
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2016
Closed
@MylesBorins
Copy link
Contributor

adding the lts-watch flag

@bnoordhuis it is safe to assume you think this should be backported

@MylesBorins
Copy link
Contributor

one more time pinging @bnoordhuis. Maybe @indutny knows.

This landed cleanly and tests passed locally

@indutny
Copy link
Member

indutny commented Mar 17, 2016

If it builds - it is safe to land it.

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@bnoordhuis
tls: fix assert in context._external accessor
48cda9e 
* Restrict the receiver to instances of the FunctionTemplate.
* Use `args.This()` instead of `args.Holder()`.

Fixes: #3682
PR-URL: #5521
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@bnoordhuis
Copy link
Member Author

@thealphanerd For posterity, yes, it should be back-ported.

MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@bnoordhuis
tls: fix assert in context._external accessor
a60b0c2 
* Restrict the receiver to instances of the FunctionTemplate.
* Use `args.This()` instead of `args.Holder()`.

Fixes: #3682
PR-URL: #5521
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@bnoordhuis
tls: fix assert in context._external accessor
a673c9a 
* Restrict the receiver to instances of the FunctionTemplate.
* Use `args.This()` instead of `args.Holder()`.

Fixes: #3682
PR-URL: #5521
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@mhdawson
Copy link
Member

mhdawson commented Apr 7, 2016

We have an internal consumer that ran into what looked like nodejs/node-v0.x-archive#9028 and our tests have indicated that that the this PR has resolved the issue. Long way of saying +1 to getting this landed in the next 4.X releases.

@bnoordhuis bnoordhuis mentioned this pull request Apr 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnoordhuis @indutny @MylesBorins @mhdawson