Skip to content

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of undici to 7.15.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 24, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 24, 2025
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.93%. Comparing base (14c68e3) to head (b6559d5).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59605      +/-   ##
==========================================
- Coverage   89.93%   89.93%   -0.01%     
==========================================
  Files         669      669              
  Lines      197473   197473              
  Branches    38588    38589       +1     
==========================================
- Hits       177604   177601       -3     
- Misses      12284    12287       +3     
  Partials     7585     7585              

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Aug 25, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-undici branch from 837f653 to 0d6d0bf Compare August 31, 2025 00:38
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@targos
Copy link
Member

targos commented Sep 6, 2025

@nodejs/undici The CI failures seem related.

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 6, 2025

The thing is actually that we had some heavier changes since 7.15.0 in undici. 7.15.0 is more harmless,then what we have currently prepared for 7.16.0.

I am currently fighting with some stability or CI flakyness issues. And one test for shared-lib undici is failing on node 24 regularly. But this flakyness happened after release of 7.15.0.

@KhafraDev
Copy link
Member

---
duration_ms: 175.13
exitcode: 1
severity: fail
stack: |-
  node:internal/deps/undici/undici:15523
        Error.captureStackTrace(err);
              ^

  TypeError: fetch failed
      at node:internal/deps/undici/undici:15523:13
      at async file:///home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel9-ppc64le/test/parallel/test-fetch.mjs:28:18 {
    [cause]: HTTPParserError: Response does not match the HTTP/1.1 protocol (Invalid header value char)
        at Parser.execute (node:internal/deps/undici/undici:6456:21)
        at Parser.readMore (node:internal/deps/undici/undici:6411:16)
        at Socket.onHttpSocketReadable (node:internal/deps/undici/undici:6845:22)
        at Socket.emit (node:events:508:28)
        at emitReadable_ (node:internal/streams/readable:832:12)
        at process.processTicksAndRejections (node:internal/process/task_queues:89:21) {
      code: undefined,
      data: 'h: 11\r\n\r\nHello world'
    }
  }

  Node.js v25.0.0-pre

all similar errors from what I'm seeing

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 6, 2025

Feels like llhttp 9.3.0 has issues. But it works on nodejs core?

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-undici branch from 0d6d0bf to b6559d5 Compare September 7, 2025 00:38
@metcoder95
Copy link
Member

Errors seems to be not always related with Undici, but under specific platforms; the only change that could be related might be lhttp, maybe there is some new lenient flag that might be causing that

@mcollina
Copy link
Member

mcollina commented Sep 8, 2025

@nodejs/platform-aix The problem is actually specific to AIX and RedHat powerpc. I guess there is some problem there between our fetch WASM addons.

@mcollina
Copy link
Member

mcollina commented Sep 8, 2025

My guess by looking at those errors points to the new SIMD-accelerated patches that went into llhttp: nodejs/llparse#73.

I think we could try loading https://github.com/nodejs/undici/blob/95d835cd9db685e4f7baaea8e10aee8ce77e7989/lib/dispatcher/client-h1.js#L66-L77 without SIMD in AIX to see if it fixes it.

@richardlau
Copy link
Member

For Power, SIMD support requires Power 9+. Our OSUOSL hosted AIX machines are Power 8, as are our OSUOSL hosted RHEL 8 ppc64le machines.

https://ci.nodejs.org/job/node-test-commit-plinux/60592/ passed on RHEL 8 (provisioned as Power 8) but failed on rhel9, which are Power 9.

(nb. there's no link between RHEL version and Power architecture version -- it's just that the older VMs were created as Power 8 and the newer ones as Power 9.)

@richardlau
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-aix/58851/nodes=aix72-ppc64/ ran on an IBM Cloud hosted AIX machine, which I think is Power 9.

@targos
Copy link
Member

targos commented Sep 8, 2025

So maybe V8's implementation of WASM SIMD is broken on Power 9?

@richardlau
Copy link
Member

Spoke to @mcollina -- suggested for now to use non-SIMD on all of AIX and Linux ppc64le (os.type() == 'ppc64') for now. IBM will investigate separately whether there is an issue in V8.

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 9, 2025

@richardlau

undici 7.16.0 got released, can you create a update undici 7.16.0 PR?

@richardlau
Copy link
Member

Being superseded by undici 7.16.0.

@richardlau richardlau closed this Sep 9, 2025
@richardlau richardlau deleted the actions/tools-update-undici branch September 9, 2025 14:19
@richardlau
Copy link
Member

undici 7.16.0 got released, can you create a update undici 7.16.0 PR?

@Uzlopak I ran https://github.com/nodejs/node/actions/runs/17585683821/job/49952913962 and that picked up undici 7.15.0 again: #59827

https://github.com/nodejs/undici/releases is still showing 7.15.0 as the latest undici release.

@targos
Copy link
Member

targos commented Sep 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants