-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
deps: update undici to 7.15.0 #59605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59605 +/- ##
==========================================
- Coverage 89.93% 89.93% -0.01%
==========================================
Files 669 669
Lines 197473 197473
Branches 38588 38589 +1
==========================================
- Hits 177604 177601 -3
- Misses 12284 12287 +3
Partials 7585 7585 🚀 New features to boost your workflow:
|
837f653
to
0d6d0bf
Compare
@nodejs/undici The CI failures seem related. |
The thing is actually that we had some heavier changes since 7.15.0 in undici. 7.15.0 is more harmless,then what we have currently prepared for 7.16.0. I am currently fighting with some stability or CI flakyness issues. And one test for shared-lib undici is failing on node 24 regularly. But this flakyness happened after release of 7.15.0. |
all similar errors from what I'm seeing |
Feels like llhttp 9.3.0 has issues. But it works on nodejs core? |
0d6d0bf
to
b6559d5
Compare
Errors seems to be not always related with Undici, but under specific platforms; the only change that could be related might be lhttp, maybe there is some new lenient flag that might be causing that |
@nodejs/platform-aix The problem is actually specific to AIX and RedHat powerpc. I guess there is some problem there between our fetch WASM addons. |
My guess by looking at those errors points to the new SIMD-accelerated patches that went into llhttp: nodejs/llparse#73. I think we could try loading https://github.com/nodejs/undici/blob/95d835cd9db685e4f7baaea8e10aee8ce77e7989/lib/dispatcher/client-h1.js#L66-L77 without SIMD in AIX to see if it fixes it. |
For Power, SIMD support requires Power 9+. Our OSUOSL hosted AIX machines are Power 8, as are our OSUOSL hosted RHEL 8 ppc64le machines. https://ci.nodejs.org/job/node-test-commit-plinux/60592/ passed on RHEL 8 (provisioned as Power 8) but failed on rhel9, which are Power 9. (nb. there's no link between RHEL version and Power architecture version -- it's just that the older VMs were created as Power 8 and the newer ones as Power 9.) |
https://ci.nodejs.org/job/node-test-commit-aix/58851/nodes=aix72-ppc64/ ran on an IBM Cloud hosted AIX machine, which I think is Power 9. |
So maybe V8's implementation of WASM SIMD is broken on Power 9? |
Spoke to @mcollina -- suggested for now to use non-SIMD on all of AIX and Linux ppc64le ( |
undici 7.16.0 got released, can you create a update undici 7.16.0 PR? |
Being superseded by undici 7.16.0. |
@Uzlopak I ran https://github.com/nodejs/node/actions/runs/17585683821/job/49952913962 and that picked up undici 7.15.0 again: #59827 https://github.com/nodejs/undici/releases is still showing 7.15.0 as the latest undici release. |
The release publication workflow failed: https://github.com/nodejs/undici/actions/runs/17582439038/job/49941839558 |
This is an automated update of undici to 7.15.0.