Skip to content

Conversation

richardlau
Copy link
Member

Original commit message:

Fix scratch registers passed to mtvsrdd

`ra` cannot be r0 as it will be interpreted as Operand(0)

Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Junliang Yan <junyan1@ibm.com>
Cr-Commit-Position: refs/heads/main@{#102388}

Refs: v8/v8@2abc613
Refs: #59605 (comment)
Refs: nodejs/undici#4530


It turned out that nodejs/llparse#73 / undici 7.15.0 uncovered a bug on Power which has been addressed by this cherry-pick. It will unblock re-enabling SIMD in undici on Power (i.e. partially undoing nodejs/undici#4530).

Original commit message:

    Fix scratch registers passed to mtvsrdd

    `ra` cannot be r0 as it will be interpreted as Operand(0)

    Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Junliang Yan <junyan1@ibm.com>
    Cr-Commit-Position: refs/heads/main@{#102388}

Refs: v8/v8@2abc613
@richardlau richardlau added v8 engine Issues and PRs related to the V8 dependency. aix Issues and PRs related to the AIX platform. ppc Issues and PRs related to the Power architecture. labels Oct 9, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Oct 9, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit a1b73fe into nodejs:main Oct 11, 2025
83 of 84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a1b73fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. ppc Issues and PRs related to the Power architecture. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants