lib: remove util.getCallSite #59980
Merged
lib: remove util.getCallSite #59980
+0
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API has been replaced by util.getCallSites(). It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is.
RafaelGSS
added
the
semver-minor
nodejs-github-bot
added
needs-ci
legendecas
approved these changes
Sep 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59980 +/- ##
==========================================
+ Coverage 88.43% 88.45% +0.01%
==========================================
Files 703 703
Lines 207359 207524 +165
Branches 39985 40011 +26
==========================================
+ Hits 183386 183572 +186
+ Misses 15984 15938 -46
- Partials 7989 8014 +25
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 23, 2025
legendecas
added
the
author ready
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/59980 ✔ Done loading data for nodejs/node/pull/59980 ----------------------------------- PR info ------------------------------------ Title lib: remove util.getCallSite (#59980) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:drop-get-call-site-api -> nodejs:main Labels util, semver-minor, author ready, needs-ci Commits 2 - lib: remove util.getCallSite - fixup! lib: remove util.getCallSite Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/59980 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59980 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: remove util.getCallSite ⚠ - fixup! lib: remove util.getCallSite ℹ This PR was created on Mon, 22 Sep 2025 23:11:16 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/59980#pullrequestreview-3255563043 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/59980#pullrequestreview-3258095389 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-10-06T13:52:51Z: https://ci.nodejs.org/job/node-test-pull-request/69582/ - Querying data for job/node-test-pull-request/69582/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18288699054 |
RafaelGSS
removed
the
commit-queue-failed
|
Please, approve again after the fixup. |
legendecas
approved these changes
Oct 6, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b757a8f |
RafaelGSS
added a commit
that referenced
this pull request
Oct 7, 2025
This API has been replaced by util.getCallSites(). It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is. PR-URL: #59980 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Oct 8, 2025
Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Oct 8, 2025
Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API has been replaced by util.getCallSites().
It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is.