doc: improve code snippet alternative of url.parse() using WHATWG URL #60209
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
anonrig
approved these changes
Oct 11, 2025
aduh95
approved these changes
Oct 11, 2025
aduh95
added
author ready
cjihrig
approved these changes
Oct 11, 2025
lpinca
approved these changes
Oct 11, 2025
mertcanaltin
approved these changes
Oct 11, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1cd16e5 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to a comment #59736 (comment) that pointed out the existing code snippet is not safe since the
req.urlcan start with a double slash which would cause the hostname to be replaced.