Skip to content

doc: improve code snippet alternative of url.parse() using WHATWG URL #60209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
+2 −2
Merged

doc: improve code snippet alternative of url.parse() using WHATWG URL #60209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1853,7 +1853,7 @@ input. CVEs are not issued for `url.parse()` vulnerabilities. Use the
function getURL(req) {
const proto = req.headers['x-forwarded-proto'] || 'https';
const host = req.headers['x-forwarded-host'] || req.headers.host || 'example.com';
return new URL(req.url || '/', `${proto}://${host}`);
return new URL(`${proto}://${host}${req.url || '/'}`);
}
```

Expand All @@ -1863,7 +1863,7 @@ use the example below:

```js
function getURL(req) {
return new URL(req.url || '/', 'https://example.com');
return new URL(`https://example.com${req.url || '/'}`);
}
```

Expand Down
Loading