Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix -Wunused-variable compiler warning #6129

Merged
merged 1 commit into from
Apr 9, 2016
Merged

src: fix -Wunused-variable compiler warning #6129

merged 1 commit into from
Apr 9, 2016

Conversation

bnoordhuis
Copy link
Member

No description provided.

@evanlucas
Copy link
Contributor

LGTM

@bnoordhuis
src: fix -Wunused-variable compiler warning
f938ef7 
Introduced in commit 7d8882b, "handle_wrap: expose an `isRefed()` check
to JS".

PR-URL: nodejs#6129
Reviewed-By: Evan Lucas <evanlucas@me.com>
@bnoordhuis bnoordhuis closed this Apr 9, 2016
@bnoordhuis bnoordhuis deleted the fix-unused-variable-warning branch April 9, 2016 11:07
@bnoordhuis bnoordhuis merged commit f938ef7 into nodejs:master Apr 9, 2016
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@bnoordhuis lts?

@bnoordhuis
Copy link
Member Author

No. It was introduced by #5834 which is marked dont-land-on-v4.x. I'll add the labels here as well.

@MylesBorins
Copy link
Contributor

@bnoordhuis thanks

This was referenced May 17, 2016
Merged
Merged
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bnoordhuis @evanlucas
src: fix -Wunused-variable compiler warning
316871f 
Introduced in commit 7d8882b, "handle_wrap: expose an `isRefed()` check
to JS".

PR-URL: #6129
Reviewed-By: Evan Lucas <evanlucas@me.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
@Fishrock123 Fishrock123 mentioned this pull request May 19, 2016
Closed
@MylesBorins
Copy link
Contributor

@Fishrock123 why was the dont-land label removed for v4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnoordhuis @evanlucas @MylesBorins @Fishrock123