process: fix incorrect usage of assert.fail() #6211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module.
Trott
added
process
| @@ -13,7 +13,7 @@ function setupPromises(scheduleMicrotasks) { | |||
| else if (event === promiseRejectEvent.handled) | |||
| rejectionHandled(promise); | |||
| else | |||
| require('assert').fail('unexpected PromiseRejectEvent'); | |||
| require('assert').fail(null, null, 'unexpected PromiseRejectEvent'); | |||
There was a problem hiding this comment.
Why is the require() here instead of at the top of the file?
There was a problem hiding this comment.
To avoid the hit of require('assert') in the common case.
|
1 nit, but otherwise LGTM |
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 18, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in b7f4b1b |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: nodejs#6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: #6211 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
this file does not exist on v4.x @Trott up to you if you want to figure out where the code lives |
|
@thealphanerd I think v4.x will somehow manage to get by without this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
process, promises
Description of change
The message argument for
assert.fail()is the third argument, not thefirst. Correct minor misuse in internal module.