Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.11.0 proposal #6321

Closed
wants to merge 1,219 commits into from
Closed

V5.11.0 proposal #6321

wants to merge 1,219 commits into from

Conversation

MylesBorins
Copy link
Contributor

2016-04-20, Version 5.11.0 (Stable), @thealphanerd

Notable Changes

  • Buffer:
    • Buffer.prototype.compare can now compare sub-ranges of two Buffers. (James M Snell) #5880
  • deps:
    • update to http-parser 2.7.0 (Fedor Indutny) #6279
    • update ESLint to 2.7.0 (silverwind) #6132
  • net:
    • adds support for passing DNS lookup hints to createConnection() (Colin Ihrig) #6000
  • node:
    • Make the builtin libraries available for the --eval and --print CLI options (Anna Henningsen) #6207
  • npm:
    • upgrade npm to 3.8.6 (Kat Marchán) #6153
  • repl:
    • Pressing enter in the repl will repeat the last command by default if no input has been received. This behaviour was in node previously and was not removed intentionally. (Rich Trott) #6090
  • src:
    • add SIGINFO to supported signals (James Reggio) #6093
  • streams:
    • Fix a regression that caused by net streams requesting multiple chunks synchronously when combined with cork/uncork (Matteo Collina) #6164
  • zlib:
    • The flushing flag is now configurable allowing for decompression of partial data (Anna Henningsen) #6069

Commits

  • [14fcb1dded] - assert: respect assert.doesNotThrow message. (Ilya Shaisultanov) #2407
  • [332f7382bb] - benchmark: add module loader benchmark parameter (Brian White) #5172
  • [473f086a94] - (SEMVER-MINOR) buffer: add Buffer.prototype.compare by offset (James M Snell) #5880
  • [d44540f5af] - buffer: standardize array index check (Trevor Norris) #6084
  • [bd12d72e0c] - build: fix make tar-headers for Linux (Gibson Fahnestock) #5978
  • [3c8d404a82] - build: allow test-ci to run tests in parallel (Johan Bergström) #6208
  • [a5f8d0c6ef] - build: remove -f{data,function}-sections flags (Ben Noordhuis) #6077
  • [adfb1a4bb0] - child_process: add nullptr checks after allocs (Anna Henningsen) #6256
  • [1fb40524ee] - (SEMVER-MINOR) debugger: run last command on presssing enter (Rich Trott) #6090
  • [5305831184] - deps: update to http-parser 2.7.0 (Fedor Indutny) #6279
  • [8ae200c768] - deps: floating fix for npm's test-node script (Kat Marchán) #6153
  • [e3e544eb96] - deps: upgrade npm to 3.8.6 (Kat Marchán) #6153
  • [a7104e4516] - deps: cherry-pick 1383d00 from v8 upstream (Fedor Indutny) #6179
  • [632e6b9617] - deps: backport 125ac66 from v8 upstream (Myles Borins) #6086
  • [4b8376986a] - doc: git mv to .md (Robert Jefe Lindstaedt) #4747
  • [e6f4a175d4] - doc: add full example for zlib.flush() (Anna Henningsen) #6172
  • [50f3f10ce6] - doc: note that zlib.flush acts after pending writes (Anna Henningsen) #6172
  • [985685d170] - doc: fix broken references (Alexander Gromnitsky) #6100
  • [d66d883a85] - doc: path.format provide more examples (John Eversole) #5838
  • [dc1552e321] - doc: replace functions with arrow functions (abouthiroppy) #6203
  • [fa04dfc307] - doc: DCO anchor that doesn't change (William Kapke) #6257
  • [b49a5b33b5] - doc: fix http response event, Agent#getName (Matthew Douglass) #5993
  • [3b00d7a5b1] - doc: document intention and dangers of fs module Buffer API (Nikolai Vavilov) #6020
  • [3bc31526bb] - doc: explain differences in console.assert between node and browsers (James M Snell) #6169
  • [3f73502662] - doc: native module reloading is not supported (Bryan English) #6168
  • [5f9c8297f1] - doc: clarify fs.watch() and inodes on linux, os x (Joran Dirk Greef) #6099
  • [f3c0b78ae4] - doc: add domain postmortem (Trevor Norris) #6159
  • [a91834e743] - doc: add stefanmb to collaborators (Stefan Budeanu) #6227
  • [117348d082] - doc: add iWuzHere to collaborators (Imran Iqbal) #6226
  • [a1c46b63e8] - doc: add santigimeno to collaborators (Santiago Gimeno) #6225
  • [976e4bb3da] - doc: add addaleax to collaborators (Anna Henningsen) #6224
  • [4fa949ef75] - doc: fix incorrect references in buffer docs (Amery) #6194
  • [b26fea1595] - doc: add copy about how to curl SHA256.txt (Myles Borins) #6120
  • [daaad47099] - doc: clarification for maxBuffer and Unicode output (James M Snell) #6030
  • [5e6915f374] - doc: describe child.kill() pitfalls on linux (Robert Jefe Lindstaedt) #2098
  • [a40d0e8f9d] - doc: fix scrolling on iOS devices (Luigi Pinca) #5878
  • [a81fca4f99] - doc: add topic - event loop, timers, nextTick() (Jeff Harris) #4936
  • [440d1172fd] - doc: add example using algorithms not directly exposed (Brad Hill) #6108
  • [96ad5c5303] - doc: update openssl LICENSE using license-builder.sh (Steven R. Loomis) #6065
  • [07829b0bc9] - doc: simple doc typo fix (Brendon Pierson) #6041
  • [bc0ee06226] - doc: note about Android support (Rich Trott) #6040
  • [60a73a2ed2] - doc: fix a typo in 5.10.1's changelog (Vladimir Varankin) #6076
  • [b57be92c1b] - gitignore: adding .vs/ directory to .gitignore (Mike Kaufman) #6070
  • [6e891c7ad4] - gitignore: ignore VS 2015 *.VC.opendb files (Mike Kaufman) #6070
  • [abd101be1a] - http: disallow sending obviously invalid status codes (Brian White) #6291
  • [16b23b2c28] - http: skip body and next message of CONNECT res (Fedor Indutny) #6279
  • [a259ee4018] - http: unref socket timer on parser execute (Fedor Indutny) #6286
  • [d4abca5b27] - lib: remove bootstrap global context indirection (Jeremiah Senkpiel) #5881
  • [c8783aff21] - lib,test,tools: alignment on variable assignments (Rich Trott) #6242
  • [d5d4f194f1] - net: replace defineGetter with defineProperty (Fedor Indutny) #6284
  • [6d9c0c9aa7] - (SEMVER-MINOR) net: support DNS hints in createConnection() (Colin Ihrig) #6000
  • [457f24f19c] - (SEMVER-MINOR) node: make builtin libs available for --eval (Anna Henningsen) #6207
  • [fc89d17656] - path: fixing a test that breaks on some machines. (Mike Kaufman) #6067
  • [1d408099b7] - process: fix incorrect usage of assert.fail() (Rich Trott) #6211
  • [07c9f981d6] - (SEMVER-MINOR) repl: keep the built-in modules non-enumerable (Anna Henningsen) #6207
  • [5382deaa18] - repl: don’t complete non-simple expressions (Anna Henningsen) #6192
  • [2254f1a175] - repl: refactor repl.js (Rich Trott) #6071
  • [7d54d85269] - (SEMVER-MINOR) src: add SIGINFO to supported signals (James Reggio) #6093
  • [fbc99ba4f1] - src: add missing 'inline' keywords (Ben Noordhuis) #6056
  • [20bb92f5c8] - src: use size_t for http parser array size fields (Ben Noordhuis) #5969
  • [2fd8be2dbe] - src: replace ARRAY_SIZE with typesafe arraysize (Ben Noordhuis) #5969
  • [4392b4aee0] - stream: Fix readableState.awaitDrain mechanism (Anna Henningsen) #6023
  • [20dcdd365b] - stream_base: expose bytesRead getter (Fedor Indutny) #6284
  • [f69416c06e] - streams: support unlimited synchronous cork/uncork cycles (Matteo Collina) #6164
  • [4bfed26d1a] - test: add zlib close-after-error regression test (Anna Henningsen) #6270
  • [99d0a61441] - test: move more tests from sequential to parallel (Santiago Gimeno) #6187
  • [96be986a77] - test: assert - fixed error messages to match the tests (surya panikkal) #6241
  • [4e4efb756e] - test: add test for responses to HTTP CONNECT req (Josh Leder) #6279
  • [5b42ef5dfe] - test: move debugger tests to sequential (Rich Trott) #6205
  • [9856b804e9] - test: move some test from sequential to parallel (Santiago Gimeno) #6087
  • [1d130d0203] - test: move the debugger tests back to parallel (Santiago Gimeno) #6246
  • [c0e9c94868] - test: fix issues for ESLint 2.7.0 (silverwind) #6132
  • [056a258173] - test: fix flaky test-http-set-timeout-server (Santiago Gimeno) #6248
  • [be993fcf6c] - test: fix test-net-settimeout flakiness (Santiago Gimeno) #6166
  • [a38b614ae9] - test: fix flaky test-child-process-fork-net (Rich Trott) #6138
  • [476535cc0e] - test: fix flaky test-http-client-abort (Rich Trott) #6124
  • [6bb7999bd6] - test: refactor test-file-write-stream3 (Rich Trott) #6050
  • [a27e95231e] - test: enforce strict mode for test-domain-crypto (Rich Trott) #6047
  • [8da4bad1c9] - test: fix pummel test failures (Rich Trott) #6012
  • [edd8a15508] - test,repl: use deepStrictEqual for false-y values (Jeremiah Senkpiel) #6196
  • [48ecc0b6b5] - test,tools: enable linting for undefined vars (Rich Trott) #6255
  • [d809c84bf8] - test,vm: enable strict mode for vm tests (Rich Trott) #6209
  • [4a1dfdcc0f] - tools: lint rule for assert.fail() (Rich Trott) #6261
  • [fff6a84da5] - tools: enable linting for v8_prof_processor.js (Rich Trott) #6262
  • [a2ca347803] - tools: move message listener to worker objects (Brian White) #6212
  • [f201b01bf7] - tools: improve js linter (Brian White) #5638
  • [be070d775f] - tools: lint for alignment of variable assignments (Rich Trott) #6242
  • [d9b8758f47] - tools: update ESLint to 2.7.0 (silverwind) #6132
  • [a6056c453e] - tools: fix license-builder.sh again for ICU (Steven R. Loomis) #6068
  • [fabc33a075] - tools: remove simplejson dependency (Sakthipriyan Vairamani) #6101
  • [d516412cd5] - tools,doc: parse types in braces everywhere (Alexander Makarenko) #5329
  • [69eb4a6834] - tools,doc: fix json for grouped optional params (firedfox) #5977
  • [a2dd848764] - tools,doc: fix incomplete json produced by doctool (firedfox) #5966
  • [bad006f2e1] - zlib: fix use after null when calling .close (James Lal) #5982
  • [83bc0a2ac9] - (SEMVER-MINOR) zlib: Make the finish flush flag configurable (Anna Henningsen) #6069
  • [2c23e14d5d] - (SEMVER-MINOR) zlib: detect gzip files when using unzip* (Anna Henningsen) #5884
  • [61167c3e23] - zlib: fix gzip member head/buffer boundary issue (Anna Henningsen) #5973

svozza and others added 30 commits March 16, 2016 13:06
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: #5672
R-URL: #5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
PR-URL: #3726
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The current documentation for writable.write only specifies that the
callback is called "once the data has been fully handled".  It is
ambiguous whether this means "successfully handled" and, if so,
whether the callback is called if the data can not be successfully
handled (i.e. an error occurs).

The ambiguity is not only in the documentation.  The stream class
implementations differ on this point.  stream.Writable invokes the
callback with any errors that occur during parameter checking or
during calls to _write.  However, not all classes return all errors
to _write. zlib.Zlib does pass argument and state errors to the
_write (_transform) callback, but does not pass data errors.
http.OutgoingMessage passes argument type errors and some other types
of errors, but not all.

This inconsistency is behind issue #1746 and, I suspect, other issues
in client code which passes a callback to write.

This commit takes no position on whether the callback error behavior
should changed, but simply attempts to document the current behavior
in a way that is open to changes so that users are not caught by
surprise.

PR-URL: #4810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in
opensslconf.h

Fixes: nodejs/Release#85
PR-URL: #5630
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
The current documentation for Convenience Methods specifies that
the first argument can be either
`string or buffer`, `string` or `raw Buffer`.
This commit replaces all these instances with `Buffer or string`.

PR-URL: #5685
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
`isIPv4` and `isIPv6` are implemented on top of `isIP`, which in turn
checks the sting for being both IPv4 and IPv6, which can be inefficient
in some scenarios. This commit makes them use `uv_inet_pton` directly
instead.

PR-URL: #5478
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
According to the spec gzipped archives can contain more than one
compressed member. Previously Node's gzip implementation would only
unzip the first member and throw away the rest of the compressed data.
Issue #4306 is an example of this occurring in daily use.

Fixes: #4306
PR-URL: #5120
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Add the proposed Testing WG. WORKING_GROUPS.md indicates that opening
a pull request to that file is the way to request that a charter be
ratified by the TC. So, that's what this is.

The charter document is currently:
https://github.com/nodejs/testing/blob/master/Charter.md

PR-URL: #5461
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
If both -i and -e flags are specified, do not ignore the -i. Instead,
launch the interactive REPL and start by evaluating the passed string.

Fixes: #1197
PR-URL: #5655
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
`Console` constructor checks that `stdout.write()` is a function but
does not do an equivalent check for `stderr.write()`. If `stderr` is not
specified in the constructor, then `stderr` is set to be `stdout`.
However, if `stderr` is specified, but `stderr.write()` is not a
function, then an exception is not thrown until `console.error()` is
called.

This change adds the same check for 'stderr' in the constructor that is
there for `stdout`. If `stderr` fails the check, then a `TypeError` is
thrown.

Took the opportunity to copyedit the `console` doc a little too.

PR-URL: #5635
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Original commit message:

      Export BreakEvent and CompileEvent

      R=yangguo@chromium.org

      Review URL: https://codereview.chromium.org/1477233002

      Cr-Commit-Position: refs/heads/master@{#32861}

PR-URL: #4231
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Notable changes:

* **contextify**: Fixed a memory consumption issue related to heavy use
of `vm.createContext` and `vm.runInNewContext`. (Ali Ijaz Sheikh)
#5392
* **governance**: The following members have been added as
collaborators:
  - Andreas Madsen (@AndreasMadsen)
  - Benjamin Gruenbaum (@benjamingr)
  - Claudio Rodriguez (@claudiorodriguez)
  - Glen Keane (@thekemkid)
  - Jeremy Whitlock (@whitlockjc)
  - Matt Loring (@matthewloring)
  - Phillip Johnsen (@phillipj)
* **lib**: copy arguments object instead of leaking it (Nathan Woltman)
#4361
* **src**: allow combination of -i and -e cli flags (Rich Trott)
#5655
* **v8**: backport fb4ccae from v8 upstream (Vladimir Krivosheev) #4231
  -  breakout events from v8 to offer better support for external
     debuggers
* **zlib**: add support for concatenated members (Kári Tristan
Helgason) #5120

PR-URL: #5702
When the previous set of changes (bfff07b) it was possible to have the
context get garbage collected while sandbox was still live. We need to
tie the lifetime of the context to the lifetime of the sandbox.

This is a backport of #5786 to v5.x.

Ref: #5786
PR-URL: #5800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5673
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

Conflicts:
	lib/path.js
Uses better troff formatting.
Removes v8 options from the man page.

Also edits `node -h` in node.cc slightly.

PR-URL: #5497
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Conflicts:
	doc/node.1
Fixes: https:github.com//issues/5682
PR-URL: #5736
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Do not call the linkManPages if the tok type is code

Fixes: #5686
PR-URL: #5721
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5688
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #2305
The format of certain code comments in the `path` documentation results
in the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.

PR-URL: #5670
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

Conflicts:
	doc/api/path.markdown
SSL sockets leak whenever keep alive is enabled, ca option is set in
the global agent, and requests are sent without the ca property.
In the following case at Agent.prototype.createSocket a socket will
be created with a hashtag name that includes data from the global
agents’ ca property.

On subsequent requests at Agent.prototype.addRequest we do not find
the free socket, because the hashtag name generated there does not
take into account the global agents’ ca property, thus creating a new
socket and leaving the first socket to timeout. closes: #5699

PR-URL: #5713
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Changes the multiline return example commments in querystring
which have the example out-of-comment, into single comment
lines to remain consistent with other docs.

PR-URL: #5705
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #5500
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5765
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jamesreggio and others added 23 commits April 20, 2016 16:52
Though not a POSIX signal, SIGINFO is supported by BSD systems
(including Mac OS X) and is amongst the few signals that can be
triggered in a terminal via a simple key combination (CTRL-T).

On Linux, SIGINFO is an alias for SIGPWR; hence the defensive
conditionals in src/node.cc.

PR-URL: #6093
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Adds `2` as a return value of `on_headers_complete`, this mode will be
used to fix handling responses to `CONNECT` requests.

See: #6198
PR-URL: #6279
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
When handling a response to `CONNECT` request - skip message body
and do not attempt to parse the next message. `CONNECT` requests are
used in similar sense to HTTP Upgrade.

Fix: #6198
PR-URL: #6279
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
See: #6198
PR-URL: #6279
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
The tar-headers target tries to find and delete links in the
tar folder, which fails as no links are found. Use rm -f to
avoid this.

Remove the config.gypi dependency, as the target runs configure
itself.

PR-URL: #5978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
`lib/internal/v8_prof_processor.js` was being excluded from linting, but
the only lint issue it has is that it cannot run in strict mode. Disable
the `strict` rule with a comment and remove the file from
`.eslintignore`.

PR-URL: #6262
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
`assert.fail()` is often mistakenly used with a single argument even in
Node.js core. (See fixes to previous instances in
b7f4b1b,
28e9a02. and
676e618.)

This commit adds a linting rule to identify instances of this issue.

PR-URL: #6261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The test directory had linting for undefined variables disabled. It is
enabled everywhere else in the code base. Let's disable the fule for
individual lines in the handful of tests that use undefined variables.

PR-URL: #6255
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #6241
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Add `CHECK_NE(·, nullptr)` after allocations made when
spawning child processes.

PR-URL: #6256
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Only `test-stdin-from-file.js` has been modified so that the `stdin.txt`
is written in a temp directory instead of the `fixtures` directory.

PR-URL: #6187
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6090
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fixes: #2895
Detect whether a gzip file is being passed to `unzip*` by
testing the first bytes for the gzip magic bytes, and setting
the decompression mode to `GUNZIP` or `INFLATE` according to
the result.

This enables gzip-only features like multi-member support
to be used together with the `unzip*` autodetection support
and thereby makes `gunzip*` and `unzip*` return identical
results for gzip input again.

Add a simple test for checking that features specific to
`zlib.gunzip`, notably support for multiple members, also work
when using `zlib.unzip`.

PR-URL: #5884
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Up to now, `Z_FINISH` was always the flushing flag that was used
for the last chunk of input data. This patch makes this choice
configurable so that advanced users can perform e.g. decompression of
partial data using `Z_SYNC_FLUSH`, if that suits their needs.

Add tests to make sure that an error is thrown upon encountering
invalid `flush` or `finishFlush` flags.

Fixes: #5761
PR-URL: #6069
Reviewed-By: James M Snell <jasnell@gmail.com>
Make the builtin libraries available for the `--eval` and
`--print` CLI options, using the same mechanism that the
REPL uses.

This renders workarounds like `node -e 'require("fs").doStuff()'`
unnecessary.

As part of this, the list of builtin modules and the code for
adding the corresponding properties to the target context is moved
to `internal/module.js`, and the previously missing `repl` entry
is added.

PR-URL: #6207
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make sure that the built-in modules in the repl stay non-enumerable.
Previously, they would pop up as enumerable properties of the global
object after having been accessed for the first time.

PR-URL: #6207
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Describe that `zlib.flush()` may wait for pending writes and
until output is being read from the stream.

Fixes: #3782
PR-URL: #6172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Add a full example using `zlib.flush()` for the common use
case of writing partial compressed HTTP output to the client.

PR-URL: #6172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
* doc: rename .markdown references in content
* doc: rename to .md in tools
* doc: rename to .md in CONTRIBUTING.md

PR-URL: #4747
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: techjeffharris
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #6291
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add a regression test based on the report in
#6034.

PR-URL: #6270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Buffer:
  * Buffer.prototype.compare can now compare sub-ranges of two Buffers
   (James M Snell) #5880

deps:
  * update to http-parser 2.7.0
    (Fedor Indutny) #6279
  * update ESLint to 2.7.0
    (silverwind) #6132

net:
  * adds support for passing DNS lookup hints to createConnection()
    (Colin Ihrig) #6000

node:
  * Make the builtin libraries available for the --eval and --print
    CLI options
    (Anna Henningsen) #6207

npm:
  * upgrade npm to 3.8.6
    (Kat Marchán) #6153

repl:
  * Pressing enter in the repl will repeat the last command by default
    if no input has been received. This behaviour was in node
    previously and was not removed intentionally.
    (Rich Trott) #6090

src:
  * add SIGINFO to supported signals
    (James Reggio) #6093

streams:
  * Fix a regression that caused by net streams requesting multiple
    chunks synchronously when combined with cork/uncork
    (Matteo Collina) #6164

zlib:
  * The flushing flag is now configurable allowing for decompression
    of partial data
    (Anna Henningsen) #6069
@MylesBorins MylesBorins self-assigned this Apr 21, 2016
@MylesBorins MylesBorins added meta Issues and PRs related to the general management of the project. v5.x labels Apr 21, 2016
@MylesBorins
Copy link
Contributor Author

uggggghhhh

@jasnell
Copy link
Member

jasnell commented Apr 21, 2016

LGTM if CI is green

@MylesBorins MylesBorins removed their assignment Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.