test: move the debugger tests back to parallel #6246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the debugger with `--port=common.PORT` to avoid the use of the same port.
2 tasks
|
LGTM. CI looks good (known flaky only failure) and |
|
LGTM |
1 similar comment
|
LGTM |
santigimeno
added a commit
to santigimeno/node
that referenced
this pull request
Apr 18, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: nodejs#6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks for the reviews. Landed in b95160d |
|
👍 Btw, your |
|
No it was not :(. I was wondering if I should fix it |
|
I don’t think that matters much, I mean, the |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
|
@nodejs/testing is this something we want in lts? |
|
I would say so. It should land after #6205 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
this should land with 00b2219 |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: nodejs#6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
santigimeno
added a commit
to santigimeno/node
that referenced
this pull request
May 18, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: nodejs#6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2 tasks
|
I'm inclined to suggest that we label this as |
|
Agreed. Labeling as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Run the debugger with
--port=common.PORTto avoid the use of the sameport.
/cc @nodejs/testing