test: assert - fixed assert error messages to match the tests being run #6241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
assert
suryagh
changed the title
|
The build failure was due to net connection timeout in an unrelated Is the intermittent connection timeout a known issue with the Jenkins build? |
|
@Trott how did you trigger the build? Does it need special access to |
|
LGTM |
|
@suryagh ... the failure is a known flaky test. |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in aa4d2ae |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
PR-URL: #6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
PR-URL: nodejs#6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
PR-URL: #6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 17, 2016
PR-URL: #6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
PR-URL: #6241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Few of the assert error messages for the
asserttests were not matching the tests in question. Fixed the strings to better reflect the corresponding tests.