-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add zlib close-after-error regression test #6270
Conversation
Add a regression test based on the report in nodejs#6034.
ba573bb
to
96f04d6
Compare
LGTM. CI is green. |
LGTM |
1 similar comment
LGTM |
Wanna go ahead and land this one @addaleax ? :-) |
@jasnell Sure, I just didn’t really see any reason not to wait the recommended time so that everyone can point out the gazillion style nits I usually produce 😉 |
Landed in f8e507e. |
;-) no style nits in this one! For really small commits like this (tests, docs, lints, etc), if there's obvious consensus then it's usually ok to land a bit sooner than the 48 hours. |
@thealphanerd Should be included together with #5982, yes. |
thanks for the swift response, and for all the awesome work you've been putting in lately!!! |
Add a regression test based on the report in nodejs#6034. PR-URL: nodejs#6270 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
zlib, test
Description of change
Add a regression test based on the report in #6034. The bug itself has been fixed in #5982.