-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to V8 4.9.385.35 #6077
Conversation
LGTM |
PR-URL: nodejs#6077 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
We don't link with `--gc-sections` because it's unreliable with some toolchains, so all these flags do is make the compiler generate slightly worse code. Drop them. Refs: nodejs#6056 PR-URL: nodejs#6077 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis safe to assume this does not make sense for lts? |
71544c5 could be cherry-picked but it's not critical. |
@bnoordhuis this is not landing cleanly on |
@thealphanerd When you say 'this', do you mean the V8 upgrade or the other commit? |
The v8 upgrade. The other commit landed without problem |
The V8 upgrade shouldn't go into v4 or v5. There are perhaps some individual fixes we could cherry-pick. |
@bnoordhuis if you think any parts of this should be backported to v4.x-staging could you please open a PR |
R=@nodejs/v8
I threw in the
build: remove -f{data,function}-sections flags
commit because otherwise I'd have to rebuild twice. :-) See #6056 for background.CI: https://ci.nodejs.org/job/node-test-pull-request/2173/