Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: ignore VS 2015 *.VC.opendb files #6070

Closed

Conversation

mike-kaufman
Copy link

  • the commit message follows commit guidelines
Affected core subsystem(s)

gitignore

Description of change

*.VC.opendb files are created by VS 2015 and should be ignored by git.

These files are created by VS 2015 and should be ignored by git.
@jbergstroem
Copy link
Member

Can't confirm whether they are created or not but LGTM.

@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Apr 6, 2016
@Fishrock123
Copy link
Contributor

As a note, this should still be ignored by people's global gitignore.

@Trott
Copy link
Member

Trott commented Apr 6, 2016

As a note, this should still be ignored by people's global gitignore.

That ship may have already sailed. If I'm not mistaken, there are already 18 entries in the .gitignore file that seem to be specific to Visual Studio. This would be the 19th.

@Fishrock123
Copy link
Contributor

Not really, this is just generic git advice. We can merge this, it doesn't matter. People should still do it anyways to avoid problems in any other project.

@Trott
Copy link
Member

Trott commented Apr 6, 2016

Not really, this is just generic git advice.

Oh, yes, I see what you're saying now. I thought you meant it should be in people's personal global config instead as opposed to in addition.

@Trott
Copy link
Member

Trott commented Apr 12, 2016

LGTM

This is created by vs 2015 for user & machine-specific files and should
be ignored by git.
@mike-kaufman
Copy link
Author

FYI I piled another small change into this PR - namely adding .vs/ directory to .gitignore. This is used by 2015 to store some user & machine specific files.

@Trott
Copy link
Member

Trott commented Apr 14, 2016

Still LGTM

@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 18, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 18, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

Landed in 64d36be and 61886fa

@jasnell jasnell closed this Apr 18, 2016
@Fishrock123
Copy link
Contributor

Please squash this kind of thing.

MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: nodejs#6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: nodejs#6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants