doc: change references to Stable to Current #6318

MylesBorins · 2016-04-21T00:08:30Z

Checklist

Update website
- Rename 'Stable' release to 'Current' nodejs.org#672
update redirect for build
- www: redirect from '/<lang>/downloads/stable' to '/<lang>/downloads/current' build#399
Update LTS repo copy
- doc: change stable to current Release#98
Update LTS Graphic
- Updated LTS image. Release#97
Update https://github.com/rvagg/changelog-maker
- Rename Node.js "Stable" releases to "Current" changelog-maker#38

Notes

With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

ref: nodejs/nodejs.org#669

jasnell · 2016-04-21T00:12:01Z

LGTM

MylesBorins · 2016-04-21T00:14:23Z

/cc @nodejs/ctc

evanlucas · 2016-04-21T00:15:38Z

I think changelog-maker will need an update too if I am remembering correctly

MylesBorins · 2016-04-21T00:17:01Z

From my comment in nodejs/nodejs.org#669

We will also have to update the site, I think it might make sense for @fhemberger to handle that or at least someone more familiar with the code base as the word "stable" is used not only in the copy, but in css selectors and hard coded within the tests. That being said I think we should get 100% sign off before that work is done.

As far as I can tell there is nothing that needs to be updated in /download, but perhaps someone from @nodejs/build can verify that for me.

We will also have to update the copy in https://github.com/nodejs/lts

Turns out there is only a single reference to stable, but we'll need to also update the graphic (do you know where that lives @mikeal?). If I can get a copy of a psd or illustrator file I can update that

Those are just the references I knew off the top of my head, I'll do a more in depth search after we get sign off.

edit: I'm making a checklist in the top comment. Other collaborators please feel free to edit my comment and add more to the list

MylesBorins · 2016-04-21T00:20:55Z

@evanlucas afaik changelog maker is agnostic to release lines. The title of the changelog is always made manually afaik

evanlucas · 2016-04-21T00:22:07Z

It breaks https://github.com/rvagg/changelog-maker/blob/master/groups.js#L19 (the --filter-release flag)

MylesBorins · 2016-04-21T06:20:18Z

PR has come in at a first pass to updating the website nodejs/nodejs.org#672

fhemberger · 2016-04-21T06:28:48Z

PR for changelog-maker: nodejs/changelog-maker#38

Fishrock123 · 2016-04-23T20:19:42Z

With v6 we plan to rename the Stable release line to Current.

We do?

MylesBorins · 2016-04-23T20:24:46Z

There was another thread where there seemed to be consensus. Tbqh the language is written for the commit if it lands. I copied it over to the PR. I should have likely switched to more democratic language in the issue.

Fishrock123 · 2016-04-23T20:30:17Z

I have voiced my concerns at nodejs/nodejs.org#669 (comment)

We need to make sure we give the large changes more time and not just cram them in before breaking releases...

Speaking of which, this doesn't actually have to be done in a breaking release at all. I'd rather everyone be good with it and change it afterwards than not.

evanlucas · 2016-04-24T00:13:00Z

This probably needs CTC approval?

Fishrock123 · 2016-04-24T00:27:16Z

@evanlucas at the very least, I think.

Fishrock123 · 2016-04-24T00:30:24Z

Thinking about this more in nodejs/nodejs.org#669 (comment)

Ok. I definitely think we should really take this past evangelism/marketing. I'm afraid a shift without warning may rub off on downstream customers badly and people may be increasingly hesitant about things if we do it with no prior publicly communicated indicator.

jasnell · 2016-04-24T00:34:06Z

Getting ctc review and encouraging input from the collaborators is exactly why this PR was opened :-)

Trott · 2016-04-24T00:39:29Z

@Fishrock123 wrote:

I definitely think we should really take this past evangelism/marketing.

@nodejs/evangelism @nodejs/website

mikeal · 2016-04-24T00:47:30Z

CTC should weigh in but it would be good to have the website change ready
for the v6 release.

On Saturday, April 23, 2016, Rich Trott notifications@github.com wrote:

@Fishrock123 https://github.com/Fishrock123 wrote:

I definitely think we should really take this past evangelism/marketing.

@nodejs/evangelism https://github.com/orgs/nodejs/teams/evangelism
@nodejs/website https://github.com/orgs/nodejs/teams/website

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6318 (comment)

jasnell · 2016-04-25T16:59:17Z

Need to know today if we're going to use the new naming for v6

ChALkeR · 2016-04-25T18:18:34Z

doc/releases.md

@@ -187,7 +187,7 @@ Jenkins collects the artifacts from the builds, allowing you to download and ins

 Once you have produced builds that you're happy with, create a new tag. By waiting until this stage to create tags, you can discard a proposed release if something goes wrong or additional commits are required. Once you have created a tag and pushed it to GitHub, you ***should not*** delete and re-tag. If you make a mistake after tagging then you'll have to version-bump and start again and count that tag/version as lost.

-Tag summaries have a predictable format, look at a recent tag to see, `git tag -v v5.3.0`. The message should look something like `2015-12-16 Node.js v5.3.0 (Stable) Release`.
+Tag summaries have a predictable format, look at a recent tag to see, `git tag -v v6.0.0`. The message should look something like `2016-4-26 Node.js v6.0.0 (Current) Release`.


2016-04-26 (note the 0).

ChALkeR · 2016-04-25T18:28:18Z

This does LGTM (with a nit).

The only concern that I have here is that we would actually have LTS, Current, Maintenance, and Stable, at least in the changelog. We should make sure that the renaming is clear and that people can look up what did Stable mean. Perhaps we could add a line that Current was previsously named as Stable to the Readme?

evanlucas · 2016-04-25T20:19:33Z

LGTM with @ChALkeR's nit addressed

fhemberger · 2016-04-26T09:39:26Z

PR for download page redirect: nodejs/build#399

@thealphanerd Can you please update the original post?

jasnell · 2016-04-26T15:55:28Z

@nodejs/ctc ... I need a final Go / No Go on making this change in this release. @Fishrock123 has voiced an objection. Need to know what to use for this release.

fhemberger · 2016-04-26T15:58:51Z

@jasnell Website has already been updated: nodejs/nodejs.org#672 (comment)

jasnell · 2016-04-26T16:00:48Z

Ok... that settles it then lol. @thealphanerd can you make sure this PR is up to date and get it landed?

With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. ref: nodejs/nodejs.org#669

With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

jasnell · 2016-04-26T16:53:53Z

Landed in 29a6c7c

With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

With the change of release names from 'Stable' to 'Current' (introduced with Node.js v6), the old download page needs to be redirected. PR-URL: #399 Refs: nodejs/node#6318 Refs: nodejs/nodejs.org#672 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: nodejs/nodejs.org#669 PR-URL: #6318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Apr 21, 2016

MylesBorins added this to the 6.0.0 milestone Apr 21, 2016

Fishrock123 modified the milestone: 6.0.0 Apr 23, 2016

ChALkeR reviewed Apr 25, 2016
View reviewed changes

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

fhemberger mentioned this pull request Apr 26, 2016

www: redirect from '/<lang>/downloads/stable' to '/<lang>/downloads/current' nodejs/build#399

Closed

doc: change references to Stable to Current

d6a5f98

With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. ref: nodejs/nodejs.org#669

MylesBorins force-pushed the stable-to-current branch from 2384db1 to d6a5f98 Compare April 26, 2016 16:30

jasnell closed this Apr 26, 2016

ntwb mentioned this pull request Apr 27, 2016

Update Node.js version for Travis avajs/eslint-plugin-ava#89

Merged

MylesBorins deleted the stable-to-current branch May 12, 2016 18:14

MylesBorins added the land-on-v4.x label Jun 1, 2016

MylesBorins mentioned this pull request Jun 24, 2016

v4.4.7 proposal #7395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: change references to Stable to Current #6318

doc: change references to Stable to Current #6318

MylesBorins commented Apr 21, 2016 •

edited

Loading

jasnell commented Apr 21, 2016

MylesBorins commented Apr 21, 2016

evanlucas commented Apr 21, 2016

MylesBorins commented Apr 21, 2016 •

edited

Loading

MylesBorins commented Apr 21, 2016

evanlucas commented Apr 21, 2016

MylesBorins commented Apr 21, 2016

fhemberger commented Apr 21, 2016

Fishrock123 commented Apr 23, 2016

MylesBorins commented Apr 23, 2016 via email

Fishrock123 commented Apr 23, 2016

evanlucas commented Apr 24, 2016

Fishrock123 commented Apr 24, 2016

Fishrock123 commented Apr 24, 2016

jasnell commented Apr 24, 2016

Trott commented Apr 24, 2016

mikeal commented Apr 24, 2016

jasnell commented Apr 25, 2016

ChALkeR Apr 25, 2016

ChALkeR commented Apr 25, 2016

evanlucas commented Apr 25, 2016

fhemberger commented Apr 26, 2016 •

edited

Loading

jasnell commented Apr 26, 2016

fhemberger commented Apr 26, 2016

jasnell commented Apr 26, 2016

jasnell commented Apr 26, 2016

doc: change references to Stable to Current #6318

doc: change references to Stable to Current #6318

Conversation

MylesBorins commented Apr 21, 2016 • edited Loading

Checklist

Notes

jasnell commented Apr 21, 2016

MylesBorins commented Apr 21, 2016

evanlucas commented Apr 21, 2016

MylesBorins commented Apr 21, 2016 • edited Loading

MylesBorins commented Apr 21, 2016

evanlucas commented Apr 21, 2016

MylesBorins commented Apr 21, 2016

fhemberger commented Apr 21, 2016

Fishrock123 commented Apr 23, 2016

MylesBorins commented Apr 23, 2016 via email

Fishrock123 commented Apr 23, 2016

evanlucas commented Apr 24, 2016

Fishrock123 commented Apr 24, 2016

Fishrock123 commented Apr 24, 2016

jasnell commented Apr 24, 2016

Trott commented Apr 24, 2016

mikeal commented Apr 24, 2016

jasnell commented Apr 25, 2016

ChALkeR Apr 25, 2016

Choose a reason for hiding this comment

ChALkeR commented Apr 25, 2016

evanlucas commented Apr 25, 2016

fhemberger commented Apr 26, 2016 • edited Loading

jasnell commented Apr 26, 2016

fhemberger commented Apr 26, 2016

jasnell commented Apr 26, 2016

jasnell commented Apr 26, 2016

MylesBorins commented Apr 21, 2016 •

edited

Loading

MylesBorins commented Apr 21, 2016 •

edited

Loading

fhemberger commented Apr 26, 2016 •

edited

Loading