Rename 'Stable' release to 'Current' #672

fhemberger · 2016-04-21T06:14:47Z

PR for #669:

I haven't changed any release blog posts prior 4.0. The old Node.js version numbers used the terms stable/unstable.
We will need a redirect from /<lang>/downloads/stable to /<lang>/downloads/current: www: redirect from '/<lang>/downloads/stable' to '/<lang>/downloads/current' build#399
~~Changing markdown files while running npm run serve crashes the process:~~ Fixed (cherry-picked to master)
~~Some tests are failing for release blogpost generation, @phillipj can you please take a look?~~

MylesBorins · 2016-04-21T06:19:29Z

@fhemberger thanks for getting this started. I'll take a proper look tomorrow

lpinca · 2016-04-21T06:22:34Z

Changing markdown files while running npm run serve crashes the process:

I think this is unrelated to this change, I sporadically received the same error in the last days.

lpinca · 2016-04-21T06:31:09Z

locale/it/index.md

-  other-stable-downloads: Altri Download Stabili
-  stable: Stabile
+  other-current-downloads: Altri Download Stabili
+  current: Stabile


current: Corrente

fhemberger · 2016-04-21T06:38:31Z

locale/it/index.md

-  other-stable-downloads: Altri Download Stabili
-  stable: Stabile
+  other-current-downloads: Altri Download Stabili
+  current: Corrente


@lpinca Grazie! ;)

this is the exact kind of stuff I knew I would miss. Thanks for getting on it so quickly @fhemberger !!!

hiroppy · 2016-04-21T07:23:20Z

@fhemberger @lpinca I think buildLocale shouldn't get source as string when file is changed.

https://github.com/nodejs/nodejs.org/blob/master/server.js#L44
https://github.com/nodejs/nodejs.org/blob/master/build.js#L57

lpinca · 2016-04-21T07:24:15Z

tests/scripts/release-post.test.js

    const github = nock('https://raw.githubusercontent.com')
      .get('/nodejs/node/v4.1.0/CHANGELOG.md')
      .replyWithFile(200, changelogFixture)

    releasePost.fetchVersionPolicy('4.1.0').then((policy) => {
-      t.equal(policy, 'Stable')
+      t.equal(policy, 'Current')


This assertion fails because the channel is resolved as "Stable" from the fixture.
Maybe it makes sense to create a new fixture faking a changelog for the "Current" channel.

Does the name change affect existing releases? If not, this assertion should not be changed as v4.1.0 should still be considered "stable".

Does the name change affect existing releases?

I vote yes.

I vote yes.

I would agree in the eyes of consistency, but that would possibly mean updating all previous changelogs/blogs etc, I'm not sure that's preferable.

@fhemberger as I'm not sure what to do about previous releases, I've made two branches with contains fixes for both scenarios:

rename-stable-old-still-stable: old releases should still be named "Stable"

rename-stable-incl-old-releases: rename old releases to "Stable" as well

Merge or cherry-pick what ever commit you see fit. IMO keeping "Stable" for old releases would be okey for this PR, further discussion and a permanent fix could be raised in a separate issue/PR.

lpinca · 2016-04-21T07:54:28Z

@abouthiroppy it makes sense.

fhemberger · 2016-04-21T09:45:44Z

@abouthiroppy Good catch, thanks! Crash is fixed.

jasnell · 2016-04-21T12:45:51Z

@node/ctc ... FYI
The naming change LGTM.

preco21 · 2016-04-26T05:56:27Z

locale/ko/index.md

@@ -6,10 +6,10 @@ labels:
  download-for: Download for
  other-downloads: 다른 운영 체제
  other-lts-downloads: 다른 LTS 다운로드
-  other-stable-downloads: 다른 안정 버전 다운로드


@fhemberger Could you change '안정' to '현재' on here? ('stable' to 'current' in Korean)
Any other things are LGTM.

@preco21 Updated the translation, also on the next line.

@fhemberger Cool! Thank you.

fhemberger · 2016-04-26T08:56:56Z

@phillipj I went with the old releases to be changed as well. Updated release posts and weekly updates for v4.x/5.x releases.

Anything else missing or are we good?

MylesBorins · 2016-04-26T09:47:00Z

locale/en/blog/release/v4.1.1.md

@@ -2,7 +2,7 @@
 date: 2015-09-23T02:01:38.545Z
 version: 4.1.1
 category: release
-title: Node v4.1.1 (Stable)
+title: Node v4.1.1 (Current)


I'm not under the impression that we will be changing the release type of old releases... these posts should likely remain unchanged

just seeing that this was discussed above. I for one would push towards not making a decision in this PR and supporting the old names. There is no way for us to update release commits, and I do not believe there is any intention of modifying the changelogs. It would be odd if the release posts + changelogs are not the same

That's why I did this in a separate commit, so the others can be cherry-picked, if needed.

mikeal · 2016-04-26T15:30:32Z

I'm going to merge this. We have other messaging lined up around this terminology going out today and the website should line up with it. So far there have been zero objections from any member of any WG.

fhemberger · 2016-04-26T15:47:47Z

@mikeal We need this redirect to land as well, otherwise the old download links for stable builds will be broken: nodejs/build#399

ghost · 2016-04-26T16:11:34Z

also: should we note this as news and post about it? just to archive it officially

jasnell · 2016-04-26T16:14:02Z

I will be including a note about the change in the v6 release notes.

MylesBorins · 2016-04-26T16:36:00Z

so this was landed with change to all of the past blog posts from stable -> current. We might want to revisit this change as it is going to create a delta from the changelog and releases where this is not going to change

MylesBorins · 2016-04-26T16:36:05Z

/cc @jasnell

With the change of release names from 'Stable' to 'Current' (introduced with Node.js v6), the old download page needs to be redirected. PR-URL: #399 Refs: nodejs/node#6318 Refs: nodejs/nodejs.org#672 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

fhemberger added help wanted on hold needs WG +1 and removed help wanted labels Apr 21, 2016

fhemberger mentioned this pull request Apr 21, 2016

Re-brand "Stable" channel to "Current" #669

Closed

MylesBorins mentioned this pull request Apr 21, 2016

doc: change references to Stable to Current nodejs/node#6318

Closed

5 tasks

lpinca reviewed Apr 21, 2016
View reviewed changes

Rename 'Stable' release to 'Current'

89a783c

fhemberger force-pushed the feature/rename-stable branch from 8222f49 to 89a783c Compare April 21, 2016 06:36

fhemberger reviewed Apr 21, 2016
View reviewed changes

lpinca reviewed Apr 21, 2016
View reviewed changes

build: Fix crash when changing files during serve

d359720

preco21 reviewed Apr 26, 2016
View reviewed changes

phillipj and others added 4 commits April 26, 2016 10:26

Rename 'Stable' release to 'Current': old releases also renamed

335cbd0

Rename 'Stable' release to 'Current': Update Korean translation

a88dbd6

Rename 'Stable' release to 'Current': Update v4.x/5.x release posts

2431706

Rename 'Stable' release to 'Current': Update weekly update posts

caece5f

fhemberger mentioned this pull request Apr 26, 2016

www: redirect from '/<lang>/downloads/stable' to '/<lang>/downloads/current' nodejs/build#399

Closed

MylesBorins reviewed Apr 26, 2016
View reviewed changes

mikeal merged commit 494280c into master Apr 26, 2016

Fishrock123 mentioned this pull request Apr 26, 2016

2016-04-26, Version 6.0.0 (Current) Release nodejs/node#6383

Closed

ChALkeR removed the on hold label Apr 26, 2016

stevemao deleted the feature/rename-stable branch April 26, 2016 23:31

marocchino removed the needs WG +1 label Oct 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename 'Stable' release to 'Current' #672

Rename 'Stable' release to 'Current' #672

fhemberger commented Apr 21, 2016 •

edited

Loading

MylesBorins commented Apr 21, 2016

lpinca commented Apr 21, 2016

lpinca Apr 21, 2016

fhemberger Apr 21, 2016

MylesBorins Apr 21, 2016

hiroppy commented Apr 21, 2016 •

edited

Loading

lpinca Apr 21, 2016 •

edited

Loading

phillipj Apr 21, 2016

stevemao Apr 21, 2016

phillipj Apr 22, 2016

lpinca commented Apr 21, 2016

fhemberger commented Apr 21, 2016

jasnell commented Apr 21, 2016

preco21 Apr 26, 2016 •

edited

Loading

fhemberger Apr 26, 2016

preco21 Apr 26, 2016

fhemberger commented Apr 26, 2016 •

edited

Loading

MylesBorins Apr 26, 2016

MylesBorins Apr 26, 2016

fhemberger Apr 26, 2016

mikeal commented Apr 26, 2016

fhemberger commented Apr 26, 2016

ghost commented Apr 26, 2016

jasnell commented Apr 26, 2016

MylesBorins commented Apr 26, 2016

MylesBorins commented Apr 26, 2016

Rename 'Stable' release to 'Current' #672

Rename 'Stable' release to 'Current' #672

Conversation

fhemberger commented Apr 21, 2016 • edited Loading

MylesBorins commented Apr 21, 2016

lpinca commented Apr 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hiroppy commented Apr 21, 2016 • edited Loading

lpinca Apr 21, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lpinca commented Apr 21, 2016

fhemberger commented Apr 21, 2016

jasnell commented Apr 21, 2016

preco21 Apr 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fhemberger commented Apr 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikeal commented Apr 26, 2016

fhemberger commented Apr 26, 2016

ghost commented Apr 26, 2016

jasnell commented Apr 26, 2016

MylesBorins commented Apr 26, 2016

MylesBorins commented Apr 26, 2016

fhemberger commented Apr 21, 2016 •

edited

Loading

hiroppy commented Apr 21, 2016 •

edited

Loading

lpinca Apr 21, 2016 •

edited

Loading

preco21 Apr 26, 2016 •

edited

Loading

fhemberger commented Apr 26, 2016 •

edited

Loading