tools: do not build addons during compilation #6723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
added
build
|
/cc @nodejs/build @bnoordhuis |
|
LGTM |
The current makefile runs both `cctest` and `build-addons` in parallel under the assumption that both rely on `all`. Unfortunately `build-addons` does not rely on all, and there is an edge case where by it is possible to call `build-addons` while compilation is still happening. This patch takes the simplest route by forcing `build-addons` and `cctest` to run in sequence like the other test targets. This ensures that `build-addons` will never be run during compilation. It would be possible to modify `build-addons` to rely on `all` but it would be a much more aggressive change to the MAKEFILE for a fairly minor perf bump, as cctest is so fast. PR-URL: nodejs#6723 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
force-pushed
the
fix-make-test
branch
from
b2fe55b
to
5d64ff4
Compare
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
The current makefile runs both `cctest` and `build-addons` in parallel under the assumption that both rely on `all`. Unfortunately `build-addons` does not rely on all, and there is an edge case where by it is possible to call `build-addons` while compilation is still happening. This patch takes the simplest route by forcing `build-addons` and `cctest` to run in sequence like the other test targets. This ensures that `build-addons` will never be run during compilation. It would be possible to modify `build-addons` to rely on `all` but it would be a much more aggressive change to the MAKEFILE for a fairly minor perf bump, as cctest is so fast. PR-URL: #6723 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Tools
Description of change
The current makefile runs both
cctestandbuild-addonsin parallelunder the assumption that both rely on
all. Unfortunatelybuild-addonsdoes not rely on all, and there is an edge case whereby it is possible to call
build-addonswhile compilation is stillhappening.
This patch takes the simplest route by forcing
build-addonsandcctestto run in sequence like the other test targets. This ensuresthat
build-addonswill never be run during compilation.It would be possible to modify
build-addonsto rely onallbut itwould be a much more aggressive change to the MAKEFILE for a fairly
minor perf bump, as cctest is so fast.