Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: do not build addons during compilation #6723

Merged
merged 1 commit into from
May 13, 2016
Merged

tools: do not build addons during compilation #6723

merged 1 commit into from
May 13, 2016

Commits on May 13, 2016

  1. tools: do not build addons during compilation 

    The current makefile runs both `cctest` and `build-addons` in parallel
under the assumption that both rely on `all`. Unfortunately
`build-addons` does not rely on all, and there is an edge case where
by it is possible to call `build-addons` while compilation is still
happening.

This patch takes the simplest route by forcing `build-addons` and
`cctest` to run in sequence like the other test targets. This ensures
that `build-addons` will never be run during compilation.

It would be possible to modify `build-addons` to rely on `all` but it
would be a much more aggressive change to the MAKEFILE for a fairly
minor perf bump, as cctest is so fast.

PR-URL: nodejs#6723
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Myles Borins committed May 13, 2016
    Configuration menu
    Copy the full SHA
    5d64ff4 View commit details
    Browse the repository at this point in the history