os: deprecate tmpDir() in favour of tmpdir()
#6739
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
the
semver-major
|
LGTM |
|
@ChALkeR could you npm-check this? |
|
@Fishrock123 https://gist.github.com/ChALkeR/0140f2757f33c06121e2002acc4b87b9 I searched for |
|
LGTM if a citgm check comes up good. |
This was referenced May 13, 2016
|
@Fishrock123 Also note that a significant part of those are using something like |
|
Running an updated citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/333/ |
|
one failure in citgm, looks like an unrelated jquery failure on osx. this LGTM |
|
jquery is a known flaky... I'm going to report it to them and add it to the flaky list |
`tmpdir()` was introduced as replacement 3 years ago in 3fe6aba PR-URL: nodejs#6739 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
force-pushed
the
os-deprecate-tmpDir
branch
from
f0ab7c7 to
5e5ec2c
Compare
This was referenced Oct 26, 2016
rudidude86
pushed a commit
to rudidude86/grunt-phplint
that referenced
this pull request
Jan 16, 2017
* call [`os.tmpdir()`](https://nodejs.org/api/os.html#os_os_tmpdir) instead of the [deprecated `os.tmpDir()` alias](nodejs/node#6739) * include newer version of cache-swap with [tmpDir -> tmpdir issue fixed](jgable/cache-swap@69fab2b)
rudidude86
pushed a commit
to rudidude86/grunt-phplint
that referenced
this pull request
Jan 16, 2017
* call [`os.tmpdir()`](https://nodejs.org/api/os.html#os_os_tmpdir) instead of the [deprecated `os.tmpDir()` alias](nodejs/node#6739) * include newer version of cache-swap with [tmpDir -> tmpdir issue fixed](jgable/cache-swap@69fab2b)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
os
Description of change
tmpdir()was introduced as replacement 3 years ago in3fe6aba
cc @bnoordhuis?
CI: https://ci.nodejs.org/job/node-test-pull-request/2636/