Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #447

Closed
adam-lynch opened this issue May 20, 2017 · 5 comments
Closed

Update dependencies #447

adam-lynch opened this issue May 20, 2017 · 5 comments
Assignees
Labels
chore Priority: 3

Comments

@adam-lynch
Copy link
Contributor

adam-lynch commented May 20, 2017

Add greenkeeper preferably. Edit: it's already hooked up but broken possibly. Need to more a few PRs too... depends on #446.

@bastimeyer
Copy link
Contributor

Thanks, @adam-lynch, for spending some time on this project again. 👍

Since you're intending to upgrade the dependencies, could you please take a look at the temp dependency? This one is causing an annoying deprecation message on newer node versions.

If you run node --trace-deprecation ..., you can see that it's coming from there.
This has already been fixed in a newer version two years ago, but the dependency doesn't seem to be maintained anymore, so maybe you want to take a look at another one, if it's necessary.

(node:12673) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
  at Object.<anonymous> (/home/basti/foo/node_modules/temp/lib/temp.js:170:45)

@adam-lynch
Copy link
Contributor Author

adam-lynch commented May 20, 2017 via email

@adam-lynch adam-lynch added the chore Priority: 3 label May 27, 2017
@adam-lynch adam-lynch self-assigned this May 27, 2017
@adam-lynch
Copy link
Contributor Author

This one is causing an annoying deprecation message on newer node versions.

@bastimeyer like what? I don't see it when using Node 6.10.3

@bastimeyer
Copy link
Contributor

like what?

The one I already posted:
DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

Node 6.10.3

This has been deprecated in node 7:
nodejs/node#6739

@adam-lynch
Copy link
Contributor Author

I meant which version. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Priority: 3
Projects
None yet
Development

No branches or pull requests

2 participants