dns: lookupService() callback must be a function #8170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookupService() requires a callback function. This commit adds a check to verify that the callback is actually a function.
makeAsync() is an internal method in the dns module. All of the functions that call makeAsync() have already validated that the callback is a function. This commit removes a redundant typeof function check.
|
Hmmmm.... my knee jerk reaction is semver-major but you're right, it didn't work previously if a function wasn't passed.... I think that's enough to label this a semver-patch. |
|
The change itself LGTM |
|
LGTM |
|
LGTM and CI: https://ci.nodejs.org/job/node-test-pull-request/3751 :-) |
|
CI again because Jenkins: https://ci.nodejs.org/job/node-test-pull-request/3767/ |
jasnell
pushed a commit
that referenced
this pull request
Aug 22, 2016
lookupService() requires a callback function. This commit adds a check to verify that the callback is actually a function. PR-URL: #8170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Aug 22, 2016
makeAsync() is an internal method in the dns module. All of the functions that call makeAsync() have already validated that the callback is a function. This commit removes a redundant typeof function check. PR-URL: #8170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
|
Landed in 3a43568 and 013d76c. |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
lookupService() requires a callback function. This commit adds a check to verify that the callback is actually a function. PR-URL: #8170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
makeAsync() is an internal method in the dns module. All of the functions that call makeAsync() have already validated that the callback is a function. This commit removes a redundant typeof function check. PR-URL: #8170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
dns
Description of change
lookupService()requires a callback function. The first commit in this PR adds a check to verify that the callback is actually a function.As a result of the first commit, the second commit drops a pointless check.
makeAsync()is an internal method in the dns module. All of the functions that callmakeAsync()have already validated that the callback is a function. The second commit removes a redundanttypeoffunction check.lookupService()already does not work unless a function is passed, but technically the change in error message makes this a semver major. It is worth noting that currently, if you pass an object as the callback,lookupService()does not throw immediately, and instead throws in an asynchronous callback. Perhaps that is enough to convince someone that this is a bug fix and not just a semver major error message change ;-)