Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: lookupService() callback must be a function #8170

Closed
wants to merge 2 commits into from
Closed

dns: lookupService() callback must be a function #8170

wants to merge 2 commits into from

Commits on Aug 18, 2016

  1. dns: lookupService() callback must be a function 

    lookupService() requires a callback function. This commit adds
a check to verify that the callback is actually a function.
    @cjihrig
    cjihrig committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    39ba118 View commit details
    Browse the repository at this point in the history

  2. dns: remove makeAsync() function check 

    makeAsync() is an internal method in the dns module. All of the
functions that call makeAsync() have already validated that the
callback is a function. This commit removes a redundant typeof
function check.
    @cjihrig
    cjihrig committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    2bebeb1 View commit details
    Browse the repository at this point in the history