tls: fix minor jslint failure for v0.10 #9107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
approved these changes
Oct 15, 2016
|
@rvagg Are we definitely doing another release of v0.10? |
rvagg
added a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #9107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
landed @ b798f59 |
rvagg
added a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #9107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 18, 2016
rvagg
added a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #9107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 22, 2016
PR-URL: nodejs/node#9107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really minor but it passes
make jslinton v0.10, we broke it backporting the TLS wildcard checking vulnerability in the last release @ 0d7e21e. As long as we're doing another release we may as well clean up!